From: "H. Peter Anvin" <hpa@zytor.com>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: Scott Preece <sepreece@gmail.com>,
"John Anthony Kazos Jr." <jakj@j-a-k-j.com>,
Valdis.Kletnieks@vt.edu, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch 1/1] document Acked-by:
Date: Fri, 01 Jun 2007 15:17:16 -0700 [thread overview]
Message-ID: <46609AEC.4070603@zytor.com> (raw)
In-Reply-To: <m3fy5b5nrt.fsf@maximus.localdomain>
Krzysztof Halasa wrote:
> "Scott Preece" <sepreece@gmail.com> writes:
>
>> This is a question worth answering - is it rude to ack/nak a patch if
>> you're not a maintainer or otherwise known-to-be-trusted, or is it OK
>> for anyone to express an opinion? Andrew's patch text seems to imply
>> that it's generally OK.
>
> Every pair of eyes (or a single one) looking at the patch in question
> is a good thing. I can't imagine why would one want to look at the
> code if he/she can't ack or nak or otherwise comment it.
I think the comment had to do with the concept that ACK/NAK implies
authority. If you're not the maintainer, it's rude to imply that you
are. Obvious, test reports (good or bad!) are always welcome.
-hpa
next prev parent reply other threads:[~2007-06-01 22:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-01 2:09 [patch 1/1] document Acked-by: akpm
2007-06-01 5:32 ` Valdis.Kletnieks
2007-06-01 6:10 ` H. Peter Anvin
2007-06-01 10:53 ` John Anthony Kazos Jr.
2007-06-01 19:27 ` Krzysztof Halasa
2007-06-01 19:37 ` Scott Preece
2007-06-01 20:00 ` Andrew Morton
2007-06-01 20:04 ` Andrew Morton
2007-06-02 13:34 ` debian developer
2007-06-02 17:13 ` Jan Engelhardt
2007-06-02 19:34 ` Valdis.Kletnieks
2007-06-01 22:10 ` Krzysztof Halasa
2007-06-01 22:17 ` H. Peter Anvin [this message]
2007-06-01 22:42 ` Krzysztof Halasa
2007-06-02 0:37 ` John Anthony Kazos Jr.
2007-06-02 0:56 ` Krzysztof Halasa
2007-06-02 1:36 ` Valdis.Kletnieks
2007-06-01 17:27 ` Valdis.Kletnieks
2007-06-01 17:35 ` Andrew Morton
2007-06-01 18:14 ` Dave Jones
2007-06-01 18:22 ` Andrew Morton
2007-06-01 18:28 ` Dave Jones
2007-06-02 17:17 ` Jan Engelhardt
2007-06-02 18:00 ` John Anthony Kazos Jr.
2007-06-02 19:07 ` Sam Ravnborg
2007-06-02 14:11 ` Adrian Bunk
2007-06-02 17:47 ` Andrew Morton
2007-06-02 17:55 ` Adrian Bunk
2007-06-03 0:23 ` Krzysztof Halasa
2007-06-03 2:57 ` Scott Preece
2007-06-03 4:06 ` Randy Dunlap
2007-06-03 4:15 ` Andrew Morton
2007-06-03 18:31 ` Scott Preece
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46609AEC.4070603@zytor.com \
--to=hpa@zytor.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=jakj@j-a-k-j.com \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=sepreece@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.