From: Avi Kivity <avi@qumranet.com>
To: Jun Koi <junkoi2004@gmail.com>
Cc: kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [kvm-devel] [GIT PULL][RESEND] KVM cpu hotplug fixes
Date: Sat, 02 Jun 2007 10:32:59 +0300 [thread overview]
Message-ID: <46611D2B.1060004@qumranet.com> (raw)
In-Reply-To: <fdaac4d50706020003g5f1658fewf6e0757aaa1c27bd@mail.gmail.com>
Jun Koi wrote:
> Hi Avi,
>
> On 6/2/07, Avi Kivity <avi@qumranet.com> wrote:
>> Linus Torvalds wrote:
>> > Don't send me pull requests like this. And absolutely do NOT send
>> them as
>> > resends. I just get grumpy.
>> >
>> > If all the added code had been KVM-only, I might not care. But when
>> the
>> > bulk of the code touches core files, you had better explain why
>> this is so
>> > important that it cannot wait for the next merge window.
>>
>> Ok. This was really wanted by laptop-carrying users, but I guess
>> they'll have to wait for 2.6.23.
>>
>
> Could you explain a bit:
>
> 1) Why CPU hotplug is that important for virtualization?
>
It's not specifically important for virtualization. It's a Linux kernel
feature, and right now it doesn't work very well when kvm is enabled,
and that should be fixed.
> 2) Why this patch is wanted by laptop users?
CPU hotplug is used by suspend/resume (basically, suspend hot-unplugs
all cpus except one an then suspends the machine. Resume hotplugs the
cpus back after restarting the devices).
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Jun Koi <junkoi2004-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [GIT PULL][RESEND] KVM cpu hotplug fixes
Date: Sat, 02 Jun 2007 10:32:59 +0300 [thread overview]
Message-ID: <46611D2B.1060004@qumranet.com> (raw)
In-Reply-To: <fdaac4d50706020003g5f1658fewf6e0757aaa1c27bd-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Jun Koi wrote:
> Hi Avi,
>
> On 6/2/07, Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org> wrote:
>> Linus Torvalds wrote:
>> > Don't send me pull requests like this. And absolutely do NOT send
>> them as
>> > resends. I just get grumpy.
>> >
>> > If all the added code had been KVM-only, I might not care. But when
>> the
>> > bulk of the code touches core files, you had better explain why
>> this is so
>> > important that it cannot wait for the next merge window.
>>
>> Ok. This was really wanted by laptop-carrying users, but I guess
>> they'll have to wait for 2.6.23.
>>
>
> Could you explain a bit:
>
> 1) Why CPU hotplug is that important for virtualization?
>
It's not specifically important for virtualization. It's a Linux kernel
feature, and right now it doesn't work very well when kvm is enabled,
and that should be fixed.
> 2) Why this patch is wanted by laptop users?
CPU hotplug is used by suspend/resume (basically, suspend hot-unplugs
all cpus except one an then suspends the machine. Resume hotplugs the
cpus back after restarting the devices).
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
next prev parent reply other threads:[~2007-06-02 7:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-01 6:11 [GIT PULL][RESEND] KVM cpu hotplug fixes Avi Kivity
2007-06-01 6:11 ` Avi Kivity
2007-06-01 15:22 ` Linus Torvalds
2007-06-01 15:22 ` Linus Torvalds
2007-06-01 16:32 ` Avi Kivity
2007-06-01 16:32 ` Avi Kivity
2007-06-02 7:03 ` [kvm-devel] " Jun Koi
2007-06-02 7:03 ` Jun Koi
2007-06-02 7:32 ` Avi Kivity [this message]
2007-06-02 7:32 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46611D2B.1060004@qumranet.com \
--to=avi@qumranet.com \
--cc=junkoi2004@gmail.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.