[Xenomai-core] Bug when closing a busy file descriptor.

[Xenomai-core] Bug when closing a busy file descriptor.

[Gilles Chanteperdrix]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]


Hi,

there is a bug when closing a busy file descriptor: the close function
keeps incrementing the file descriptor reference count making it
impossible to really close the file descriptor.	

The attached patch fixes this.

-- 
                                                 Gilles Chanteperdrix

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: xeno-unlock-context-when-restarting-rtdm-close.diff --]
[-- Type: text/x-patch; name="xeno-unlock-context-when-restarting-rtdm-close.diff", Size: 683 bytes --]

Index: ksrc/skins/rtdm/core.c
===================================================================
--- ksrc/skins/rtdm/core.c	(révision 2533)
+++ ksrc/skins/rtdm/core.c	(copie de travail)
@@ -340,6 +340,7 @@
     XENO_ASSERT(RTDM, !rthal_local_irq_test(), rthal_local_irq_enable(););
 
     if (unlikely(ret == -EAGAIN) && !rtdm_in_rt_context()) {
+	rtdm_context_unlock(context);
         msleep(CLOSURE_RETRY_PERIOD);
         goto again;
     } else if (unlikely(ret < 0))
@@ -354,6 +355,7 @@
             ret = -EAGAIN;
             goto unlock_out;
         }
+	rtdm_context_unlock(context);
         msleep(CLOSURE_RETRY_PERIOD);
         goto again;
     }

Re: [Xenomai-core] Bug when closing a busy file descriptor.

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

Gilles Chanteperdrix wrote:
> Hi,
> 
> there is a bug when closing a busy file descriptor: the close function
> keeps incrementing the file descriptor reference count making it
> impossible to really close the file descriptor.	
> 
> The attached patch fixes this.
> 

Yep. Applied, thanks.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]