From: David Lively <dlively@virtualiron.com>
To: Keir Fraser <keir@xensource.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] [HVM] Fix 64 bit PV-on-HVM driver builds
Date: Wed, 06 Jun 2007 15:20:51 -0400 [thread overview]
Message-ID: <46670913.2000709@virtualiron.com> (raw)
In-Reply-To: <C28CC231.1032E%keir@xensource.com>
Keir Fraser wrote:
>In the patch it's pgtable-nopmd.h. But pgtable-nopud.h makes more sense
>(x86/64 Linux has always had proper pmds). So is the patch incorrect?
>
>
Oops. You're absolutely right. Both define pud_t, but nopud.h is
definitely the correct one. Thanks for catching this ....
>Also, this could be placed inside asm-x86_64/mach-xen/asm/hypervisor.h,
>couldn't it?
>
> -- Keir
>
>
>
I tried that. But since the x86_64 hypervisor.h includes the i386
hypervisor.h, I have to put the conditional include of pgtable-nopud.h
either before or after the include of i386 hypervisor.h, neither of
which compiles on pre-2.6.11 kernels.
Dave
next prev parent reply other threads:[~2007-06-06 19:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-31 23:04 [RFC][PATCH 1/6] HVM PCI Passthrough (non-IOMMU) Guy Zana
2007-06-04 18:25 ` Muli Ben-Yehuda
2007-06-04 21:43 ` Guy Zana
2007-06-05 6:37 ` Muli Ben-Yehuda
2007-06-06 16:00 ` [PATCH] [HVM] Prevent usb driver crashes in Windows Ben Guthro
2007-06-06 16:05 ` [PATCH] Fix vnc port offset in xenstore Ben Guthro
2007-06-06 16:08 ` [PATCH] [HVM] Fix 64 bit PV-on-HVM driver builds Ben Guthro
2007-06-06 16:12 ` [PATCH] [HVM] Allow mkbuildtree to override XEN and XL Ben Guthro
2007-06-06 16:17 ` [PATCH] [HVM] Fix 64 bit PV-on-HVM driver builds Jan Beulich
2007-06-06 16:26 ` [PATCH] [QEMU] remove .depend file on clean build Ben Guthro
2007-06-06 16:38 ` [PATCH] [HVM] Fix 64 bit PV-on-HVM driver builds Keir Fraser
2007-06-06 18:42 ` Dave Lively
2007-06-06 18:57 ` Keir Fraser
2007-06-06 19:20 ` David Lively [this message]
2007-06-06 16:40 ` [PATCH] [HVM] Prevent usb driver crashes in Windows Keir Fraser
2007-06-06 17:03 ` Steve Ofsthun
2007-06-06 18:22 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46670913.2000709@virtualiron.com \
--to=dlively@virtualiron.com \
--cc=keir@xensource.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.