From: Avi Kivity <avi@qumranet.com>
To: Jeff Dike <jdike@addtoit.com>
Cc: "Li, Xin B" <xin.b.li@intel.com>,
kvm-devel@lists.sourceforge.net,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [kvm-devel] [PATCH] KVM - Fix rmode_tss_base declaration
Date: Thu, 07 Jun 2007 08:09:48 +0300 [thread overview]
Message-ID: <4667931C.8070007@qumranet.com> (raw)
In-Reply-To: <20070607031103.GA12462@c2.user-mode-linux.org>
Jeff Dike wrote:
> On Thu, Jun 07, 2007 at 10:13:42AM +0800, Li, Xin B wrote:
>
>>> -static int rmode_tss_base(struct kvm* kvm)
>>> +static unsigned long rmode_tss_base(struct kvm* kvm)
>>>
>> Should use gpa_t instead.
>>
>
> Right you are, I didn't notice that type.
>
>
Some extra logic is needed on i386 with >= 4GB. Current code will
wraparound since gfn_t is 32-bits long, but casting it to 64-bits is not
the answer since the processor will truncate it back to 32 bits (the
return value is eventually used as a long in enter_rmode()).
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Jeff Dike <jdike-OPE4K8JWMJJBDgjK7y7TUQ@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] KVM - Fix rmode_tss_base declaration
Date: Thu, 07 Jun 2007 08:09:48 +0300 [thread overview]
Message-ID: <4667931C.8070007@qumranet.com> (raw)
In-Reply-To: <20070607031103.GA12462-1LLyehjZOUUZWFFyALql+T+iFHGzDt/a@public.gmane.org>
Jeff Dike wrote:
> On Thu, Jun 07, 2007 at 10:13:42AM +0800, Li, Xin B wrote:
>
>>> -static int rmode_tss_base(struct kvm* kvm)
>>> +static unsigned long rmode_tss_base(struct kvm* kvm)
>>>
>> Should use gpa_t instead.
>>
>
> Right you are, I didn't notice that type.
>
>
Some extra logic is needed on i386 with >= 4GB. Current code will
wraparound since gfn_t is 32-bits long, but casting it to 64-bits is not
the answer since the processor will truncate it back to 32 bits (the
return value is eventually used as a long in enter_rmode()).
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
next prev parent reply other threads:[~2007-06-07 5:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 19:19 [PATCH] KVM - Fix rmode_tss_base declaration Jeff Dike
2007-06-06 19:19 ` Jeff Dike
2007-06-07 2:13 ` [kvm-devel] " Li, Xin B
2007-06-07 2:13 ` Li, Xin B
2007-06-07 3:11 ` [kvm-devel] " Jeff Dike
2007-06-07 3:11 ` Jeff Dike
2007-06-07 5:09 ` Avi Kivity [this message]
2007-06-07 5:09 ` Avi Kivity
2007-06-08 19:44 ` [kvm-devel] " Jeff Dike
2007-06-08 19:44 ` Jeff Dike
2007-06-10 7:36 ` [kvm-devel] " Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4667931C.8070007@qumranet.com \
--to=avi@qumranet.com \
--cc=jdike@addtoit.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=xin.b.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.