* [U-Boot-Users] U-boot-testing. [not found] <20070605101705.825E1353A97@atlas.denx.de> @ 2007-06-09 6:52 ` mushtaq khan 2007-06-16 6:24 ` mushtaq khan 0 siblings, 1 reply; 4+ messages in thread From: mushtaq khan @ 2007-06-09 6:52 UTC (permalink / raw) To: u-boot Hi Wolfgang Denk, Attached a sata patch with respect to u-boot-testing repository, this resolves the proto-type mismatch between sata_read and block_read. Thanks, -Mushtaq Wolfgang Denk wrote: >Hello, > >in message <46652EF4.1030707@procsys.com> you wrote: > > >>I tested my patches in u-boot-testing >>1. Clearing of bss section patch and >>2. Sata patch. >> >> > >Thanks. > > > >>I will bring these changes to my patch. And after testing , i will >>re-submit the patch. >> >> > >No. Please submit a new patch against current top-of-tree in the >u-boot-testing repository. > >Thanks. > >Best regards, > >Wolfgang Denk > > > -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: sata_utest.patch Url: http://lists.denx.de/pipermail/u-boot/attachments/20070609/7ba590f1/attachment.txt ^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot-Users] U-boot-testing. 2007-06-09 6:52 ` [U-Boot-Users] U-boot-testing mushtaq khan @ 2007-06-16 6:24 ` mushtaq khan 2007-06-17 16:50 ` Leonid 2007-06-17 21:11 ` Wolfgang Denk 0 siblings, 2 replies; 4+ messages in thread From: mushtaq khan @ 2007-06-16 6:24 UTC (permalink / raw) To: u-boot Hi Wolfgang Denk, I had submitted the sata patch with respect to u-boot-testing repository.I didn't get any feedbac, what is the next step? Please let me know. Thanks, -Mushtaq mushtaq khan wrote: > Hi Wolfgang Denk, > > Attached a sata patch with respect to u-boot-testing repository, > this resolves the proto-type mismatch between sata_read and block_read. > > Thanks, > -Mushtaq > > > Wolfgang Denk wrote: > >> Hello, >> >> in message <46652EF4.1030707@procsys.com> you wrote: >> >> >>> I tested my patches in u-boot-testing >>> 1. Clearing of bss section patch and >>> 2. Sata patch. >>> >> >> >> Thanks. >> >> >> >>> I will bring these changes to my patch. And after testing , i will >>> re-submit the patch. >>> >> >> >> No. Please submit a new patch against current top-of-tree in the >> u-boot-testing repository. >> >> Thanks. >> >> Best regards, >> >> Wolfgang Denk >> >> >> > >------------------------------------------------------------------------ > >diff -purN u-boot-testing/common/cmd_sata.c u-boot-testing_chg/common/cmd_sata.c >--- u-boot-testing/common/cmd_sata.c 2007-06-05 12:05:10.000000000 +0530 >+++ u-boot-testing_chg/common/cmd_sata.c 2007-06-07 13:46:55.000000000 +0530 >@@ -375,9 +375,9 @@ msleep (int count) > } > > ulong >-sata_read (int device, lbaint_t blknr, ulong blkcnt, ulong * buffer) >+sata_read (int device, ulong blknr,lbaint_t blkcnt, void * buff) > { >- ulong n = 0; >+ ulong n = 0, *buffer = (ulong *)buff; > u8 dev = 0, num = 0, mask = 0, status = 0; > > #ifdef CONFIG_LBA48 >@@ -482,9 +482,9 @@ sata_read (int device, lbaint_t blknr, u > } > > ulong >-sata_write (int device, lbaint_t blknr, ulong blkcnt, ulong * buffer) >+sata_write (int device, ulong blknr,lbaint_t blkcnt, void * buff) > { >- ulong n = 0; >+ ulong n = 0, *buffer = (ulong *)buff; > unsigned char status = 0, num = 0, dev = 0, mask = 0; > > #ifdef CONFIG_LBA48 >diff -purN u-boot-testing/include/sata.h u-boot-testing_chg/include/sata.h >--- u-boot-testing/include/sata.h 2007-06-05 12:05:11.000000000 +0530 >+++ u-boot-testing_chg/include/sata.h 2007-06-07 13:43:08.000000000 +0530 >@@ -28,8 +28,8 @@ struct sata_port { > struct sata_ioports ioaddr; /* ATA cmd/ctl/dma reg blks */ > unsigned char ctl_reg; > unsigned char last_ctl; >- unsigned char port_state; /* 1-port is present and */ >- 0-port is not available */ >+ unsigned char port_state; /* 1-port is available and */ >+ /* 0-port is not available */ > unsigned char dev_mask; > }; > >@@ -74,18 +74,18 @@ int sata_devchk (struct sata_ioports *io > void dev_select (struct sata_ioports *ioaddr, int dev); > u8 sata_busy_wait (struct sata_ioports *ioaddr, int bits, unsigned int max); > u8 sata_chk_status (struct sata_ioports *ioaddr); >-ulong sata_read (int device, lbaint_t blknr, ulong blkcnt, ulong * buffer); >-ulong sata_write (int device, lbaint_t blknr, ulong blkcnt, ulong * buffer); >+ulong sata_read (int device, ulong blknr,lbaint_t blkcnt, void * buffer); >+ulong sata_write (int device,ulong blknr, lbaint_t blkcnt, void * buffer); > void msleep (int count); > #else > extern int sata_bus_softreset (int num); > extern void sata_identify (int num, int dev); > extern void sata_port (struct sata_ioports *ioport); > extern void set_Feature_cmd (int num, int dev); >-extern ulong sata_read (int device, lbaint_t blknr, >- ulong blkcnt, ulong * buffer); >-extern ulong sata_write (int device, lbaint_t blknr, >- ulong blkcnt, ulong * buffer); >+extern ulong sata_read (int device, ulong blknr, >+ lbaint_t blkcnt, void * buffer); >+extern ulong sata_write (int device, ulong blknr, >+ lbaint_t blkcnt, void * buffer); > extern void msleep (int count); > #endif > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot-Users] U-boot-testing. 2007-06-16 6:24 ` mushtaq khan @ 2007-06-17 16:50 ` Leonid 2007-06-17 21:11 ` Wolfgang Denk 1 sibling, 0 replies; 4+ messages in thread From: Leonid @ 2007-06-17 16:50 UTC (permalink / raw) To: u-boot Can you tell me please where I can learn more about u-boot testing repository (some READMEs, etc...)? What this project is about (well, it's apparently testing something, but testing is to broad a definition), how to use it, etc... Does it have anything in common with Denx Universal Testing Suite (DUTS) project (I would like to learn about last one too). Thanks, Leonid. -----Original Message----- From: u-boot-users-bounces@lists.sourceforge.net [mailto:u-boot-users-bounces at lists.sourceforge.net] On Behalf Of mushtaq khan Sent: Friday, June 15, 2007 11:24 PM To: Wolfgang Denk Cc: u-boot-user Subject: Re: [U-Boot-Users] U-boot-testing. Hi Wolfgang Denk, I had submitted the sata patch with respect to u-boot-testing repository.I didn't get any feedbac, what is the next step? Please let me know. Thanks, -Mushtaq mushtaq khan wrote: > Hi Wolfgang Denk, > > Attached a sata patch with respect to u-boot-testing repository, > this resolves the proto-type mismatch between sata_read and block_read. > > Thanks, > -Mushtaq > > > Wolfgang Denk wrote: > >> Hello, >> >> in message <46652EF4.1030707@procsys.com> you wrote: >> >> >>> I tested my patches in u-boot-testing >>> 1. Clearing of bss section patch and >>> 2. Sata patch. >>> >> >> >> Thanks. >> >> >> >>> I will bring these changes to my patch. And after testing , i will >>> re-submit the patch. >>> >> >> >> No. Please submit a new patch against current top-of-tree in the >> u-boot-testing repository. >> >> Thanks. >> >> Best regards, >> >> Wolfgang Denk >> >> >> > >----------------------------------------------------------------------- - > >diff -purN u-boot-testing/common/cmd_sata.c u-boot-testing_chg/common/cmd_sata.c >--- u-boot-testing/common/cmd_sata.c 2007-06-05 12:05:10.000000000 +0530 >+++ u-boot-testing_chg/common/cmd_sata.c 2007-06-07 13:46:55.000000000 +0530 >@@ -375,9 +375,9 @@ msleep (int count) > } > > ulong >-sata_read (int device, lbaint_t blknr, ulong blkcnt, ulong * buffer) >+sata_read (int device, ulong blknr,lbaint_t blkcnt, void * buff) > { >- ulong n = 0; >+ ulong n = 0, *buffer = (ulong *)buff; > u8 dev = 0, num = 0, mask = 0, status = 0; > > #ifdef CONFIG_LBA48 >@@ -482,9 +482,9 @@ sata_read (int device, lbaint_t blknr, u > } > > ulong >-sata_write (int device, lbaint_t blknr, ulong blkcnt, ulong * buffer) >+sata_write (int device, ulong blknr,lbaint_t blkcnt, void * buff) > { >- ulong n = 0; >+ ulong n = 0, *buffer = (ulong *)buff; > unsigned char status = 0, num = 0, dev = 0, mask = 0; > > #ifdef CONFIG_LBA48 >diff -purN u-boot-testing/include/sata.h u-boot-testing_chg/include/sata.h >--- u-boot-testing/include/sata.h 2007-06-05 12:05:11.000000000 +0530 >+++ u-boot-testing_chg/include/sata.h 2007-06-07 13:43:08.000000000 +0530 >@@ -28,8 +28,8 @@ struct sata_port { > struct sata_ioports ioaddr; /* ATA cmd/ctl/dma reg blks */ > unsigned char ctl_reg; > unsigned char last_ctl; >- unsigned char port_state; /* 1-port is present and */ >- 0-port is not available */ >+ unsigned char port_state; /* 1-port is available and */ >+ /* 0-port is not available */ > unsigned char dev_mask; > }; > >@@ -74,18 +74,18 @@ int sata_devchk (struct sata_ioports *io > void dev_select (struct sata_ioports *ioaddr, int dev); > u8 sata_busy_wait (struct sata_ioports *ioaddr, int bits, unsigned int max); > u8 sata_chk_status (struct sata_ioports *ioaddr); >-ulong sata_read (int device, lbaint_t blknr, ulong blkcnt, ulong * buffer); >-ulong sata_write (int device, lbaint_t blknr, ulong blkcnt, ulong * buffer); >+ulong sata_read (int device, ulong blknr,lbaint_t blkcnt, void * buffer); >+ulong sata_write (int device,ulong blknr, lbaint_t blkcnt, void * buffer); > void msleep (int count); > #else > extern int sata_bus_softreset (int num); > extern void sata_identify (int num, int dev); > extern void sata_port (struct sata_ioports *ioport); > extern void set_Feature_cmd (int num, int dev); >-extern ulong sata_read (int device, lbaint_t blknr, >- ulong blkcnt, ulong * buffer); >-extern ulong sata_write (int device, lbaint_t blknr, >- ulong blkcnt, ulong * buffer); >+extern ulong sata_read (int device, ulong blknr, >+ lbaint_t blkcnt, void * buffer); >+extern ulong sata_write (int device, ulong blknr, >+ lbaint_t blkcnt, void * buffer); > extern void msleep (int count); > #endif > > > ------------------------------------------------------------------------ - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ U-Boot-Users mailing list U-Boot-Users at lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users ^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot-Users] U-boot-testing. 2007-06-16 6:24 ` mushtaq khan 2007-06-17 16:50 ` Leonid @ 2007-06-17 21:11 ` Wolfgang Denk 1 sibling, 0 replies; 4+ messages in thread From: Wolfgang Denk @ 2007-06-17 21:11 UTC (permalink / raw) To: u-boot In message <46738210.1080505@procsys.com> you wrote: > > I had submitted the sata patch with respect to u-boot-testing > repository.I didn't get any feedbac, what is the next step? Please let > me know. You got this wrong. THe patch was checked in, so now you are supposed to test the resulting code and provide feedback - like all others, too. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Anyone who doesn't believe in miracles is not a realist. - David Ben Gurion ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-06-17 21:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20070605101705.825E1353A97@atlas.denx.de>
2007-06-09 6:52 ` [U-Boot-Users] U-boot-testing mushtaq khan
2007-06-16 6:24 ` mushtaq khan
2007-06-17 16:50 ` Leonid
2007-06-17 21:11 ` Wolfgang Denk
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.