All of lore.kernel.org
 help / color / mirror / Atom feed
From: adrian15 <adrian15@raulete.net>
To: grub-devel@gnu.org
Subject: help, configfile, pager and
Date: Sun, 10 Jun 2007 21:08:29 +0200	[thread overview]
Message-ID: <466C4C2D.6030907@raulete.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 2694 bytes --]

Here is a patch for some of the problems that I found in my miscelanea
mails.

More to come. :)

adrian15



diff -urN grub2_2007_05_31_original/ChangeLog
grub2_2007_05_31_small_fixes/ChangeLog
--- grub2_2007_05_31_original/ChangeLog	2007-05-20 11:10:05.000000000 +0200
+++ grub2_2007_05_31_small_fixes/ChangeLog	2007-06-10 18:48:40.000000000
+0200
@@ -1,3 +1,10 @@
+2007-06-21  adrian15  <adrian15@raulete.net>
+	* kern/main.c: Pager variable is now set to 0 by default.
+	* commands/help.c: Help command help shows that with no pattern
+	all the commands are shown.
+	* commands/configfile.c: Configfile command help tells the user that
+	that it runs the config file with another context.
+
   2007-05-20  Robert Millan  <rmh@aybabtu.com>

   	* util/update-grub_lib.in: New file.
diff -urN grub2_2007_05_31_original/commands/configfile.c
grub2_2007_05_31_small_fixes/commands/configfile.c
--- grub2_2007_05_31_original/commands/configfile.c	2006-06-04
17:56:54.000000000 +0200
+++ grub2_2007_05_31_small_fixes/commands/configfile.c	2007-06-10
18:36:19.000000000 +0200
@@ -60,7 +60,7 @@
     (void) mod;                   /* To stop warning. */
     grub_register_command ("configfile", grub_cmd_configfile,
                           GRUB_COMMAND_FLAG_BOTH, "configfile FILE",
-                        "Load another config file.", 0);
+                        "Load another config file with a new context.", 0);
     grub_register_command ("source", grub_cmd_source,
                           GRUB_COMMAND_FLAG_BOTH, "source FILE",
                           "Load another config file without changing
context.",
diff -urN grub2_2007_05_31_original/commands/help.c
grub2_2007_05_31_small_fixes/commands/help.c
--- grub2_2007_05_31_original/commands/help.c	2005-11-13
16:47:08.000000000 +0100
+++ grub2_2007_05_31_small_fixes/commands/help.c	2007-06-10
18:20:03.000000000 +0200
@@ -98,7 +98,7 @@
   {
     (void)mod;			/* To stop warning. */
     grub_register_command ("help", grub_cmd_help, 
GRUB_COMMAND_FLAG_CMDLINE,
-			 "help [PATTERN ...]", "Show a help message.", 0);
+			 "help [PATTERN ...]", "Show a command help. No pattern shows all
available commands.", 0);
   }

   GRUB_MOD_FINI(help)
diff -urN grub2_2007_05_31_original/kern/main.c
grub2_2007_05_31_small_fixes/kern/main.c
--- grub2_2007_05_31_original/kern/main.c	2006-04-25 22:08:31.000000000
+0200
+++ grub2_2007_05_31_small_fixes/kern/main.c	2007-06-10
18:12:53.000000000 +0200
@@ -127,6 +127,9 @@
     grub_machine_set_prefix ();
     grub_set_root_dev ();

+  /* Set pager and other unimportant variables */
+  grub_env_set ("pager", "0");
+
     /* Load the normal mode module.  */
     grub_load_normal_mode ();




[-- Attachment #2: help_and_pager.patch --]
[-- Type: text/x-patch, Size: 2555 bytes --]

diff -urN grub2_2007_05_31_original/ChangeLog grub2_2007_05_31_small_fixes/ChangeLog
--- grub2_2007_05_31_original/ChangeLog	2007-05-20 11:10:05.000000000 +0200
+++ grub2_2007_05_31_small_fixes/ChangeLog	2007-06-10 18:48:40.000000000 +0200
@@ -1,3 +1,10 @@
+2007-06-21  adrian15  <adrian15@raulete.net>
+	* kern/main.c: Pager variable is now set to 0 by default.
+	* commands/help.c: Help command help shows that with no pattern
+	all the commands are shown.
+	* commands/configfile.c: Configfile command help tells the user that
+	that it runs the config file with another context.
+
 2007-05-20  Robert Millan  <rmh@aybabtu.com>
 
 	* util/update-grub_lib.in: New file.
diff -urN grub2_2007_05_31_original/commands/configfile.c grub2_2007_05_31_small_fixes/commands/configfile.c
--- grub2_2007_05_31_original/commands/configfile.c	2006-06-04 17:56:54.000000000 +0200
+++ grub2_2007_05_31_small_fixes/commands/configfile.c	2007-06-10 18:36:19.000000000 +0200
@@ -60,7 +60,7 @@
   (void) mod;                   /* To stop warning. */
   grub_register_command ("configfile", grub_cmd_configfile,
                         GRUB_COMMAND_FLAG_BOTH, "configfile FILE",
-                        "Load another config file.", 0);
+                        "Load another config file with a new context.", 0);
   grub_register_command ("source", grub_cmd_source,
                         GRUB_COMMAND_FLAG_BOTH, "source FILE",
                         "Load another config file without changing context.",
diff -urN grub2_2007_05_31_original/commands/help.c grub2_2007_05_31_small_fixes/commands/help.c
--- grub2_2007_05_31_original/commands/help.c	2005-11-13 16:47:08.000000000 +0100
+++ grub2_2007_05_31_small_fixes/commands/help.c	2007-06-10 18:20:03.000000000 +0200
@@ -98,7 +98,7 @@
 {
   (void)mod;			/* To stop warning. */
   grub_register_command ("help", grub_cmd_help, GRUB_COMMAND_FLAG_CMDLINE,
-			 "help [PATTERN ...]", "Show a help message.", 0);
+			 "help [PATTERN ...]", "Show a command help. No pattern shows all available commands.", 0);
 }
 
 GRUB_MOD_FINI(help)
diff -urN grub2_2007_05_31_original/kern/main.c grub2_2007_05_31_small_fixes/kern/main.c
--- grub2_2007_05_31_original/kern/main.c	2006-04-25 22:08:31.000000000 +0200
+++ grub2_2007_05_31_small_fixes/kern/main.c	2007-06-10 18:12:53.000000000 +0200
@@ -127,6 +127,9 @@
   grub_machine_set_prefix ();
   grub_set_root_dev ();
 
+  /* Set pager and other unimportant variables */
+  grub_env_set ("pager", "0");
+
   /* Load the normal mode module.  */
   grub_load_normal_mode ();
   


                 reply	other threads:[~2007-06-10 19:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=466C4C2D.6030907@raulete.net \
    --to=adrian15@raulete.net \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.