help, configfile, pager and

help, configfile, pager and

[adrian15]

[-- Attachment #1: Type: text/plain, Size: 2694 bytes --]

Here is a patch for some of the problems that I found in my miscelanea
mails.

More to come. :)

adrian15



diff -urN grub2_2007_05_31_original/ChangeLog
grub2_2007_05_31_small_fixes/ChangeLog
--- grub2_2007_05_31_original/ChangeLog	2007-05-20 11:10:05.000000000 +0200
+++ grub2_2007_05_31_small_fixes/ChangeLog	2007-06-10 18:48:40.000000000
+0200
@@ -1,3 +1,10 @@
+2007-06-21  adrian15  <adrian15@raulete.net>
+	* kern/main.c: Pager variable is now set to 0 by default.
+	* commands/help.c: Help command help shows that with no pattern
+	all the commands are shown.
+	* commands/configfile.c: Configfile command help tells the user that
+	that it runs the config file with another context.
+
   2007-05-20  Robert Millan  <rmh@aybabtu.com>

   	* util/update-grub_lib.in: New file.
diff -urN grub2_2007_05_31_original/commands/configfile.c
grub2_2007_05_31_small_fixes/commands/configfile.c
--- grub2_2007_05_31_original/commands/configfile.c	2006-06-04
17:56:54.000000000 +0200
+++ grub2_2007_05_31_small_fixes/commands/configfile.c	2007-06-10
18:36:19.000000000 +0200
@@ -60,7 +60,7 @@
     (void) mod;                   /* To stop warning. */
     grub_register_command ("configfile", grub_cmd_configfile,
                           GRUB_COMMAND_FLAG_BOTH, "configfile FILE",
-                        "Load another config file.", 0);
+                        "Load another config file with a new context.", 0);
     grub_register_command ("source", grub_cmd_source,
                           GRUB_COMMAND_FLAG_BOTH, "source FILE",
                           "Load another config file without changing
context.",
diff -urN grub2_2007_05_31_original/commands/help.c
grub2_2007_05_31_small_fixes/commands/help.c
--- grub2_2007_05_31_original/commands/help.c	2005-11-13
16:47:08.000000000 +0100
+++ grub2_2007_05_31_small_fixes/commands/help.c	2007-06-10
18:20:03.000000000 +0200
@@ -98,7 +98,7 @@
   {
     (void)mod;			/* To stop warning. */
     grub_register_command ("help", grub_cmd_help, 
GRUB_COMMAND_FLAG_CMDLINE,
-			 "help [PATTERN ...]", "Show a help message.", 0);
+			 "help [PATTERN ...]", "Show a command help. No pattern shows all
available commands.", 0);
   }

   GRUB_MOD_FINI(help)
diff -urN grub2_2007_05_31_original/kern/main.c
grub2_2007_05_31_small_fixes/kern/main.c
--- grub2_2007_05_31_original/kern/main.c	2006-04-25 22:08:31.000000000
+0200
+++ grub2_2007_05_31_small_fixes/kern/main.c	2007-06-10
18:12:53.000000000 +0200
@@ -127,6 +127,9 @@
     grub_machine_set_prefix ();
     grub_set_root_dev ();

+  /* Set pager and other unimportant variables */
+  grub_env_set ("pager", "0");
+
     /* Load the normal mode module.  */
     grub_load_normal_mode ();




[-- Attachment #2: help_and_pager.patch --]
[-- Type: text/x-patch, Size: 2555 bytes --]

diff -urN grub2_2007_05_31_original/ChangeLog grub2_2007_05_31_small_fixes/ChangeLog
--- grub2_2007_05_31_original/ChangeLog	2007-05-20 11:10:05.000000000 +0200
+++ grub2_2007_05_31_small_fixes/ChangeLog	2007-06-10 18:48:40.000000000 +0200
@@ -1,3 +1,10 @@
+2007-06-21  adrian15  <adrian15@raulete.net>
+	* kern/main.c: Pager variable is now set to 0 by default.
+	* commands/help.c: Help command help shows that with no pattern
+	all the commands are shown.
+	* commands/configfile.c: Configfile command help tells the user that
+	that it runs the config file with another context.
+
 2007-05-20  Robert Millan  <rmh@aybabtu.com>
 
 	* util/update-grub_lib.in: New file.
diff -urN grub2_2007_05_31_original/commands/configfile.c grub2_2007_05_31_small_fixes/commands/configfile.c
--- grub2_2007_05_31_original/commands/configfile.c	2006-06-04 17:56:54.000000000 +0200
+++ grub2_2007_05_31_small_fixes/commands/configfile.c	2007-06-10 18:36:19.000000000 +0200
@@ -60,7 +60,7 @@
   (void) mod;                   /* To stop warning. */
   grub_register_command ("configfile", grub_cmd_configfile,
                         GRUB_COMMAND_FLAG_BOTH, "configfile FILE",
-                        "Load another config file.", 0);
+                        "Load another config file with a new context.", 0);
   grub_register_command ("source", grub_cmd_source,
                         GRUB_COMMAND_FLAG_BOTH, "source FILE",
                         "Load another config file without changing context.",
diff -urN grub2_2007_05_31_original/commands/help.c grub2_2007_05_31_small_fixes/commands/help.c
--- grub2_2007_05_31_original/commands/help.c	2005-11-13 16:47:08.000000000 +0100
+++ grub2_2007_05_31_small_fixes/commands/help.c	2007-06-10 18:20:03.000000000 +0200
@@ -98,7 +98,7 @@
 {
   (void)mod;			/* To stop warning. */
   grub_register_command ("help", grub_cmd_help, GRUB_COMMAND_FLAG_CMDLINE,
-			 "help [PATTERN ...]", "Show a help message.", 0);
+			 "help [PATTERN ...]", "Show a command help. No pattern shows all available commands.", 0);
 }
 
 GRUB_MOD_FINI(help)
diff -urN grub2_2007_05_31_original/kern/main.c grub2_2007_05_31_small_fixes/kern/main.c
--- grub2_2007_05_31_original/kern/main.c	2006-04-25 22:08:31.000000000 +0200
+++ grub2_2007_05_31_small_fixes/kern/main.c	2007-06-10 18:12:53.000000000 +0200
@@ -127,6 +127,9 @@
   grub_machine_set_prefix ();
   grub_set_root_dev ();
 
+  /* Set pager and other unimportant variables */
+  grub_env_set ("pager", "0");
+
   /* Load the normal mode module.  */
   grub_load_normal_mode ();