PATCH: fix mismatch between usb-hid.c HUT find/search mapping and the HUT reference doc

PATCH: fix mismatch between usb-hid.c HUT find/search mapping and the HUT reference doc

[Hans de Goede]

[-- Attachment #1: Type: text/plain, Size: 952 bytes --]

Hi all,

As some of you might know from my earlier post/thread about atkbd and softraw, 
I'm currently working on getting keyboards with internet/easy access keys to 
work painlessly / plug and play.

In order to be able to better test / develop this I've bought 2 cheap such 
keyboards today, one ps2 and one both usb and ps2 capable.

When comparing usb vs ps2 / testing the keycodes generated for the easy access
keys on my trust (microsoft compatible) keyboard. I noticed the search key
generated the linux/input keycode for find when connected through USB. This 
lead me to check the consumer page mappings in hid-input.c . And it turns out 
the the mapping for ID 0x221 deviates from the HUT standard document:
http://www.usb.org/developers/devclass_docs/Hut1_12.pdf

Currently it is incorrectly mapped to find, whereas it should be mapped to
search. I also added missing bindings for ID 0x21f, the real find and for
0x222, goto.

Regards,

Hans

[-- Attachment #2: usb-hid-hut.patch --]
[-- Type: text/x-patch, Size: 1338 bytes --]

When comparing usb vs ps2 / testing the keycodes generated for the easy access
keys on my trust (microsoft compatible) keyboard. I noticed the search key
generated the keycode for find when connected through USB. This lead me to
check the consumer page mappings in hid-input.c . And it turns out the the
mapping for ID 0x221 deviates from the HUT standard document:
http://www.usb.org/developers/devclass_docs/Hut1_12.pdf

Currently it is incorrectly mapped to find, whereas it should be mapped to
search. I also added missing bindings for ID 0x21f, the real find and for
0x222, goto.

Signed-off-by: Hans de Goede <j.w.r.degoede@hhs.nl>
--- linux-2.6.21.x86_64/drivers/hid/hid-input.c.hut	2007-06-12 19:26:58.000000000 +0200
+++ linux-2.6.21.x86_64/drivers/hid/hid-input.c	2007-06-12 19:33:32.000000000 +0200
@@ -598,7 +598,9 @@
 				case 0x21b: map_key_clear(KEY_COPY);		break;
 				case 0x21c: map_key_clear(KEY_CUT);		break;
 				case 0x21d: map_key_clear(KEY_PASTE);		break;
-				case 0x221: map_key_clear(KEY_FIND);		break;
+				case 0x21f: map_key_clear(KEY_FIND);		break;
+				case 0x221: map_key_clear(KEY_SEARCH);		break;
+				case 0x222: map_key_clear(KEY_GOTO);		break;
 				case 0x223: map_key_clear(KEY_HOMEPAGE);	break;
 				case 0x224: map_key_clear(KEY_BACK);		break;
 				case 0x225: map_key_clear(KEY_FORWARD);		break;

Re: PATCH: fix mismatch between usb-hid.c HUT find/search mapping and the HUT reference doc

[Dmitry Torokhov]

On 6/12/07, Hans de Goede <j.w.r.degoede@hhs.nl> wrote:
> Hi all,
>
> As some of you might know from my earlier post/thread about atkbd and softraw,
> I'm currently working on getting keyboards with internet/easy access keys to
> work painlessly / plug and play.
>

BTW, Richard Hughes (CCed) is also trying to fix keyboard mappings (by
loading proper keymap into kernel with support of HAL).

-- 
Dmitry

Re: PATCH: fix mismatch between usb-hid.c HUT find/search mapping and the HUT reference doc

[Jiri Kosina]

On Tue, 12 Jun 2007, Hans de Goede wrote:

> Currently it is incorrectly mapped to find, whereas it should be mapped 
> to search. I also added missing bindings for ID 0x21f, the real find and 
> for 0x222, goto.

Hi Hans,

you are right. Will apply, thanks.

-- 
Jiri Kosina