All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: Follow packets in rules
Date: Thu, 14 Jun 2007 16:23:57 +0200	[thread overview]
Message-ID: <46714F7D.4010309@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0706141536530.8110@blackhole.kfki.hu>

Jozsef Kadlecsik wrote:
> Hi Patrick,
> 
> On Thu, 14 Jun 2007, Patrick McHardy wrote:
> 
>>> http://svn.netfilter.org/cgi-bin/viewcvs.cgi/old_stuff/netfilter/trunk/patch-o-matic/extra/TRACE.patch?rev=3069
>>>
>>
>>
>> Yeah, it doesn't look too bad. Unfortunately it breaks userspace
>> compatibility.
> 
> 
> Sigh.
> 
>> How about just adding a new match that prints a user-supplied string
>> for specially marked packets?
> 
> 
> That'd be hard to use in practice: imagine, you have hundred of rules in
> multiple, multilevel chains. You should have to modify all your rules
> and add meaningful, different log strings to every one of them if you'd
> need to check how given packets traverse the rules.
> 
> Also, it'd be about the same as writing a log match. But in longer term
> we'd better support multiple targets instead of a log match.


Indeed. I was thinking that iptables could automatically insert the
match into rules, so you wouldn't have to modify your ruleset.
But that could also be done with multiple targets.

> The "beauty" of the TRACE target is that there is no need to tweak the
> rules: just "mark" the packets (we don't use the standard mark, so we
> cannot clash with any rule) you are interested in to check how they
> traverse the rulesets and that's all. Simple and clean.
> 
> An earlier version of the patch did not suffer from backward
> incompatibility: when we hit a marked packet and a matched rule, it
> searched the chain name and computed the rule number internally. But it
> can slow down packet processing if there are many matching rules and
> large number of rules in the chains so I introduced stored rulenumbers.
> What about going back to that approach? Tracing packets should not be
> considered as normal (and thus performance efficient) mode.


Yes, that sounds reasonable. Performance doesn't matter much for this.

  reply	other threads:[~2007-06-14 14:23 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-12 18:08 Follow packets in rules Fabrice Rafart
2007-06-12 21:41 ` Simon
2007-06-13  7:31   ` Fabrice Rafart
2007-06-18 16:12     ` Simon
2007-06-18 16:14       ` Patrick McHardy
2007-06-13  8:57 ` Pablo Neira Ayuso
2007-06-13 15:43   ` Juan León
2007-06-13 16:28     ` Samuel Jean
2007-06-13 16:53       ` Patrick McHardy
2007-06-13 19:43         ` Jozsef Kadlecsik
2007-06-14  7:55           ` Fabrice Rafart
2007-06-14 13:13           ` Patrick McHardy
2007-06-14 14:18             ` Jozsef Kadlecsik
2007-06-14 14:23               ` Patrick McHardy [this message]
2007-06-18 10:16                 ` Jozsef Kadlecsik
2007-06-18 12:49                   ` Patrick McHardy
2007-06-18 13:05                     ` Jozsef Kadlecsik
2007-06-18 13:08                       ` Patrick McHardy
2007-06-22 14:20                   ` Patrick McHardy
2007-06-23 16:45                     ` Jozsef Kadlecsik
2007-06-24 14:48                       ` Patrick McHardy
2007-06-25 12:19                         ` Patrick McHardy
2007-06-25 12:49                           ` Jan Engelhardt
2007-06-25 12:52                             ` Patrick McHardy
2007-06-25 13:00                             ` Patrick McHardy
2007-06-25 13:52                               ` Jan Engelhardt
2007-06-25 13:55                                 ` Patrick McHardy
2007-07-03 15:07 ` Fabrice Rafart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46714F7D.4010309@trash.net \
    --to=kaber@trash.net \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.