Re: Follow packets in rules

[Patrick McHardy <kaber@trash.net>]

Jozsef Kadlecsik wrote:
> On Mon, 18 Jun 2007, Patrick McHardy wrote:
> 
>> Jozsef Kadlecsik wrote:
>>
>>> Attached you can find the reworked TRACE target, which does not suffer
>>> from backward incompatibility. Unfortunately I had to steal one unused
>>> bit from skbuff to be able to mark the packets so that it surely does
>>> not clash with any rules using the standard "MARK" target. Logging
>>> level, flags and type are hardcoded. What do you think?
>>
>>
>> Looks pretty good. Maybe we can avoid using the skb bit though, what
>> do you think about letting the user set a special "trace-mark" value
>> through /proc and using that? Not sure if thats better or worse :)
> 
> 
> If one uses 'MARK --set-mark' and would want to trace a living ruleset,
> he'd be forced to change the ruleset in order to be able to use tracing.
> And that's a full can of worms...


Good point.

> Hey, we returned the all 32 bit of nfcache! This is just one bit getting
> back ;-)


Fair enough I guess :) The bit is unused anyway, so at least for now it
won't do any harm. I'll do some more thoroughly review in the next days
and queue it for 2.6.23 if no other issues come up.