[PATCH] Output MFG information for HDA devices

[PATCH] Output MFG information for HDA devices

[Jonathan Phénix]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

Hi,

this patch output information about the MFG (Modem Function Group) to 
the /proc/asound/card?/codec#? file. This information is important to 
identify if a HDA device has a modem or not.

Regards,

Jonathan Phénix
Technical specialist / Linuxant
www.linuxant.com
jonathan@linuxant.com



[-- Attachment #2: alsa-hg-mfg.patch --]
[-- Type: text/x-patch, Size: 838 bytes --]

searching for changes
changeset:   5106:c63e54409236
tag:         tip
user:        root@silver
date:        Thu Jun 14 13:48:53 2007 -0400
summary:     Added MFG in HDA /proc output

diff -r 96495fe7cc13 -r c63e54409236 pci/hda/hda_proc.c
--- a/pci/hda/hda_proc.c	Thu Jun 14 12:58:23 2007 +0200
+++ b/pci/hda/hda_proc.c	Thu Jun 14 13:48:53 2007 -0400
@@ -250,6 +250,12 @@ static void print_codec_info(struct snd_
 	snd_iprintf(buffer, "Vendor Id: 0x%x\n", codec->vendor_id);
 	snd_iprintf(buffer, "Subsystem Id: 0x%x\n", codec->subsystem_id);
 	snd_iprintf(buffer, "Revision Id: 0x%x\n", codec->revision_id);
+
+	if (codec->mfg)
+		snd_iprintf(buffer, "Modem Function Group: 0x%x\n", codec->mfg);
+	else
+		snd_iprintf(buffer, "No Modem Function Group found\n");
+
 	if (! codec->afg)
 		return;
 	snd_iprintf(buffer, "Default PCM:\n");


[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] Output MFG information for HDA devices

[Takashi Iwai]

At Thu, 14 Jun 2007 16:35:53 -0400,
Jonathan Phénix wrote:
> 
> Hi,
> 
> this patch output information about the MFG (Modem Function Group) to 
> the /proc/asound/card?/codec#? file. This information is important to 
> identify if a HDA device has a modem or not.

The patch looks good.  Could you give your sign-off?


thanks,

Takashi

Re: [PATCH] Output MFG information for HDA devices

[Jonathan Phénix]

Takashi Iwai wrote:
> At Thu, 14 Jun 2007 16:35:53 -0400,
> Jonathan Phénix wrote:
>> Hi,
>>
>> this patch output information about the MFG (Modem Function Group) to 
>> the /proc/asound/card?/codec#? file. This information is important to 
>> identify if a HDA device has a modem or not.
> 
> The patch looks good.  Could you give your sign-off?

Signed-off-by: Jonathan Phénix <jonathan@linuxant.com>

You can change "é" to "e" in my name if you prefer for technical reasons.

> thanks,
> 
> Takashi

Regards,


Jonathan Phénix
Technical specialist / Linuxant
www.linuxant.com
jonathan@linuxant.com

Re: [PATCH] Output MFG information for HDA devices

[Takashi Iwai]

At Tue, 19 Jun 2007 11:59:06 -0400,
Jonathan Phénix wrote:
> 
> Takashi Iwai wrote:
> > At Thu, 14 Jun 2007 16:35:53 -0400,
> > Jonathan Phénix wrote:
> >> Hi,
> >>
> >> this patch output information about the MFG (Modem Function Group) to 
> >> the /proc/asound/card?/codec#? file. This information is important to 
> >> identify if a HDA device has a modem or not.
> > 
> > The patch looks good.  Could you give your sign-off?
> 
> Signed-off-by: Jonathan Phénix <jonathan@linuxant.com>
> 
> You can change "é" to "e" in my name if you prefer for technical reasons.

Thanks, applied to HG tree now.


Takashi