All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
	Vivek Goyal <vgoyal@in.ibm.com>,
	Rusty Russell <rusty@rustcorp.com.au>, Andi Kleen <ak@suse.de>,
	v12n <virtualization@lists.linux-foundation.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Xen-Devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 04/10] i386: clean up bzImage generation
Date: Fri, 15 Jun 2007 09:34:10 -0700	[thread overview]
Message-ID: <4672BF82.9050101@goop.org> (raw)
In-Reply-To: <4672BC3E.6080308@zytor.com>

H. Peter Anvin wrote:
> Jeremy Fitzhardinge wrote:
>   
>> -setup_move_size: .word  0x8000		# size to move, when setup is not
>> +setup_move_size: .word  _setup_size	# size to move, when setup is not
>>  					# loaded at 0x90000. We will move setup
>>  					# to 0x90000 then just before jumping
>>  					# into the kernel. However, only the
>>     
>
> This is WRONG and will break 2.00 protocol bootloaders, if any still
> exist, and quite possibly some 2.01 protocol bootloaders.  There are
> definitiely bootloaders in the field that rely on this implicit value.
>   

Ah, I see.  I didn't see any documentation saying that this must be
0x8000.  Or does _setup_size just have to be <= 0x8000?

>> @@ -246,7 +246,6 @@ setup2:
>>  	jnz	1f
>>  	movw	$0xfffc, %sp	# Make sure we're not zero
>>  1:	movzwl	%sp, %esp	# Clear upper half of %esp
>> -	sti
>>     
>
> Motivation, please?
>   

We talked about this, and you said it was a mistake.  It needn't be in
this patch; it could be separate, or just dropped as far as I'm concerned.

    J

WARNING: multiple messages have this Message-ID (diff)
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Xen-Devel <xen-devel@lists.xensource.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	lkml <linux-kernel@vger.kernel.org>,
	v12n <virtualization@lists.linux-foundation.org>,
	Vivek Goyal <vgoyal@in.ibm.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andi Kleen <ak@suse.de>
Subject: Re: [PATCH 04/10] i386: clean up bzImage generation
Date: Fri, 15 Jun 2007 09:34:10 -0700	[thread overview]
Message-ID: <4672BF82.9050101@goop.org> (raw)
In-Reply-To: <4672BC3E.6080308@zytor.com>

H. Peter Anvin wrote:
> Jeremy Fitzhardinge wrote:
>   
>> -setup_move_size: .word  0x8000		# size to move, when setup is not
>> +setup_move_size: .word  _setup_size	# size to move, when setup is not
>>  					# loaded at 0x90000. We will move setup
>>  					# to 0x90000 then just before jumping
>>  					# into the kernel. However, only the
>>     
>
> This is WRONG and will break 2.00 protocol bootloaders, if any still
> exist, and quite possibly some 2.01 protocol bootloaders.  There are
> definitiely bootloaders in the field that rely on this implicit value.
>   

Ah, I see.  I didn't see any documentation saying that this must be
0x8000.  Or does _setup_size just have to be <= 0x8000?

>> @@ -246,7 +246,6 @@ setup2:
>>  	jnz	1f
>>  	movw	$0xfffc, %sp	# Make sure we're not zero
>>  1:	movzwl	%sp, %esp	# Clear upper half of %esp
>> -	sti
>>     
>
> Motivation, please?
>   

We talked about this, and you said it was a mistake.  It needn't be in
this patch; it could be separate, or just dropped as far as I'm concerned.

    J

  parent reply	other threads:[~2007-06-15 16:34 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-15  0:48 [PATCH 00/10] paravirt/subarchitecture boot protocol Jeremy Fitzhardinge
2007-06-15  0:48 ` Jeremy Fitzhardinge
2007-06-15  0:48 ` [PATCH 01/10] update boot spec to 2.07 Jeremy Fitzhardinge
2007-06-15  0:48   ` Jeremy Fitzhardinge
2007-06-15  0:48 ` Jeremy Fitzhardinge
2007-06-15  0:48 ` [PATCH 02/10] allow linux/elf.h to be included in assembler Jeremy Fitzhardinge
2007-06-15  0:48 ` Jeremy Fitzhardinge
2007-06-15  0:48   ` Jeremy Fitzhardinge
2007-06-15  0:48 ` [PATCH 03/10] define ELF notes for adding to a boot image Jeremy Fitzhardinge
2007-06-15  0:48   ` Jeremy Fitzhardinge
2007-06-15 16:20   ` H. Peter Anvin
2007-06-15 16:20   ` H. Peter Anvin
2007-06-15 16:40     ` Jeremy Fitzhardinge
2007-06-15 16:40       ` Jeremy Fitzhardinge
2007-06-26 20:18       ` Andrew Morton
2007-06-26 20:18         ` Andrew Morton
2007-06-26 20:21         ` Jeremy Fitzhardinge
2007-06-26 20:21         ` Jeremy Fitzhardinge
2007-06-15 16:40     ` Jeremy Fitzhardinge
2007-06-15  0:48 ` Jeremy Fitzhardinge
2007-06-15  0:48 ` [PATCH 04/10] i386: clean up bzImage generation Jeremy Fitzhardinge
2007-06-15 16:20   ` H. Peter Anvin
2007-06-15 16:20   ` H. Peter Anvin
2007-06-15 16:34     ` Jeremy Fitzhardinge
2007-06-15 16:34     ` Jeremy Fitzhardinge [this message]
2007-06-15 16:34       ` Jeremy Fitzhardinge
2007-06-15 16:51       ` H. Peter Anvin
2007-06-15 17:03         ` Jeremy Fitzhardinge
2007-06-15 17:03           ` Jeremy Fitzhardinge
2007-06-15 17:03         ` Jeremy Fitzhardinge
2007-06-15 16:51       ` H. Peter Anvin
2007-06-15  0:48 ` Jeremy Fitzhardinge
2007-06-15  0:48 ` [PATCH 05/10] i386: make the bzImage payload an ELF file Jeremy Fitzhardinge
2007-06-15  0:48 ` Jeremy Fitzhardinge
2007-06-15  0:48 ` [PATCH 06/10] add WEAK() for creating weak asm labels Jeremy Fitzhardinge
2007-06-15  0:48 ` Jeremy Fitzhardinge
2007-06-15  0:48 ` [PATCH 07/10] always allocate space for notes Jeremy Fitzhardinge
2007-06-15  0:48 ` Jeremy Fitzhardinge
2007-06-15  0:48   ` Jeremy Fitzhardinge
2007-06-15  0:48 ` [PATCH 08/10] i386: paravirt boot sequence Jeremy Fitzhardinge
2007-06-15  0:48 ` Jeremy Fitzhardinge
2007-06-15  0:48 ` [PATCH 09/10] ask the hypervisor how much space it needs reserved Jeremy Fitzhardinge
2007-06-15  0:48   ` Jeremy Fitzhardinge
2007-06-15  0:48 ` Jeremy Fitzhardinge
2007-06-15  0:48 ` [PATCH 10/10] xen: use boot protocol to boot xen kernel Jeremy Fitzhardinge
2007-06-15  0:48 ` Jeremy Fitzhardinge
2007-06-15 16:12   ` Satya
2007-06-15 16:41     ` Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4672BF82.9050101@goop.org \
    --to=jeremy@goop.org \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=vgoyal@in.ibm.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.