[2.6 patch] fix devres_release_all() return value

[2.6 patch] fix devres_release_all() return value

[Adrian Bunk]

Every file should include the headers containing the prototypes for
it's global functions.

Since the GNU C compiler is now able to detect that the function 
prototype of devres_release_all() in the header and the actual function 
disagree regarding the return value, this patch also fixes this bug.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/base/base.h   |    2 +-
 drivers/base/devres.c |    2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

--- linux-2.6.22-rc4-mm2/drivers/base/base.h.old	2007-06-17 15:37:21.000000000 +0200
+++ linux-2.6.22-rc4-mm2/drivers/base/base.h	2007-06-17 15:37:34.000000000 +0200
@@ -44,6 +44,6 @@
 
 extern char *make_class_name(const char *name, struct kobject *kobj);
 
-extern void devres_release_all(struct device *dev);
+extern int devres_release_all(struct device *dev);
 
 extern struct kset devices_subsys;
--- linux-2.6.22-rc4-mm2/drivers/base/devres.c.old	2007-06-17 15:30:48.000000000 +0200
+++ linux-2.6.22-rc4-mm2/drivers/base/devres.c	2007-06-17 15:31:03.000000000 +0200
@@ -10,6 +10,8 @@
 #include <linux/device.h>
 #include <linux/module.h>
 
+#include "base.h"
+
 struct devres_node {
 	struct list_head		entry;
 	dr_release_t			release;

Re: [2.6 patch] fix devres_release_all() return value

[Tejun Heo]

Adrian Bunk wrote:
> Every file should include the headers containing the prototypes for
> it's global functions.
> 
> Since the GNU C compiler is now able to detect that the function 
> prototype of devres_release_all() in the header and the actual function 
> disagree regarding the return value, this patch also fixes this bug.
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

Acked-by: Tejun Heo <htejun@gmail.com>

This should go through Greg.

  http://article.gmane.org/gmane.linux.kernel/544290/raw

-- 
tejun

Re: [2.6 patch] fix devres_release_all() return value

[Greg KH]

On Mon, Jun 18, 2007 at 02:55:30PM +0900, Tejun Heo wrote:
> Adrian Bunk wrote:
> > Every file should include the headers containing the prototypes for
> > it's global functions.
> > 
> > Since the GNU C compiler is now able to detect that the function 
> > prototype of devres_release_all() in the header and the actual function 
> > disagree regarding the return value, this patch also fixes this bug.
> > 
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> Acked-by: Tejun Heo <htejun@gmail.com>
> 
> This should go through Greg.
> 
>   http://article.gmane.org/gmane.linux.kernel/544290/raw

Thanks, I've picked it up now.

greg k-h