Re: Please help to review the Yocto 1656: Recipe creation/import script

[Paul Eggleton <paul.eggleton@linux.intel.com>]

Hi Kai,

On Thursday 19 January 2012 17:33:47 Kang Kai wrote:
> The attachment is the the design document V2 and implement.
> 
> The V2 document changes are:
> 1 remove patch_set from argument list
> 2 deb is not support right now
> 
> Any comment is welcome.
> And I will on vacation until Jan 30, so my reply may not in time.

Great work! I can see this being really useful to help people get started with 
new recipes. A few comments:

1) I tried it on hdparm and it worked very well. However, obexftp caused an 
error:

----------------
Downloading package:  
http://downloads.sourceforge.net/openobex/obexftp-0.23.tar.bz2  to  
/tmp/bitbake_createbb.5729
Traceback (most recent call last):
  File "./bitbake-createbb", line 643, in <module>
    process_configure(pkgdir)
  File "./bitbake-createbb", line 295, in process_configure
    if match and len(pkgname) == 0:
UnboundLocalError: local variable 'pkgname' referenced before assignment
----------------

2) If it is able to find license file(s) but unable to find any appropriate for 
LIC_FILES_CHKSUM, it would be nice if it would print a warning just so the 
user knows they will need to set this themselves (bonus points if you still 
list LIC_FILES_CHKSUM entries for license files that did not match the known 
checksums either in a comment in the output or in the warning message, to save 
the user work if they know the files are appropriate). If you prefer I can send 
a patch afterwards for this.

3) If you have an RPM spec file it is possible to extract PACKAGES and FILES 
and possibly even EXTRA_OECONF. Somewhere around here I have a very basic 
script to do this I think, I could send it to you if you like (or we can leave 
this for later).

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre