From: Joshua Lock <josh@linux.intel.com>
To: Kang Kai <Kai.Kang@windriver.com>
Cc: "poky@yoctoproject.org" <poky@yoctoproject.org>
Subject: Re: Please help to review the Yocto 1656: Recipe creation/import script
Date: Thu, 19 Jan 2012 17:57:41 -0800 [thread overview]
Message-ID: <4F18CA15.1060007@linux.intel.com> (raw)
In-Reply-To: <4F17E37B.7030506@windriver.com>
On 19/01/12 01:33, Kang Kai wrote:
> Hi Josh,
>
> The attachment is the the design document V2 and implement.
>
> The V2 document changes are:
> 1 remove patch_set from argument list
> 2 deb is not support right now
>
> Any comment is welcome.
> And I will on vacation until Jan 30, so my reply may not in time.
This looks like a good start, Paul has offered some great feedback. In
addition I'd add that we need a license header on the script, we should
probably attribute autospectacle in the header too (Inspired by? Based on?).
I haven't had chance to do a thorough code review but will try and do so
whilst you're on your break.
Cheers,
Joshua
--
Joshua Lock
Yocto Project "Johannes factotum"
Intel Open Source Technology Centre
prev parent reply other threads:[~2012-01-20 1:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4F17C7D9.10506@windriver.com>
2012-01-19 9:33 ` Please help to review the Yocto 1656: Recipe creation/import script Kang Kai
2012-01-19 11:57 ` Paul Eggleton
2012-01-19 16:33 ` Mark Hatle
2012-01-30 2:21 ` Kang Kai
2012-01-20 1:57 ` Joshua Lock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F18CA15.1060007@linux.intel.com \
--to=josh@linux.intel.com \
--cc=Kai.Kang@windriver.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.