ulogd large file support

ulogd large file support

[Andreas Lundin]

Hi,

ulogd seems to be missing large file support. Here is a simple patch
to make configure handle it, but there is a line that is commented in
Rules.make.in which will prevent the option to be used during compile
time (search for @DEFS@ in Rules.make.in).

I compiled ulogd-1.24 with -D_FILE_OFFSET_BITS=64 and it can now write
to log files larger than 2G on my system.

Regards
Andreas Lundin

This patch is for ulogd-1.24 but the patch is so trivial that it is
probably easier to apply with an editor :-)

--- configure.in 2005-11-25 20:58:27.000000000 +0100
+++ configure.in 2007-06-19 15:09:22.000000000 +0200
@@ -20,6 +20,7 @@
 AC_C_CONST
 AC_TYPE_SIZE_T
 AC_STRUCT_TM
+AC_SYS_LARGEFILE

 dnl Checks for library functions.
 AC_FUNC_VPRINTF

Re: ulogd large file support

[Patrick McHardy]

Andreas Lundin wrote:
> ulogd seems to be missing large file support. Here is a simple patch
> to make configure handle it, but there is a line that is commented in
> Rules.make.in which will prevent the option to be used during compile
> time (search for @DEFS@ in Rules.make.in).
> 
> I compiled ulogd-1.24 with -D_FILE_OFFSET_BITS=64 and it can now write
> to log files larger than 2G on my system.


Applied, thanks. I've ran into this a couple of days ago with ulogd2,
so I've applied your patch there as well.

Re: ulogd large file support

[Pablo Neira Ayuso]

Patrick McHardy wrote:
> Andreas Lundin wrote:
>> ulogd seems to be missing large file support. Here is a simple patch
>> to make configure handle it, but there is a line that is commented in
>> Rules.make.in which will prevent the option to be used during compile
>> time (search for @DEFS@ in Rules.make.in).
>>
>> I compiled ulogd-1.24 with -D_FILE_OFFSET_BITS=64 and it can now write
>> to log files larger than 2G on my system.
> 
> Applied, thanks. I've ran into this a couple of days ago with ulogd2,
> so I've applied your patch there as well.

JFYI: I just applied another patch on top of it to check for autoconf >=
2.50 (required by AC_SYS_LARGEFILE), removed autogenerated
libipulog/Makefile from SVN and uncomment the @DEFS@ line in
Rules.make.in to pass -D_FILE_OFFSET_BITS=64 at compilation stage.

I'm still working with Marius Tomaschewski on several pending patches.
We'll release a new version once we've finish with them.

-- 
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris

Re: ulogd large file support

[Patrick McHardy]

Pablo Neira Ayuso wrote:
> Patrick McHardy wrote:
> 
>>Andreas Lundin wrote:
>>
>>>ulogd seems to be missing large file support. Here is a simple patch
>>>to make configure handle it, but there is a line that is commented in
>>>Rules.make.in which will prevent the option to be used during compile
>>>time (search for @DEFS@ in Rules.make.in).
>>>
>>>I compiled ulogd-1.24 with -D_FILE_OFFSET_BITS=64 and it can now write
>>>to log files larger than 2G on my system.
>>
>>Applied, thanks. I've ran into this a couple of days ago with ulogd2,
>>so I've applied your patch there as well.
> 
> 
> JFYI: I just applied another patch on top of it to check for autoconf >=
> 2.50 (required by AC_SYS_LARGEFILE), removed autogenerated
> libipulog/Makefile from SVN and uncomment the @DEFS@ line in
> Rules.make.in to pass -D_FILE_OFFSET_BITS=64 at compilation stage.


I noticed that, thanks. autocrap remains a huge mystery for me.

> I'm still working with Marius Tomaschewski on several pending patches.
> We'll release a new version once we've finish with them.

Great, thanks.