From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Netfilter Developer Mailing List
<netfilter-devel@lists.netfilter.org>,
kaber@trash.net
Subject: Re: xt_u32 kernel 20070620
Date: Wed, 20 Jun 2007 11:56:51 +0200 [thread overview]
Message-ID: <4678F9E3.7050002@netfilter.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0706200037570.5731@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> + base = head = skb_header_pointer(skb, 0, skb->len, u32_buffer);
Since we calculate the offset and just take chunks of 32 bits. Why not
use skb_copy_bits instead and copy 4 bytes to a small buffer allocated
in the stack? This would remove the big buffer requirement.
--
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris
next prev parent reply other threads:[~2007-06-20 9:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-19 22:39 xt_u32 kernel 20070620 Jan Engelhardt
2007-06-19 22:39 ` xt_u32 iptables 20070620 Jan Engelhardt
2007-06-20 9:56 ` Pablo Neira Ayuso [this message]
2007-06-20 10:43 ` xt_u32 kernel 20070620_2 Jan Engelhardt
2007-06-20 11:05 ` Pablo Neira Ayuso
2007-06-20 10:58 ` Jan Engelhardt
2007-06-20 12:25 ` Patrick McHardy
2007-06-20 12:36 ` Jan Engelhardt
2007-06-21 11:47 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4678F9E3.7050002@netfilter.org \
--to=pablo@netfilter.org \
--cc=jengelh@computergmbh.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.