Re: xt_u32 kernel 20070620_2

[Pablo Neira Ayuso <pablo@netfilter.org>]

Jan Engelhardt wrote:
> On Jun 20 2007 11:56, Pablo Neira Ayuso wrote:
>> Jan Engelhardt wrote:
>>> +	base = head = skb_header_pointer(skb, 0, skb->len, u32_buffer);
>> Since we calculate the offset and just take chunks of 32 bits. Why not use
>> skb_copy_bits instead and copy 4 bytes to a small buffer allocated in the
>> stack? This would remove the big buffer requirement.
> 
> Much more than that, it would actually make xt_u32 truly SMP-"capable" (you
> name it), because now there is no buffer that would need to be locked.
> 
> Patch below.

Wrong patch? :-)

-- 
The dawn of the fourth age of Linux firewalling is coming; a time of 
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris