Re: [patch 3/4] MMC-over-SPI core updates

[Pierre Ossman <drzeus-mmc-p3sGCRWkH8CeZLLa646FqQ@public.gmane.org>]

David Brownell wrote:
> 
> I can't see it that way.  It's just a different way of managing
> that status than you currently expect.
> 

You seem to be stuck in the idea that we want some voodoo translation layer
between native MMC and the SPI version. That is not desirable for a multitude of
reasons, so make sure the core knows SPI and the host driver is just a hardware
interface (like the other host drivers).

> 
> So, get rid of all R1_APP_CMD checks in the MMC stack?
> That's what I'll do for now.
> 
> I count two of them, and they are both superfluous since
> they follow successful completion of MMC_APP_CMD.  The
> only way that can succeed is if the card supports APP_CMD
> and enters that mode...
> 

The specs that was coded against suggested it was prudent to check the bit. It's
not like it's a measurable performance hit to do it.

> (The alternative would be to do the superfluous checks
> only for non-SPI hosts, but that'd seem pointless.)

I don't agree. Preferably we would always check it, but we can't with SPI so
we'll have to cross our fingers there.

Rgds
-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/