All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Karel Zak <kzak@redhat.com>
Cc: Al Viro <viro@ftp.linux.org.uk>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-fsdevel@vger.kernel.org, util-linux-ng@vger.kernel.org
Subject: Re: Adding subroot information to /proc/mounts, or obtaining that through other means
Date: Wed, 20 Jun 2007 15:39:57 -0700	[thread overview]
Message-ID: <4679ACBD.4090200@zytor.com> (raw)
In-Reply-To: <20070620222437.GY7226@petra.dvoda.cz>

Karel Zak wrote:
> 
>  Yeah. How about include propagation trees to this file?
> 
>  mountpoint + ID + relative path + type + options + propagation-flag +
>  {peer,master}-mount-id
> 
>  / 0xa917800 / ext3 rw PRIVATE
>  /mnt 0xa917100 / ext3 rw SHARED peer:0xa917100
>  /tmp 0xa917f00 /1 ext3 rw SLAVE master:0xa917100
> 

I think we're talking about a different meaning of "id" here... you seem
to be talking about the vfsmount pointer, whereas it was originally
proposed as mnt_sb->sb_dev.  Both are useful, for different reasons of
course.

We should include mnt_devname as well.

People are a bit nervous about exposing kernel pointers in userspace, I
have noticed; would it be better to add a "mnt_id" field to struct
vfsmount; this can simply be a counter assigned when the structure is
assigned and then never changed (it might have to be a 64-bit counter,
but I don't think that adding 8 bytes to struct vfsmount should be a
huge deal.)

Does that service everyone's needs?

	-hpa

WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
To: Karel Zak <kzak-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Al Viro <viro-rfM+Q5joDG/XmaaqVzeoHQ@public.gmane.org>,
	Linux Kernel Mailing List
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	util-linux-ng-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: Adding subroot information to /proc/mounts, or obtaining that through other means
Date: Wed, 20 Jun 2007 15:39:57 -0700	[thread overview]
Message-ID: <4679ACBD.4090200@zytor.com> (raw)
In-Reply-To: <20070620222437.GY7226-CxBs/XhZ2BtHjqfyn1fVYA@public.gmane.org>

Karel Zak wrote:
> 
>  Yeah. How about include propagation trees to this file?
> 
>  mountpoint + ID + relative path + type + options + propagation-flag +
>  {peer,master}-mount-id
> 
>  / 0xa917800 / ext3 rw PRIVATE
>  /mnt 0xa917100 / ext3 rw SHARED peer:0xa917100
>  /tmp 0xa917f00 /1 ext3 rw SLAVE master:0xa917100
> 

I think we're talking about a different meaning of "id" here... you seem
to be talking about the vfsmount pointer, whereas it was originally
proposed as mnt_sb->sb_dev.  Both are useful, for different reasons of
course.

We should include mnt_devname as well.

People are a bit nervous about exposing kernel pointers in userspace, I
have noticed; would it be better to add a "mnt_id" field to struct
vfsmount; this can simply be a counter assigned when the structure is
assigned and then never changed (it might have to be a 64-bit counter,
but I don't think that adding 8 bytes to struct vfsmount should be a
huge deal.)

Does that service everyone's needs?

	-hpa

  reply	other threads:[~2007-06-20 22:44 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-20 20:57 Adding subroot information to /proc/mounts, or obtaining that through other means H. Peter Anvin
2007-06-20 20:57 ` H. Peter Anvin
2007-06-20 21:03 ` Al Viro
2007-06-20 21:20   ` H. Peter Anvin
2007-06-21 16:20     ` Ram Pai
2007-06-21 16:20       ` Ram Pai
2007-06-21 16:29       ` H. Peter Anvin
2007-06-21 16:29         ` H. Peter Anvin
2007-06-21 17:20         ` Ram Pai
2007-06-21 17:20           ` Ram Pai
2007-06-21 17:31       ` H. Peter Anvin
2007-06-21 17:31         ` H. Peter Anvin
2007-06-21 17:43         ` H. Peter Anvin
2007-06-21 17:43           ` H. Peter Anvin
2007-06-22  6:44         ` Ram Pai
2007-06-22  7:06           ` H. Peter Anvin
2007-06-22  7:06             ` H. Peter Anvin
2007-06-22  7:34             ` Ram Pai
2007-06-22  7:51               ` H. Peter Anvin
     [not found]                 ` <20070625214640.GC29058@ram.us.ibm.com>
2007-06-25 22:00                   ` [RFC PATCH 1/1] VFS: Augment /proc/mount with subroot and shared-subtree Ram Pai
2007-06-26  8:01                     ` Karel Zak
2007-06-26  8:01                       ` Karel Zak
2007-06-26 14:34                       ` H. Peter Anvin
2007-06-30  9:44                     ` Christoph Hellwig
2007-06-30 12:56                       ` H. Peter Anvin
2007-07-11 10:24                         ` Christoph Hellwig
2007-07-11 10:24                           ` Christoph Hellwig
2007-07-11 15:42                           ` Ram Pai
2007-07-16 18:46                   ` [RFC2 " Ram Pai
2007-07-16 18:46                     ` Ram Pai
2007-06-20 22:24   ` Adding subroot information to /proc/mounts, or obtaining that through other means Karel Zak
2007-06-20 22:24     ` Karel Zak
2007-06-20 22:39     ` H. Peter Anvin [this message]
2007-06-20 22:39       ` H. Peter Anvin
2007-06-20 22:33   ` Chuck Lever
2007-06-20 22:41     ` H. Peter Anvin
2007-06-20 22:41       ` H. Peter Anvin
2007-06-20 22:48       ` Chuck Lever
2007-06-20 22:48         ` Chuck Lever
2007-06-20 22:57         ` H. Peter Anvin
2007-06-20 23:02           ` Chuck Lever
2007-06-20 23:02             ` Chuck Lever
2007-06-21 16:13   ` H. Peter Anvin
2007-06-21 16:13     ` H. Peter Anvin
2007-06-21 16:49     ` Serge E. Hallyn
2007-06-21 16:51       ` H. Peter Anvin
2007-06-21 16:51         ` H. Peter Anvin
2007-06-28 14:53   ` Pavel Machek
2007-06-28 15:36     ` H. Peter Anvin
2007-06-28 15:36       ` H. Peter Anvin
2007-06-20 22:05 ` Karel Zak
2007-06-20 22:05   ` Karel Zak
2007-06-20 22:07   ` H. Peter Anvin
2007-06-20 22:41   ` Dr. David Alan Gilbert
2007-06-20 22:41     ` Dr. David Alan Gilbert
2007-06-20 22:46     ` H. Peter Anvin
2007-06-20 22:46       ` H. Peter Anvin
2007-06-21 19:14       ` Hans-Peter Jansen
2007-06-21 19:14         ` Hans-Peter Jansen
2007-06-21 19:19         ` H. Peter Anvin
2007-06-21 19:19           ` H. Peter Anvin
2007-06-20 22:55 ` Nix
2007-06-21 10:45   ` Miklos Szeredi
2007-06-21 19:42     ` Nix
2007-06-21 19:42       ` Nix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4679ACBD.4090200@zytor.com \
    --to=hpa@zytor.com \
    --cc=kzak@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=util-linux-ng@vger.kernel.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.