Re: [XenPPC] One more fix for the forward port

Re: [XenPPC] One more fix for the forward port

[Christian Ehrhardt]

[-- Attachment #1: Type: text/plain, Size: 2847 bytes --]

Hollis Blanchard wrote:
> On Tue, 2007-06-19 at 13:49 +0200, Christian Ehrhardt wrote:
>   
>> The DomU now boots without visible issues, but at least on my system
>> networking in DomU does not yet work - the DomU tihnk its working, but
>> I can't get a connection from/to Dom0.
>> @Hollis - currently you are the only one except me who has an
>> up-to-date forward port patch queue - could you please verify if this
>> is only an issue of my local setup by applying all my latest patches
>> and see what works in your environment. 
>>     
>
> Networking seems to be OK here. I'm using a very stripped down disk
> image for domU (actually I'm using
> http://xm-test.xensource.com/ramdisks/initrd-1.1-powerpc.img), so I
> haven't tested it heavily, but I can manually assign an unused IP
> address and ping both into and out of the domU. My domain profile
> contains "vif = [ '' ]", and so xend automatically creates a vif and
> bridges it to the physical network.
>
> I'm attaching the full MQ patch series to this mail. To use it, clone
> http://xenbits.xensource.com/linux-2.6.18-xen.hg , extract the tarball
> inside that directory (it creates .hg/patches), and hg qpush -a. If
> you're not already an MQ user, see
> http://www.selenic.com/mercurial/wiki/index.cgi/MqExtension or just
> patch by hand.
>
> I haven't figured out how to effectively share this queue, but since I
> think it's pretty much done at this point, we'll be able to commit and
> send upstream soon (but I will be traveling until July, so not too
> soon).
>
>   
I was currently applying the latest patch queue to a current 
xen-unstable+make prep-kernels (which hg clones 
http://xenbits.xensource.com/linux-2.6.18-xen.hg).
I saw that the patch autotranslate-mmap.diff does not apply. The patch 
removes a not needed autotranslate check. But in the code coming 
currently from http://xenbits.xensource.com/linux-2.6.18-xen.hg is a 
"idndef __powerpw__" around there which a) would do the job and b) lets 
the patch not match.
Your patchnote says that this does not apply to other architectures and 
I support every approach to reduce ifdefs ;-)
Because of that I updated the autotranslate-mmap.diff and attached it 
here for you inclusion in our patchqueue for 2.6.18.
Additionally this mentioning to that sub-patch gives everyone the chance 
to comment the "does not affect other architectures" statement - 
therefor I add xen-devel here too.

-- 

Grüsse / regards, 
Christian Ehrhardt

IBM Linux Technology Center, Open Virtualization
+49 7031/16-3385
Ehrhardt@linux.vnet.ibm.com
Ehrhardt@de.ibm.com

IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Johann Weihen 
Geschäftsführung: Herbert Kircher 
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294


[-- Attachment #2: autotranslate-mmap.diff --]
[-- Type: text/x-patch, Size: 981 bytes --]

[XEN][LINUX] Remove autotranslate check from privcmd_mmap().
PowerPC dom0 is autotranslated and needs to be able to map domU memory.
x86 doesn't use privileged autotranslated domains, and IA64 has their own
privcmd_mmap(), so this doesn't affect them.
Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>

diff -r 50220a1b2aaf drivers/xen/privcmd/privcmd.c
--- a/drivers/xen/privcmd/privcmd.c	Thu Jun 21 07:49:49 2007 +0200
+++ b/drivers/xen/privcmd/privcmd.c	Thu Jun 21 07:52:35 2007 +0200
@@ -229,12 +229,6 @@ static struct vm_operations_struct privc
 
 static int privcmd_mmap(struct file * file, struct vm_area_struct * vma)
 {
-#ifndef __powerpc__ /* PowerPC has a trick to safely do this. */
-	/* Unsupported for auto-translate guests. */
-	if (xen_feature(XENFEAT_auto_translated_physmap))
-		return -ENOSYS;
-#endif
-
 	/* DONTCOPY is essential for Xen as copy_page_range is broken. */
 	vma->vm_flags |= VM_RESERVED | VM_IO | VM_DONTCOPY;
 	vma->vm_ops = &privcmd_vm_ops;

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel