All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Xen Development Mailing List <xen-devel@lists.xensource.com>
Subject: [patch] crashkernel allocation failure #1
Date: Fri, 22 Jun 2007 11:39:02 +0200	[thread overview]
Message-ID: <467B98B6.7060601@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

   Hi,

The kexec crash kernel area allocation code does some effort to move the 
images (i.e. kernel+initrd) out of the way, so the crashkernel area can 
be allocated at the default location (@16m).

In case initial_images_end is not page aligned a single page in the 
middle of the crash kernel area is leaked though, making the whole move 
effort fail.

The attached patch fixed that by rounding up initial_images_end to the 
next page boundary.

please apply,
   Gerd

[-- Attachment #2: xen-crashkernel.patch --]
[-- Type: text/x-patch, Size: 499 bytes --]

--- xen/arch/x86/setup.c.fix	2007-05-03 09:40:19.000000000 +0200
+++ xen/arch/x86/setup.c	2007-06-19 11:19:11.000000000 +0200
@@ -453,6 +453,7 @@
     if ( initial_images_start < xenheap_phys_end )
         initial_images_start = xenheap_phys_end;
     initial_images_end = initial_images_start + modules_length;
+    initial_images_end = (initial_images_end + PAGE_SIZE - 1) & PAGE_MASK;
 
     move_memory(initial_images_start, 
                 mod[0].mod_start, mod[mbi->mods_count-1].mod_end);

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

                 reply	other threads:[~2007-06-22  9:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=467B98B6.7060601@redhat.com \
    --to=kraxel@redhat.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.