All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Green <andy@warmcat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Jiri Benc <jbenc@suse.cz>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [WIP] mac80211: kill mgmt interface
Date: Sun, 24 Jun 2007 09:39:28 +0100	[thread overview]
Message-ID: <467E2DC0.30804@warmcat.com> (raw)
In-Reply-To: <1182635467.21939.125.camel@johannes.berg>

Johannes Berg wrote:

>> but actually I quite liked your encapsulation
>> thing -- in itself is compatible with working in any mode.  The only
>> problem with it right now is that it seems when mananged mode interfaces
>>  are not associated, they are in a netif_carrier_off() state or similar.
> 
> Oh, good point, I forgot about that in my other reply. Yeah, we really
> want to go to IFF_DORMANT too and that really stops us from doing
> anything. Also, if we do QoS on the interfaces then the qdisc might end
> up dropping our packets if we don't do special hacks around that, again
> something we cannot accept.

That definitely is a bit of a problem for using Managed mode wlan0 for
injection, since it shuts off packets outside of mac80211 when
unassociated.  The "solution" if one was wanted would be to stop using
the interface-level mechanism and let everything through and filter in
hard_start_xmit() so only injected packets were accepted.

This is only the case on managed mode interfaces though, a feature of
the encapsulated method was that it removed the dependence on
specifically Monitor Mode to determine that an incoming TX packet had
the radiotap format -- aside from Managed it still works fine on Monitor
Mode interfaces (and presumably the other modes) with or without an
associated interface on the device.  To be clear it works exactly the
same on Monitor Mode as Try #13 just requiring a 14-byte ethhdr at the
start of the injected packet.

Anyway I don't want to argue myself out of an ACK ;-)  I think what I'll
do is post a try #14 using encapsulation that works on wlan0 too but
needs it associated, but on the understanding that try #13 is not
deprecated if people prefer it.

-Andy

  reply	other threads:[~2007-06-24  8:40 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-21  9:42 [WIP] mac80211: kill mgmt interface Johannes Berg
2007-06-21 12:35 ` Jiri Benc
2007-06-21 12:45   ` Johannes Berg
2007-06-21 13:14     ` Jiri Benc
2007-06-21 23:27       ` Andy Green
2007-06-22 13:45       ` Jiri Benc
2007-06-22 14:29         ` Andy Green
2007-06-22 15:30           ` Johannes Berg
2007-06-22 15:49             ` Jiri Benc
2007-06-22 20:20               ` Johannes Berg
2007-06-23  5:58                 ` Andy Green
2007-06-23  6:53                   ` Johannes Berg
2007-06-23  9:00                     ` Andy Green
2007-06-23 21:48                       ` Johannes Berg
2007-06-24  8:51                         ` Andy Green
2007-06-24  9:38                           ` Johannes Berg
2007-06-23 11:44                     ` Jiri Benc
2007-06-23 12:23                       ` Andy Green
2007-06-23 21:51                         ` Johannes Berg
2007-06-24  8:39                           ` Andy Green [this message]
2007-06-24 10:46                             ` Jiri Benc
2007-06-22 15:39           ` Jiri Benc
2007-06-22 17:00             ` Andy Green
2007-06-23  8:29               ` Andy Green
2007-06-23 21:41                 ` Johannes Berg
2007-06-21 13:35 ` Jouni Malinen
2007-06-22  5:05   ` Michael Wu
2007-06-22 10:12     ` Johannes Berg
2007-06-23  7:08   ` Johannes Berg
  -- strict thread matches above, loose matches on Subject: below --
2007-06-21 21:50 Joerg Pommnitz
2007-06-22  9:10 ` Johannes Berg
2007-06-22 13:15 ` Jiri Benc
2007-07-01  1:48   ` Cohen, Guy
2007-07-02 13:38 AW: " Joerg Pommnitz
2007-07-02 13:53 ` Jiri Benc
2007-07-04  6:13   ` Tomas Winkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=467E2DC0.30804@warmcat.com \
    --to=andy@warmcat.com \
    --cc=jbenc@suse.cz \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.