All of lore.kernel.org
 help / color / mirror / Atom feed
From: Corey Hickey <bugfood-ml@fatooh.org>
To: Patrick McHardy <kaber@trash.net>
Cc: lartc <lartc@mailman.ds9a.nl>,
	Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [LARTC] ESFQ: request for user input
Date: Sun, 24 Jun 2007 23:09:42 +0000	[thread overview]
Message-ID: <467EF9B6.3040801@fatooh.org> (raw)
In-Reply-To: <467EDE48.307@trash.net>

Patrick McHardy wrote:
> Corey Hickey wrote:
>> Hello,
>>
>> I haven't been keeping up with sending ESFQ [ANNOUNCE] messages to this
>> list, but I've still been working on the patch. If you're curious about
>> recent changes, take a look at the home page, ChangeLog, and README:
>>
>> http://fatooh.org/esfq-2.6/
>> http://fatooh.org/esfq-2.6/current/ChangeLog
>> http://fatooh.org/esfq-2.6/current/README
>>
>> Meanwhile, I'm interested in finally getting ESFQ included in the Linux
>> kernel. Before I start sending patches and requesting maintainer review,
>> however, there's one question I want to ask current or potential users
>> of SFQ and ESFQ:
>>
>> Should ESFQ be merged into SFQ or remain as a separate qdisc?
> 
> I've CCed netdev. I think merging parts of ESFQ (dynamic depth and
> flow number) would make a lot of sense, but I'm intending to submit
> an alternative to the ESFQ hashing scheme for 2.6.23:
> 
> http://www.mail-archive.com/netdev@vger.kernel.org/msg39156.html

Nice. I wasn't aware of that. Your patch looks like it supersedes ESFQ's
hashing, so, if it gets applied, that already removes a large chunk of
the differences between SFQ and ESFQ.

If I don't hear any opposition, then I'll keep an eye out for when your
patch gets accepted (assuming it does) and then submit patch(es) porting
the rest of ESFQ's features to SFQ.

I just subscribed myself to netdev.

> I have enough trust in ESFQ's stability that I don't think we need
> a new qdisc for this and could merge it in SFQ (and the "uses only
> 1 page" justification isn't true anymore anyway), but I also
> wouldn't mind adding a new qdisc.

Thanks for the trust; I'm sure that the patches will have to undergo
some cleanup either way, considering my newbieness to kernel development.

-Corey
_______________________________________________
LARTC mailing list
LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/cgi-bin/mailman/listinfo/lartc

WARNING: multiple messages have this Message-ID (diff)
From: Corey Hickey <bugfood-ml@fatooh.org>
To: Patrick McHardy <kaber@trash.net>
Cc: lartc <lartc@mailman.ds9a.nl>,
	Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: ESFQ: request for user input
Date: Sun, 24 Jun 2007 16:09:42 -0700	[thread overview]
Message-ID: <467EF9B6.3040801@fatooh.org> (raw)
In-Reply-To: <467EDE48.307@trash.net>

Patrick McHardy wrote:
> Corey Hickey wrote:
>> Hello,
>>
>> I haven't been keeping up with sending ESFQ [ANNOUNCE] messages to this
>> list, but I've still been working on the patch. If you're curious about
>> recent changes, take a look at the home page, ChangeLog, and README:
>>
>> http://fatooh.org/esfq-2.6/
>> http://fatooh.org/esfq-2.6/current/ChangeLog
>> http://fatooh.org/esfq-2.6/current/README
>>
>> Meanwhile, I'm interested in finally getting ESFQ included in the Linux
>> kernel. Before I start sending patches and requesting maintainer review,
>> however, there's one question I want to ask current or potential users
>> of SFQ and ESFQ:
>>
>> Should ESFQ be merged into SFQ or remain as a separate qdisc?
> 
> I've CCed netdev. I think merging parts of ESFQ (dynamic depth and
> flow number) would make a lot of sense, but I'm intending to submit
> an alternative to the ESFQ hashing scheme for 2.6.23:
> 
> http://www.mail-archive.com/netdev@vger.kernel.org/msg39156.html

Nice. I wasn't aware of that. Your patch looks like it supersedes ESFQ's
hashing, so, if it gets applied, that already removes a large chunk of
the differences between SFQ and ESFQ.

If I don't hear any opposition, then I'll keep an eye out for when your
patch gets accepted (assuming it does) and then submit patch(es) porting
the rest of ESFQ's features to SFQ.

I just subscribed myself to netdev.

> I have enough trust in ESFQ's stability that I don't think we need
> a new qdisc for this and could merge it in SFQ (and the "uses only
> 1 page" justification isn't true anymore anyway), but I also
> wouldn't mind adding a new qdisc.

Thanks for the trust; I'm sure that the patches will have to undergo
some cleanup either way, considering my newbieness to kernel development.

-Corey

  reply	other threads:[~2007-06-24 23:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-24 19:50 [LARTC] ESFQ: request for user input Corey Hickey
2007-06-24 20:30 ` Andy Furniss
2007-06-24 21:12 ` Patrick McHardy
2007-06-24 21:12   ` Patrick McHardy
2007-06-24 23:09   ` Corey Hickey [this message]
2007-06-24 23:09     ` Corey Hickey
2007-06-24 23:40     ` [LARTC] " Patrick McHardy
2007-06-24 23:40       ` Patrick McHardy
2007-06-24 23:45       ` Corey Hickey
2007-06-24 23:45         ` Corey Hickey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=467EF9B6.3040801@fatooh.org \
    --to=bugfood-ml@fatooh.org \
    --cc=kaber@trash.net \
    --cc=lartc@mailman.ds9a.nl \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.