Re: [PATCH 03/10] nf_conntrack: Use extension infrastructure for helper

[Patrick McHardy <kaber@trash.net>]

Yasuyuki KOZAKAI wrote:
> --- a/include/net/netfilter/nf_conntrack_extend.h
> +++ b/include/net/netfilter/nf_conntrack_extend.h
> @@ -5,9 +5,12 @@
>  
>  enum nf_ct_ext_id
>  {
> +	NF_CT_EXT_HELPER,
>  	NF_CT_EXT_MAX,
>  } __attribute__((packed));


Don't use attribute packed please, just use an u8 if you want to
make sure it doesn't need more space than that.

Minor nitpick: it would be more logical if max would be the
highest value, not highest value + 1. The array should then
be declared with size max + 1. But thats just my preference,
half the code out there seems to use max + 1 as maximum, so
keep it if you like.