From: Patrick McHardy <kaber@trash.net>
To: Yasuyuki KOZAKAI <yasuyuki.kozakai@toshiba.co.jp>
Cc: rusty@rustcorp.com.au, netfilter-devel@lists.netfilter.org,
pablo@netfilter.org, kadlec@blackhole.kfki.hu
Subject: Re: [PATCH 03/10] nf_conntrack: Use extension infrastructure for helper
Date: Mon, 25 Jun 2007 17:47:03 +0200 [thread overview]
Message-ID: <467FE377.1090301@trash.net> (raw)
In-Reply-To: <200706251544.l5PFix3l028630@toshiba.co.jp>
Yasuyuki KOZAKAI wrote:
> From: Patrick McHardy <kaber@trash.net>
> Date: Mon, 25 Jun 2007 12:06:18 +0200
>
>
>>Minor nitpick: it would be more logical if max would be the
>>highest value, not highest value + 1. The array should then
>>be declared with size max + 1. But thats just my preference,
>>half the code out there seems to use max + 1 as maximum, so
>>keep it if you like.
>
>
> Thanks for notice. These are legacies of the original patch.
> I've removed the attribute and replaced NF_CT_EXT_MAX with NF_CT_EXT_NUM.
Thats better, thanks.
> I have experience that I forgot '+ 1' where I declared array and
> I prefer to declare the highest value + 1 to avoid that.
Yes, its a common mistake (possibly rooted in the max confusion :))
next prev parent reply other threads:[~2007-06-25 15:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-25 3:14 [PATCH 03/10] nf_conntrack: Use extension infrastructure for helper Yasuyuki KOZAKAI
2007-06-25 10:06 ` Patrick McHardy
2007-06-25 15:44 ` Yasuyuki KOZAKAI
[not found] ` <200706251544.l5PFix3l028630@toshiba.co.jp>
2007-06-25 15:47 ` Patrick McHardy [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-06-25 17:21 Yasuyuki KOZAKAI
[not found] <200706251721.l5PHLegZ002188@toshiba.co.jp>
2007-06-25 18:18 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=467FE377.1090301@trash.net \
--to=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@lists.netfilter.org \
--cc=pablo@netfilter.org \
--cc=rusty@rustcorp.com.au \
--cc=yasuyuki.kozakai@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.