From: Bryn M. Reeves <breeves@redhat.com>
To: lvm-devel@redhat.com
Subject: fix lvmdiskscan volume reporting when using lvm shell
Date: Mon, 25 Jun 2007 13:45:13 +0100 [thread overview]
Message-ID: <467FB8D9.5090004@redhat.com> (raw)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Currently lvmdiskscan uses four global counters to track the number of
disks, partitions & PVs located. These are statically initialised to
zero but are never reset between runs.
This is fine for the standalone command but causes mis-reporting when
the tool is repeatedly run in the lvm shell:
# lvm
lvm> lvmdiskscan
/dev/ramdisk [ 16.00 MB]
/dev/loop0 [ 500.00 MB] LVM physical volume
[...]
7 disks
14 partitions
0 LVM physical volume whole disks
1 LVM physical volume
lvm> lvmdiskscan
/dev/ramdisk [ 16.00 MB]
/dev/loop0 [ 500.00 MB] LVM physical volume
[...]
14 disks
28 partitions
0 LVM physical volume whole disks
2 LVM physical volumes
etc.
Patch just moves the initialisation into the lvmdiskscan function.
Regards,
Bryn.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iD8DBQFGf7jZ6YSQoMYUY94RAjUEAJ9LMqyi8bZdRqNrynK6CefPnIau2ACfVv4I
km8ZqH2XpwTPdxhWhSx37og=
=ce90
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lvmdiskscan.patch
Type: text/x-patch
Size: 910 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20070625/964e7574/attachment.bin>
reply other threads:[~2007-06-25 12:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=467FB8D9.5090004@redhat.com \
--to=breeves@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.