All of lore.kernel.org
 help / color / mirror / Atom feed
* fix lvmdiskscan volume reporting when using lvm shell
@ 2007-06-25 12:45 Bryn M. Reeves
  0 siblings, 0 replies; only message in thread
From: Bryn M. Reeves @ 2007-06-25 12:45 UTC (permalink / raw)
  To: lvm-devel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Currently lvmdiskscan uses four global counters to track the number of
disks, partitions & PVs located. These are statically initialised to
zero but are never reset between runs.

This is fine for the standalone command but causes mis-reporting when
the tool is repeatedly run in the lvm shell:

# lvm
lvm> lvmdiskscan
  /dev/ramdisk               [       16.00 MB]
  /dev/loop0                 [      500.00 MB] LVM physical volume
[...]
  7 disks
  14 partitions
  0 LVM physical volume whole disks
  1 LVM physical volume
lvm> lvmdiskscan
  /dev/ramdisk               [       16.00 MB]
  /dev/loop0                 [      500.00 MB] LVM physical volume
[...]
  14 disks
  28 partitions
  0 LVM physical volume whole disks
  2 LVM physical volumes

etc.

Patch just moves the initialisation into the lvmdiskscan function.

Regards,
Bryn.
	
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFGf7jZ6YSQoMYUY94RAjUEAJ9LMqyi8bZdRqNrynK6CefPnIau2ACfVv4I
km8ZqH2XpwTPdxhWhSx37og=
=ce90
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lvmdiskscan.patch
Type: text/x-patch
Size: 910 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20070625/964e7574/attachment.bin>

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-06-25 12:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-25 12:45 fix lvmdiskscan volume reporting when using lvm shell Bryn M. Reeves

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.