All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Lively <dlively@virtualiron.com>
To: xen-devel@lists.xensource.com
Subject: ignoring xenbus state transitions during shutdown
Date: Mon, 25 Jun 2007 14:41:30 -0400	[thread overview]
Message-ID: <46800C5A.2050201@virtualiron.com> (raw)

Hi Folks -
  In otherend_changed() in xenbus_probe.c, the driver is trying to 
ignore xenbus state transitions while the guest OS is shutting down.  It 
currently does this by looking for system_state > SYSTEM_RUNNING.  But 
system_state is not exported by some kernels that use it (e.g., SLES9 
running in a HVM guest), so the xenbus driver can't be loaded. 
  The comments indicate we're trying to avoid a failure that occurs when 
there is no rootfs.  I haven't yet seen this failure (after removing the 
code my shutdowns with PV drivers seemed to work fine, though I haven't 
pushed hard yet), but I suspect I shouldn't be ignoring it.  I was 
thinking it might be better to test for the screw condition (no rootfs) 
directly, perhaps something like try vfs_stat("/", &stat) and see 
whether it fails (??).  (These state transitions are relatively rare, so 
it doesn't need to be a particularly cheap test.)
  Any other suggestions?  I've heard of the old global 'system_running', 
but that's not used SLES9, at least.

Thanks in Advance,
Dave

             reply	other threads:[~2007-06-25 18:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-25 18:41 David Lively [this message]
2007-06-25 18:47 ` ignoring xenbus state transitions during shutdown Keir Fraser
2007-06-25 20:28   ` David Lively
2007-06-25 20:39     ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46800C5A.2050201@virtualiron.com \
    --to=dlively@virtualiron.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.