[U-Boot-Users] environment settings question

[U-Boot-Users] environment settings question

[sapirf fersht]

For a ixp425 cpu how should the environment value
#define CFG_ENV_IS_IN_FLASH be set?

#define CFG_ENV_IS_IN_FLASH

OR

#define CFG_ENV_IS_IN_FLASH 1

?

[U-Boot-Users] environment settings question

[Timur Tabi]

sapirf fersht wrote:
> For a ixp425 cpu how should the environment value
> #define CFG_ENV_IS_IN_FLASH be set?
> 
> #define CFG_ENV_IS_IN_FLASH
> 
> OR
> 
> #define CFG_ENV_IS_IN_FLASH 1

The code that uses these macros should support both methods, but personally I prefer that 
the macros themselves be defined using the first method.  IMHO, you should define a macro 
to contain a value only if that value has some inherent significance.  For example, does 
"1" really mean something that "2" doesn't?  In this case, no.

-- 
Timur Tabi
Linux Kernel Developer @ Freescale



From "abiyani at unix dot telasic dot com" at unix.telasic.com  Tue Jun 26 02:30:36 2007
From: "abiyani at unix dot telasic dot com" at unix.telasic.com (Arun Biyani)
Date: Mon, 25 Jun 2007 17:30:36 -0700
Subject: [U-Boot-Users] U-Boot 1.2 - Cannot run hello_world
In-Reply-To: <200706192208.PAA23857@unix.telasic.com>
References: <mailman.29221.1182256330.29999.u-boot-users@lists.sourceforge.net>	<4677E737.2070507@alum.mit.edu>
	<200706192208.PAA23857@unix.telasic.com>
Message-ID: <200706260030.RAA15449@unix.telasic.com>

Arun Biyani wrote:
> When I add CFG_CMD_ELF to the configuration, I get the error below. 
> Maybe the CFG_CMD_ELF needs
> to be coupled with some other configuration option. Please help.
>
> My current definition is -
>
> #define CONFIG_COMMANDS     (                              \
>                            CONFIG_CMD_DFL       |     \
>                CFG_CMD_ELF          |    \
>                CFG_CMD_MII          |    \
>                CFG_CMD_JFFS2        |     \
>                CFG_CMD_NET          |     \
>                CFG_CMD_DHCP         |     \
>                CFG_CMD_PING             \
>                )
>
> The error I get is - (dcache_status & dcache_disable missing):
>
> /home/local/bin/../lib/gcc/m68k-uclinux/4.1.1/m5307/msep-data -lgcc \
>                         -Map u-boot.map -o u-boot
> common/libcommon.a(cmd_elf.o): In function `do_bootelf':
> /home/abiyani/wrk/u-boot-1.2.0/common/cmd_elf.c:62: undefined reference 
> to `dcache_status'
> /home/abiyani/wrk/u-boot-1.2.0/common/cmd_elf.c:63: undefined reference 
> to `dcache_disable'
> make: *** [u-boot] Error 1
> [u-boot-1.2.0$:1046]
>   
I get this error above if I add elf file support to u-boot for Coldfire 
processor. Looks like cmd_elf.c
expects dcache_disable and dcache_status functions. Which library 
provides these symbol values?

[U-Boot-Users] environment settings question

[nicky geerts]

grep -r CFG_ENV_IS_IN_FLASH * | grep if

it does show that CFG_ENV_IS_IN_FLASH is checked to be '1' in some
custom board flash drivers

your safest bet would be the second option, although I agree with
Timur Tabi that it isn't really logical.

2007/6/26, Timur Tabi <timur@freescale.com>:
> sapirf fersht wrote:
> > For a ixp425 cpu how should the environment value
> > #define CFG_ENV_IS_IN_FLASH be set?
> >
> > #define CFG_ENV_IS_IN_FLASH
> >
> > OR
> >
> > #define CFG_ENV_IS_IN_FLASH 1
>
> The code that uses these macros should support both methods, but personally I prefer that
> the macros themselves be defined using the first method.  IMHO, you should define a macro
> to contain a value only if that value has some inherent significance.  For example, does
> "1" really mean something that "2" doesn't?  In this case, no.
>
> --
> Timur Tabi
> Linux Kernel Developer @ Freescale
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
>

[U-Boot-Users] environment settings question

[nicky geerts]

those boards are probably using custom flash drivers in
/board/<name>/flash.[ch], or are derived from boards that do.  Setting
the define to '1' is needed in cases where you use those custom flash
drivers, and it's not wrong in case you don't use those custom flash
driver.

as far as i know, protecting will only prevent you writing to the
flash, reading should not be affected

you also need to indicate where this redundant storage is located
(also see the README file for more information on what these defines
do):

for example
#define CFG_ENV_IS_IN_FLASH	1
#define CFG_ENV_ADDR		0xXXXXXXXX
#define CFG_ENV_SECT_SIZE	0xXXXXXXXX
#define CFG_ENV_ADDR_REDUND	0xXXXXXXXX
#define CFG_ENV_SIZE_REDUND	0xXXXXXXXX

Nicky Geerts

2007/6/26, sapirf fersht <sapirf@gmail.com>:
> see below my reply:
>
> On 6/26/07, nicky geerts <nicky.geerts.news@gmail.com> wrote:
> > grep -r CFG_ENV_IS_IN_FLASH * | grep if
> >
> > it does show that CFG_ENV_IS_IN_FLASH is checked to be '1' in some
> > custom board flash drivers
>
> in 90% of the boards it appears with 1.  The rest which it didn't
> appear i thought it's just a mistake which didn't make any problems
> with compilation.
>
> The problem is that it still reads from default after reset instead
> from from flash.
>
> Can it be that the flash environment sector is protected, and i need
> to unprotect, copy and put the protect on again?
>
>
> >
> > your safest bet would be the second option, although I agree with
> > Timur Tabi that it isn't really logical.
> >
> > 2007/6/26, Timur Tabi <timur@freescale.com>:
> > > sapirf fersht wrote:
> > > > For a ixp425 cpu how should the environment value
> > > > #define CFG_ENV_IS_IN_FLASH be set?
> > > >
> > > > #define CFG_ENV_IS_IN_FLASH
> > > >
> > > > OR
> > > >
> > > > #define CFG_ENV_IS_IN_FLASH 1
> > >
> > > The code that uses these macros should support both methods, but personally I prefer that
> > > the macros themselves be defined using the first method.  IMHO, you should define a macro
> > > to contain a value only if that value has some inherent significance.  For example, does
> > > "1" really mean something that "2" doesn't?  In this case, no.
> > >
> > > --
> > > Timur Tabi
> > > Linux Kernel Developer @ Freescale
> > >
> > > -------------------------------------------------------------------------
> > > This SF.net email is sponsored by DB2 Express
> > > Download DB2 Express C - the FREE version of DB2 express and take
> > > control of your XML. No limits. Just data. Click to get it now.
> > > http://sourceforge.net/powerbar/db2/
> > > _______________________________________________
> > > U-Boot-Users mailing list
> > > U-Boot-Users at lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/u-boot-users
> > >
> >
>

[U-Boot-Users] environment settings question

[nicky geerts]

I guess you'll be fine using the first three defines, I just use the
redundant sector for backup.

in the command line interface, when you change environment settings
with "setenv", don't forget to save them with "saveenv", compile with
code with "#define DEBUG" in your config header file to enable the
output of all debug messages.

Nicky

2007/6/26, sapirf fersht <sapirf@gmail.com>:
> > you also need to indicate where this redundant storage is located
> > (also see the README file for more information on what these defines
> > do):
> >
> > for example
> > #define CFG_ENV_IS_IN_FLASH     1
> > #define CFG_ENV_ADDR            0xXXXXXXXX
> > #define CFG_ENV_SECT_SIZE       0xXXXXXXXX
>
>
> > #define CFG_ENV_ADDR_REDUND     0xXXXXXXXX
> > #define CFG_ENV_SIZE_REDUND     0xXXXXXXXX
>
> I just read the README about these parameters.
> These settings describe a second storage area used to hold
>            a redundand copy of the environment data, so that there is
>            a valid backup copy in case there is a power failure during
>            a "saveenv" operation.
>
> My board is based on ixdp425. I don't have these values. Is it wrong?
>
> >
> > Nicky Geerts
> >
> > 2007/6/26, sapirf fersht <sapirf@gmail.com>:
> > > see below my reply:
> > >
> > > On 6/26/07, nicky geerts <nicky.geerts.news@gmail.com> wrote:
> > > > grep -r CFG_ENV_IS_IN_FLASH * | grep if
> > > >
> > > > it does show that CFG_ENV_IS_IN_FLASH is checked to be '1' in some
> > > > custom board flash drivers
> > >
> > > in 90% of the boards it appears with 1.  The rest which it didn't
> > > appear i thought it's just a mistake which didn't make any problems
> > > with compilation.
> > >
> > > The problem is that it still reads from default after reset instead
> > > from from flash.
> > >
> > > Can it be that the flash environment sector is protected, and i need
> > > to unprotect, copy and put the protect on again?
> > >
> > >
> > > >
> > > > your safest bet would be the second option, although I agree with
> > > > Timur Tabi that it isn't really logical.
> > > >
> > > > 2007/6/26, Timur Tabi <timur@freescale.com>:
> > > > > sapirf fersht wrote:
> > > > > > For a ixp425 cpu how should the environment value
> > > > > > #define CFG_ENV_IS_IN_FLASH be set?
> > > > > >
> > > > > > #define CFG_ENV_IS_IN_FLASH
> > > > > >
> > > > > > OR
> > > > > >
> > > > > > #define CFG_ENV_IS_IN_FLASH 1
> > > > >
> > > > > The code that uses these macros should support both methods, but personally I prefer that
> > > > > the macros themselves be defined using the first method.  IMHO, you should define a macro
> > > > > to contain a value only if that value has some inherent significance.  For example, does
> > > > > "1" really mean something that "2" doesn't?  In this case, no.
> > > > >
> > > > > --
> > > > > Timur Tabi
> > > > > Linux Kernel Developer @ Freescale
> > > > >
> > > > > -------------------------------------------------------------------------
> > > > > This SF.net email is sponsored by DB2 Express
> > > > > Download DB2 Express C - the FREE version of DB2 express and take
> > > > > control of your XML. No limits. Just data. Click to get it now.
> > > > > http://sourceforge.net/powerbar/db2/
> > > > > _______________________________________________
> > > > > U-Boot-Users mailing list
> > > > > U-Boot-Users at lists.sourceforge.net
> > > > > https://lists.sourceforge.net/lists/listinfo/u-boot-users
> > > > >
> > > >
> > >
> >
>

[U-Boot-Users] environment settings question

[nicky geerts]

debug will also show all accesses to the flash (like unprotect, erase,
write, protect), so if the saveenv command doesn't work, it'll show up
in the traces

Nicky

2007/6/26, sapirf fersht <sapirf@gmail.com>:
> That's a good tip. Thanks a lot. I mainly used printf in places where
> i suspected. The problem is that where i suspected things will go
> wrong, it turned out that it was ok.
>
> On 6/26/07, nicky geerts <nicky.geerts.news@gmail.com> wrote:
> > I guess you'll be fine using the first three defines, I just use the
> > redundant sector for backup.
> >
> > in the command line interface, when you change environment settings
> > with "setenv", don't forget to save them with "saveenv", compile with
> > code with "#define DEBUG" in your config header file to enable the
> > output of all debug messages.
> >
> > Nicky
> >
> > 2007/6/26, sapirf fersht <sapirf@gmail.com>:
> > > > you also need to indicate where this redundant storage is located
> > > > (also see the README file for more information on what these defines
> > > > do):
> > > >
> > > > for example
> > > > #define CFG_ENV_IS_IN_FLASH     1
> > > > #define CFG_ENV_ADDR            0xXXXXXXXX
> > > > #define CFG_ENV_SECT_SIZE       0xXXXXXXXX
> > >
> > >
> > > > #define CFG_ENV_ADDR_REDUND     0xXXXXXXXX
> > > > #define CFG_ENV_SIZE_REDUND     0xXXXXXXXX
> > >
> > > I just read the README about these parameters.
> > > These settings describe a second storage area used to hold
> > >            a redundand copy of the environment data, so that there is
> > >            a valid backup copy in case there is a power failure during
> > >            a "saveenv" operation.
> > >
> > > My board is based on ixdp425. I don't have these values. Is it wrong?
> > >
> > > >
> > > > Nicky Geerts
> > > >
> > > > 2007/6/26, sapirf fersht <sapirf@gmail.com>:
> > > > > see below my reply:
> > > > >
> > > > > On 6/26/07, nicky geerts <nicky.geerts.news@gmail.com> wrote:
> > > > > > grep -r CFG_ENV_IS_IN_FLASH * | grep if
> > > > > >
> > > > > > it does show that CFG_ENV_IS_IN_FLASH is checked to be '1' in some
> > > > > > custom board flash drivers
> > > > >
> > > > > in 90% of the boards it appears with 1.  The rest which it didn't
> > > > > appear i thought it's just a mistake which didn't make any problems
> > > > > with compilation.
> > > > >
> > > > > The problem is that it still reads from default after reset instead
> > > > > from from flash.
> > > > >
> > > > > Can it be that the flash environment sector is protected, and i need
> > > > > to unprotect, copy and put the protect on again?
> > > > >
> > > > >
> > > > > >
> > > > > > your safest bet would be the second option, although I agree with
> > > > > > Timur Tabi that it isn't really logical.
> > > > > >
> > > > > > 2007/6/26, Timur Tabi <timur@freescale.com>:
> > > > > > > sapirf fersht wrote:
> > > > > > > > For a ixp425 cpu how should the environment value
> > > > > > > > #define CFG_ENV_IS_IN_FLASH be set?
> > > > > > > >
> > > > > > > > #define CFG_ENV_IS_IN_FLASH
> > > > > > > >
> > > > > > > > OR
> > > > > > > >
> > > > > > > > #define CFG_ENV_IS_IN_FLASH 1
> > > > > > >
> > > > > > > The code that uses these macros should support both methods, but personally I prefer that
> > > > > > > the macros themselves be defined using the first method.  IMHO, you should define a macro
> > > > > > > to contain a value only if that value has some inherent significance.  For example, does
> > > > > > > "1" really mean something that "2" doesn't?  In this case, no.
> > > > > > >
> > > > > > > --
> > > > > > > Timur Tabi
> > > > > > > Linux Kernel Developer @ Freescale
> > > > > > >
> > > > > > > -------------------------------------------------------------------------
> > > > > > > This SF.net email is sponsored by DB2 Express
> > > > > > > Download DB2 Express C - the FREE version of DB2 express and take
> > > > > > > control of your XML. No limits. Just data. Click to get it now.
> > > > > > > http://sourceforge.net/powerbar/db2/
> > > > > > > _______________________________________________
> > > > > > > U-Boot-Users mailing list
> > > > > > > U-Boot-Users at lists.sourceforge.net
> > > > > > > https://lists.sourceforge.net/lists/listinfo/u-boot-users
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

[U-Boot-Users] environment settings question

[nicky geerts]

btw, please select "reply to all" so the replies are sent to the
u-boot-users mailing list too, I'm hardly an expert :-)  and this way
other people can share their experiences/opinions as well.

nicky

2007/6/26, sapirf fersht <sapirf@gmail.com>:
> Cool. ;-)
>
> I"ll post the debug as soon as i go to them and check the board.
> I already added the #define DEBUG in the .h file.
>
> On 6/26/07, nicky geerts <nicky.geerts.news@gmail.com> wrote:
> > debug will also show all accesses to the flash (like unprotect, erase,
> > write, protect), so if the saveenv command doesn't work, it'll show up
> > in the traces
> >
> > Nicky
> >
> > 2007/6/26, sapirf fersht <sapirf@gmail.com>:
> > > That's a good tip. Thanks a lot. I mainly used printf in places where
> > > i suspected. The problem is that where i suspected things will go
> > > wrong, it turned out that it was ok.
> > >
> > > On 6/26/07, nicky geerts <nicky.geerts.news@gmail.com> wrote:
> > > > I guess you'll be fine using the first three defines, I just use the
> > > > redundant sector for backup.
> > > >
> > > > in the command line interface, when you change environment settings
> > > > with "setenv", don't forget to save them with "saveenv", compile with
> > > > code with "#define DEBUG" in your config header file to enable the
> > > > output of all debug messages.
> > > >
> > > > Nicky
> > > >
> > > > 2007/6/26, sapirf fersht <sapirf@gmail.com>:
> > > > > > you also need to indicate where this redundant storage is located
> > > > > > (also see the README file for more information on what these defines
> > > > > > do):
> > > > > >
> > > > > > for example
> > > > > > #define CFG_ENV_IS_IN_FLASH     1
> > > > > > #define CFG_ENV_ADDR            0xXXXXXXXX
> > > > > > #define CFG_ENV_SECT_SIZE       0xXXXXXXXX
> > > > >
> > > > >
> > > > > > #define CFG_ENV_ADDR_REDUND     0xXXXXXXXX
> > > > > > #define CFG_ENV_SIZE_REDUND     0xXXXXXXXX
> > > > >
> > > > > I just read the README about these parameters.
> > > > > These settings describe a second storage area used to hold
> > > > >            a redundand copy of the environment data, so that there is
> > > > >            a valid backup copy in case there is a power failure during
> > > > >            a "saveenv" operation.
> > > > >
> > > > > My board is based on ixdp425. I don't have these values. Is it wrong?
> > > > >
> > > > > >
> > > > > > Nicky Geerts
> > > > > >
> > > > > > 2007/6/26, sapirf fersht <sapirf@gmail.com>:
> > > > > > > see below my reply:
> > > > > > >
> > > > > > > On 6/26/07, nicky geerts <nicky.geerts.news@gmail.com> wrote:
> > > > > > > > grep -r CFG_ENV_IS_IN_FLASH * | grep if
> > > > > > > >
> > > > > > > > it does show that CFG_ENV_IS_IN_FLASH is checked to be '1' in some
> > > > > > > > custom board flash drivers
> > > > > > >
> > > > > > > in 90% of the boards it appears with 1.  The rest which it didn't
> > > > > > > appear i thought it's just a mistake which didn't make any problems
> > > > > > > with compilation.
> > > > > > >
> > > > > > > The problem is that it still reads from default after reset instead
> > > > > > > from from flash.
> > > > > > >
> > > > > > > Can it be that the flash environment sector is protected, and i need
> > > > > > > to unprotect, copy and put the protect on again?
> > > > > > >
> > > > > > >
> > > > > > > >
> > > > > > > > your safest bet would be the second option, although I agree with
> > > > > > > > Timur Tabi that it isn't really logical.
> > > > > > > >
> > > > > > > > 2007/6/26, Timur Tabi <timur@freescale.com>:
> > > > > > > > > sapirf fersht wrote:
> > > > > > > > > > For a ixp425 cpu how should the environment value
> > > > > > > > > > #define CFG_ENV_IS_IN_FLASH be set?
> > > > > > > > > >
> > > > > > > > > > #define CFG_ENV_IS_IN_FLASH
> > > > > > > > > >
> > > > > > > > > > OR
> > > > > > > > > >
> > > > > > > > > > #define CFG_ENV_IS_IN_FLASH 1
> > > > > > > > >
> > > > > > > > > The code that uses these macros should support both methods, but personally I prefer that
> > > > > > > > > the macros themselves be defined using the first method.  IMHO, you should define a macro
> > > > > > > > > to contain a value only if that value has some inherent significance.  For example, does
> > > > > > > > > "1" really mean something that "2" doesn't?  In this case, no.
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > Timur Tabi
> > > > > > > > > Linux Kernel Developer @ Freescale
> > > > > > > > >
> > > > > > > > > -------------------------------------------------------------------------
> > > > > > > > > This SF.net email is sponsored by DB2 Express
> > > > > > > > > Download DB2 Express C - the FREE version of DB2 express and take
> > > > > > > > > control of your XML. No limits. Just data. Click to get it now.
> > > > > > > > > http://sourceforge.net/powerbar/db2/
> > > > > > > > > _______________________________________________
> > > > > > > > > U-Boot-Users mailing list
> > > > > > > > > U-Boot-Users at lists.sourceforge.net
> > > > > > > > > https://lists.sourceforge.net/lists/listinfo/u-boot-users
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

[U-Boot-Users] environment settings question

[sapirf fersht]

Cool. ;-)

I"ll post the debug as soon as i go to them and check the board.
I already added the #define DEBUG in the .h file.

On 6/26/07, nicky geerts <nicky.geerts.news@gmail.com> wrote:
> debug will also show all accesses to the flash (like unprotect, erase,
> write, protect), so if the saveenv command doesn't work, it'll show up
> in the traces
>
> Nicky
>
> 2007/6/26, sapirf fersht <sapirf@gmail.com>:
> > That's a good tip. Thanks a lot. I mainly used printf in places where
> > i suspected. The problem is that where i suspected things will go
> > wrong, it turned out that it was ok.
> >
> > On 6/26/07, nicky geerts <nicky.geerts.news@gmail.com> wrote:
> > > I guess you'll be fine using the first three defines, I just use the
> > > redundant sector for backup.
> > >
> > > in the command line interface, when you change environment settings
> > > with "setenv", don't forget to save them with "saveenv", compile with
> > > code with "#define DEBUG" in your config header file to enable the
> > > output of all debug messages.
> > >
> > > Nicky
> > >
> > > 2007/6/26, sapirf fersht <sapirf@gmail.com>:
> > > > > you also need to indicate where this redundant storage is located
> > > > > (also see the README file for more information on what these defines
> > > > > do):
> > > > >
> > > > > for example
> > > > > #define CFG_ENV_IS_IN_FLASH     1
> > > > > #define CFG_ENV_ADDR            0xXXXXXXXX
> > > > > #define CFG_ENV_SECT_SIZE       0xXXXXXXXX
> > > >
> > > >
> > > > > #define CFG_ENV_ADDR_REDUND     0xXXXXXXXX
> > > > > #define CFG_ENV_SIZE_REDUND     0xXXXXXXXX
> > > >
> > > > I just read the README about these parameters.
> > > > These settings describe a second storage area used to hold
> > > >            a redundand copy of the environment data, so that there is
> > > >            a valid backup copy in case there is a power failure during
> > > >            a "saveenv" operation.
> > > >
> > > > My board is based on ixdp425. I don't have these values. Is it wrong?
> > > >
> > > > >
> > > > > Nicky Geerts
> > > > >
> > > > > 2007/6/26, sapirf fersht <sapirf@gmail.com>:
> > > > > > see below my reply:
> > > > > >
> > > > > > On 6/26/07, nicky geerts <nicky.geerts.news@gmail.com> wrote:
> > > > > > > grep -r CFG_ENV_IS_IN_FLASH * | grep if
> > > > > > >
> > > > > > > it does show that CFG_ENV_IS_IN_FLASH is checked to be '1' in some
> > > > > > > custom board flash drivers
> > > > > >
> > > > > > in 90% of the boards it appears with 1.  The rest which it didn't
> > > > > > appear i thought it's just a mistake which didn't make any problems
> > > > > > with compilation.
> > > > > >
> > > > > > The problem is that it still reads from default after reset instead
> > > > > > from from flash.
> > > > > >
> > > > > > Can it be that the flash environment sector is protected, and i need
> > > > > > to unprotect, copy and put the protect on again?
> > > > > >
> > > > > >
> > > > > > >
> > > > > > > your safest bet would be the second option, although I agree with
> > > > > > > Timur Tabi that it isn't really logical.
> > > > > > >
> > > > > > > 2007/6/26, Timur Tabi <timur@freescale.com>:
> > > > > > > > sapirf fersht wrote:
> > > > > > > > > For a ixp425 cpu how should the environment value
> > > > > > > > > #define CFG_ENV_IS_IN_FLASH be set?
> > > > > > > > >
> > > > > > > > > #define CFG_ENV_IS_IN_FLASH
> > > > > > > > >
> > > > > > > > > OR
> > > > > > > > >
> > > > > > > > > #define CFG_ENV_IS_IN_FLASH 1
> > > > > > > >
> > > > > > > > The code that uses these macros should support both methods, but personally I prefer that
> > > > > > > > the macros themselves be defined using the first method.  IMHO, you should define a macro
> > > > > > > > to contain a value only if that value has some inherent significance.  For example, does
> > > > > > > > "1" really mean something that "2" doesn't?  In this case, no.
> > > > > > > >
> > > > > > > > --
> > > > > > > > Timur Tabi
> > > > > > > > Linux Kernel Developer @ Freescale
> > > > > > > >
> > > > > > > > -------------------------------------------------------------------------
> > > > > > > > This SF.net email is sponsored by DB2 Express
> > > > > > > > Download DB2 Express C - the FREE version of DB2 express and take
> > > > > > > > control of your XML. No limits. Just data. Click to get it now.
> > > > > > > > http://sourceforge.net/powerbar/db2/
> > > > > > > > _______________________________________________
> > > > > > > > U-Boot-Users mailing list
> > > > > > > > U-Boot-Users at lists.sourceforge.net
> > > > > > > > https://lists.sourceforge.net/lists/listinfo/u-boot-users
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>