From: Daniel Laird <daniel.j.laird@nxp.com>
To: linux-mips@linux-mips.org
Subject: Generating patches and using checkpatch.pl
Date: Thu, 28 Jun 2007 15:37:06 +0100 [thread overview]
Message-ID: <4683C792.4000100@nxp.com> (raw)
I am trying to start feeding back various patches to do with supporting
the hardware I work on.
The company also decided upon a name change so I thought I would do this
as well.
So I moved arch/mips/philips to arch/mips/nxp.
I generated a patch
I ran checkpatch.pl as Ralf suggested before.
I now have pages of errors in the patch
- Line over 80 chars
- printk must have KERN_ debug level
- must have a space after this (, or *)
- use tabs not spaces
- Do not use C99 comments.
To name but a few
My question is:
If you do a patch and find all these errors is it expected that I fix
all these problems, or I just make sure my changes do not make it worse!
Dan
next reply other threads:[~2007-06-28 14:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-28 14:37 Daniel Laird [this message]
2007-06-28 17:45 ` Generating patches and using checkpatch.pl Jan-Benedict Glaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4683C792.4000100@nxp.com \
--to=daniel.j.laird@nxp.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.