Generating patches and using checkpatch.pl

Generating patches and using checkpatch.pl

[Daniel Laird]

I am trying to start feeding back various patches to do with supporting 
the hardware I work on.
The company also decided upon a name change so I thought I would do this 
as well.
So I moved arch/mips/philips to arch/mips/nxp.

I generated a patch
I ran checkpatch.pl as Ralf suggested before.

I now have pages of errors in the patch

- Line over 80 chars
- printk must have KERN_ debug level
- must have a space after this (, or *)
- use tabs not spaces
- Do not use C99 comments.
To name but a few

My question is:
If you do a patch and find all these errors is it expected that I fix 
all these problems, or I just make sure my changes do not make it worse!

Dan

Re: Generating patches and using checkpatch.pl

[Jan-Benedict Glaw]

[-- Attachment #1: Type: text/plain, Size: 957 bytes --]

On Thu, 2007-06-28 15:37:06 +0100, Daniel Laird <daniel.j.laird@nxp.com> wrote:
> I ran checkpatch.pl as Ralf suggested before.
[...]
> - Line over 80 chars
> - printk must have KERN_ debug level
> - must have a space after this (, or *)
> - use tabs not spaces
> - Do not use C99 comments.
> To name but a few
> 
> My question is:
> If you do a patch and find all these errors is it expected that I fix 
> all these problems, or I just make sure my changes do not make it worse!

General rules of thumb:

  * Keep the coding style of the file if you're only doing minor
    patching. Don't introduce leading whitespace, leading tabs before
    spaces. Maybe keep the comment and indention style.

  * If it's more like a rewrite, fix it entirely.

MfG, JBG

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
Signature of:                 Gib Dein Bestes. Dann übertriff Dich selbst!
the second  :

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]