Re: [PATCH 3/3] NetXen: Graceful teardown of interface and hardware upon module unload

[Jeff Garzik <jeff@garzik.org>]

Michael Buesch wrote:
> On Saturday 30 June 2007 22:38:47 dhananjay.phadke@gmail.com wrote:
>> These changes allow driver close routine to be called during module unload,
>> to clean-up buffers and other software resources, flush queues etc. Also,
>> hardware is reset to pristine state. 
>>
>> Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com>
>> Signed-off-by: Milan Bag <mbag@netxen.com>
>> Signed-off-by: Wen Xiong <wenxiong@us.ibm.com>
> 
>>  		off = netxen_nic_pci_set_window(adapter, memaddr);
>>  		addr = pci_base_offset(adapter, off);
>>  		writel(data, addr);
>> +		do {
>> +			if (readl(addr) == data)
>> +				break;
>> +			msleep_interruptible(100);
> 
> If you use msleep_interruptible(), I'd say you should check for
> the return value of that call and probably abort firmware
> processing here if a signal interrupted us.

While strictly this is true, I strongly urge the use of 
non-interruptible sleeps when used in hardware-related delays.  Very 
rarely does one really want to care about signals for such cases.

	Jeff