From: Jeff Garzik <jeff@garzik.org>
To: Dhananjay Phadke <dhananjay.phadke@gmail.com>
Cc: Michael Buesch <mb@bu3sch.de>,
netdev@vger.kernel.org, rob@netxen.com,
Milan Bag <mbag@netxen.com>, Wen Xiong <wenxiong@us.ibm.com>
Subject: Re: [PATCH 3/3] NetXen: Graceful teardown of interface and hardware upon module unload
Date: Sat, 30 Jun 2007 23:27:07 -0400 [thread overview]
Message-ID: <46871F0B.6020801@garzik.org> (raw)
In-Reply-To: <ab901500706301849h5f8e25c7k8e2c0a8f04dd3198@mail.gmail.com>
Dhananjay Phadke wrote:
> This stage is safe to bail out on signal. It's initializing about a
> hundred registers
> and trying to guaranty by retrying, so can get stretched too much on
> faulty h/w.
This implies that you have -add- code to check for and handle signals at
each delay point. Don't bother. Too much code bloat for negligable gain.
It is better just to remove the _interruptible, for many reasons.
Jeff
prev parent reply other threads:[~2007-07-01 3:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-30 20:38 [PATCH 0/3] NetXen: Bug fixes for multiport and blade adapters dhananjay.phadke
2007-06-30 20:38 ` [PATCH 1/3] NetXen: Fix issue of MSI not working correctly dhananjay.phadke
2007-06-30 20:38 ` [PATCH 2/3] NetXen: Support per PCI-function interrupt mask registers dhananjay.phadke
2007-06-30 22:17 ` Michael Buesch
2007-06-30 20:38 ` [PATCH 3/3] NetXen: Graceful teardown of interface and hardware upon module unload dhananjay.phadke
2007-06-30 22:12 ` Michael Buesch
2007-06-30 22:43 ` Jeff Garzik
2007-07-01 1:49 ` Dhananjay Phadke
2007-07-01 3:27 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46871F0B.6020801@garzik.org \
--to=jeff@garzik.org \
--cc=dhananjay.phadke@gmail.com \
--cc=mb@bu3sch.de \
--cc=mbag@netxen.com \
--cc=netdev@vger.kernel.org \
--cc=rob@netxen.com \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.