From: Patrick McHardy <kaber@trash.net>
To: NICOLAS BOULIANE <nicboul@gmail.com>
Cc: Netfilter Development Mailinglist <netfilter-devel@lists.netfilter.org>
Subject: Re: [PATCH] libipt_statistic
Date: Mon, 02 Jul 2007 16:58:28 +0200 [thread overview]
Message-ID: <46891294.9030405@trash.net> (raw)
In-Reply-To: <dd45289d0707020751j6bb5de27k25bc73e4337c818b@mail.gmail.com>
[Don't remove CCs please]
NICOLAS BOULIANE wrote:
> Hi Patrick,
>
> First, there's no upper bound check to ensure that `--packet` value is n-1,
> so I'm confused.
>
> if (string_to_number(optarg, 0, 0xFFFFFFFF,
> &info->u.nth.packet) == -1)
Yes, that should be fixed.
>
> But even if I do:
> --every 4 --packet 2
> The first time it will match the 3th packet
> and all next time it will match the 4th packet, which I dont
> understand why (technically yes, but philosophically not).
>
> Matching pattern look like:
> 1,2,(3),4,5,6,(7),8,9,10,(11),12,13,14,(15)
It starts at zero and goes up to n - 1. So for the second
packet you would actually use --packet 1. A bit
counterintuitive, I agree, but too late to change.
next prev parent reply other threads:[~2007-07-02 14:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-02 0:10 [PATCH] libipt_statistic NICOLAS BOULIANE
2007-07-02 13:11 ` Patrick McHardy
[not found] ` <dd45289d0707020751j6bb5de27k25bc73e4337c818b@mail.gmail.com>
2007-07-02 14:58 ` Patrick McHardy [this message]
2007-07-02 15:02 ` Patrick McHardy
2007-07-02 17:38 ` NICOLAS BOULIANE
2007-07-02 17:40 ` Patrick McHardy
2007-07-02 18:05 ` NICOLAS BOULIANE
2007-07-02 18:16 ` Patrick McHardy
2007-07-02 19:10 ` NICOLAS BOULIANE
2007-07-02 19:14 ` Patrick McHardy
2007-07-02 19:38 ` NICOLAS BOULIANE
2007-07-02 19:55 ` Jan Engelhardt
2007-07-02 20:09 ` NICOLAS BOULIANE
2007-07-03 11:46 ` Patrick McHardy
2007-07-03 11:45 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46891294.9030405@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@lists.netfilter.org \
--cc=nicboul@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.