All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: NICOLAS BOULIANE <nicboul@gmail.com>
Cc: Jan Engelhardt <jengelh@computergmbh.de>,
	Netfilter Development Mailinglist
	<netfilter-devel@lists.netfilter.org>
Subject: Re: [PATCH] libipt_statistic
Date: Tue, 03 Jul 2007 13:46:34 +0200	[thread overview]
Message-ID: <468A371A.3000006@trash.net> (raw)
In-Reply-To: <dd45289d0707021309j301444al87a932b8bf810ac2@mail.gmail.com>

NICOLAS BOULIANE wrote:
> On 7/2/07, Jan Engelhardt <jengelh@computergmbh.de> wrote:
> 
>> >Index: libipt_statistic.c
>> >===================================================================
>> >--- libipt_statistic.c (revision 6898)
>> >+++ libipt_statistic.c (working copy)
>> >@@ -113,6 +113,15 @@
>> >       if (flags & 0x8 && info->mode != XT_STATISTIC_MODE_NTH)
>> >               exit_error(PARAMETER_PROBLEM,
>> >                          "--packet can only be used in nth mode");
>> >+      if ((flags & 0x8) && !(flags & 0x4))
>>
>> This could perhaps be
>>
>>         if ((flags & 0xC) == 0x8)
>>
>>
>>         Jan
>> -- 
>>
> 
> same result, less intuitive. why should I do that ?


Indeed. What would make sense is to use a couple of symbolic
constants for the flag values.

  reply	other threads:[~2007-07-03 11:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-02  0:10 [PATCH] libipt_statistic NICOLAS BOULIANE
2007-07-02 13:11 ` Patrick McHardy
     [not found]   ` <dd45289d0707020751j6bb5de27k25bc73e4337c818b@mail.gmail.com>
2007-07-02 14:58     ` Patrick McHardy
2007-07-02 15:02       ` Patrick McHardy
2007-07-02 17:38       ` NICOLAS BOULIANE
2007-07-02 17:40         ` Patrick McHardy
2007-07-02 18:05           ` NICOLAS BOULIANE
2007-07-02 18:16             ` Patrick McHardy
2007-07-02 19:10               ` NICOLAS BOULIANE
2007-07-02 19:14                 ` Patrick McHardy
2007-07-02 19:38                   ` NICOLAS BOULIANE
2007-07-02 19:55                     ` Jan Engelhardt
2007-07-02 20:09                       ` NICOLAS BOULIANE
2007-07-03 11:46                         ` Patrick McHardy [this message]
2007-07-03 11:45                     ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=468A371A.3000006@trash.net \
    --to=kaber@trash.net \
    --cc=jengelh@computergmbh.de \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=nicboul@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.