All of lore.kernel.org
 help / color / mirror / Atom feed
* [lm-sensors] PATCH: hwmon-abituguru3-detect.patch
@ 2007-07-02 20:59 Hans de Goede
  2007-07-08 15:59 ` Mark M. Hoffman
  0 siblings, 1 reply; 2+ messages in thread
From: Hans de Goede @ 2007-07-02 20:59 UTC (permalink / raw)
  To: lm-sensors

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

Hi All, Mark,

Mark, this fixes the abituguru3 driver not detecting the uguru3 on some 
motherboards without the force=1 parameter, see:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220160

Can you apply this to your testing tree please? Thanks!

Regards,

Hans

[-- Attachment #2: hwmon-abituguru3-detect.patch --]
[-- Type: text/x-patch, Size: 1810 bytes --]

This patch changes the driver to also detect uguru3's which hold 0x08 at DATA
initially, as has been reported here:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220160

Also when an uguru3's holds 0x0014 in the ID register it will now report 
"Abit AB9 Pro" as motherboard identification.

Signed-off-by: Hans de Goede <j.w.r.degoede@hhs.nl>
diff -up linux-2.6.22-rc4/drivers/hwmon/abituguru3.c~ linux-2.6.22-rc4/drivers/hwmon/abituguru3.c
--- linux-2.6.22-rc4/drivers/hwmon/abituguru3.c~	2007-07-02 22:21:23.000000000 +0200
+++ linux-2.6.22-rc4/drivers/hwmon/abituguru3.c	2007-07-02 22:21:23.000000000 +0200
@@ -351,7 +351,7 @@ static const struct abituguru3_motherboa
 		{ "AUX4 Fan",		38, 2, 60, 1, 0 },
 		{ NULL, 0, 0, 0, 0, 0 } }
 	},
-	{ 0x0014, "unknown", {
+	{ 0x0014, "Abit AB9 Pro", {
 		{ "CPU Core",		 0, 0, 10, 1, 0 },
 		{ "DDR",		 1, 0, 10, 1, 0 },
 		{ "DDR VTT",		 2, 0, 10, 1, 0 },
@@ -1053,12 +1053,13 @@ static struct platform_driver abituguru3
 
 static int __init abituguru3_detect(void)
 {
-	/* See if there is an uguru3 there. An idle uGuru3 will hold 0x00
-	   at DATA and 0xAC at CMD. Sometimes the uGuru3 will hold 0x05 at
-	   CMD instead, why is unknown. So we test for 0x05 too. */
+	/* See if there is an uguru3 there. An idle uGuru3 will hold 0x00 or
+	   0x08 at DATA and 0xAC at CMD. Sometimes the uGuru3 will hold 0x05
+	   at CMD instead, why is unknown. So we test for 0x05 too. */
 	u8 data_val = inb_p(ABIT_UGURU3_BASE + ABIT_UGURU3_DATA);
 	u8 cmd_val = inb_p(ABIT_UGURU3_BASE + ABIT_UGURU3_CMD);
-	if ((data_val == 0x00) && ((cmd_val == 0xAC) || (cmd_val == 0x05)))
+	if (((data_val == 0x00) || (data_val == 0x08)) &&
+			((cmd_val == 0xAC) || (cmd_val == 0x05)))
 		return ABIT_UGURU3_BASE;
 
 	ABIT_UGURU3_DEBUG("no Abit uGuru3 found, data = 0x%02X, cmd = "

[-- Attachment #3: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [lm-sensors] PATCH: hwmon-abituguru3-detect.patch
  2007-07-02 20:59 [lm-sensors] PATCH: hwmon-abituguru3-detect.patch Hans de Goede
@ 2007-07-08 15:59 ` Mark M. Hoffman
  0 siblings, 0 replies; 2+ messages in thread
From: Mark M. Hoffman @ 2007-07-08 15:59 UTC (permalink / raw)
  To: lm-sensors

Hi Hans:

* Hans de Goede <j.w.r.degoede@hhs.nl> [2007-07-02 23:08:26 +0200]:
> Hi All, Mark,
> 
> Mark, this fixes the abituguru3 driver not detecting the uguru3 on some 
> motherboards without the force=1 parameter, see:
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id"0160
> 
> Can you apply this to your testing tree please? Thanks!
> 
> Regards,
> 
> Hans

> This patch changes the driver to also detect uguru3's which hold 0x08 at DATA
> initially, as has been reported here:
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id"0160
> 
> Also when an uguru3's holds 0x0014 in the ID register it will now report 
> "Abit AB9 Pro" as motherboard identification.
> 
> Signed-off-by: Hans de Goede <j.w.r.degoede@hhs.nl>

Applied to testing; thanks.

-- 
Mark M. Hoffman
mhoffman@lightlink.com


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-07-08 15:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-02 20:59 [lm-sensors] PATCH: hwmon-abituguru3-detect.patch Hans de Goede
2007-07-08 15:59 ` Mark M. Hoffman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.