From: Zachary Amsden <zach@vmware.com>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Hugh Dickins <hugh@veritas.com>
Subject: Re: [patch 3/5] remove ptep_test_and_clear_dirty and ptep_clear_flush_dirty.
Date: Mon, 02 Jul 2007 18:29:53 -0700 [thread overview]
Message-ID: <4689A691.9090908@vmware.com> (raw)
In-Reply-To: <20070629141528.060235678@de.ibm.com>
Martin Schwidefsky wrote:
> From: Martin Schwidefsky <schwidefsky@de.ibm.com>
>
> Nobody is using ptep_test_and_clear_dirty and ptep_clear_flush_dirty.
> Remove the functions from all architectures.
>
>
> -static inline int
> -ptep_test_and_clear_dirty (struct vm_area_struct *vma, unsigned long addr, pte_t *ptep)
> -{
> -#ifdef CONFIG_SMP
> - if (!pte_dirty(*ptep))
> - return 0;
> - return test_and_clear_bit(_PAGE_D_BIT, ptep);
> -#else
> - pte_t pte = *ptep;
> - if (!pte_dirty(pte))
> - return 0;
> - set_pte_at(vma->vm_mm, addr, ptep, pte_mkclean(pte));
> - return 1;
> -#endif
> -}
I've not followed all the changes lately - what is the current protocol
for clearing dirty bit? Is it simply pte_clear followed by set or is it
not done at all? At least for i386 and virtualization, we had several
optimizations to the test_and_clear path that are not possible with a
pte_clear / set_pte approach.
Zach
WARNING: multiple messages have this Message-ID (diff)
From: Zachary Amsden <zach@vmware.com>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Hugh Dickins <hugh@veritas.com>
Subject: Re: [patch 3/5] remove ptep_test_and_clear_dirty and ptep_clear_flush_dirty.
Date: Mon, 02 Jul 2007 18:29:53 -0700 [thread overview]
Message-ID: <4689A691.9090908@vmware.com> (raw)
In-Reply-To: <20070629141528.060235678@de.ibm.com>
Martin Schwidefsky wrote:
> From: Martin Schwidefsky <schwidefsky@de.ibm.com>
>
> Nobody is using ptep_test_and_clear_dirty and ptep_clear_flush_dirty.
> Remove the functions from all architectures.
>
>
> -static inline int
> -ptep_test_and_clear_dirty (struct vm_area_struct *vma, unsigned long addr, pte_t *ptep)
> -{
> -#ifdef CONFIG_SMP
> - if (!pte_dirty(*ptep))
> - return 0;
> - return test_and_clear_bit(_PAGE_D_BIT, ptep);
> -#else
> - pte_t pte = *ptep;
> - if (!pte_dirty(pte))
> - return 0;
> - set_pte_at(vma->vm_mm, addr, ptep, pte_mkclean(pte));
> - return 1;
> -#endif
> -}
I've not followed all the changes lately - what is the current protocol
for clearing dirty bit? Is it simply pte_clear followed by set or is it
not done at all? At least for i386 and virtualization, we had several
optimizations to the test_and_clear path that are not possible with a
pte_clear / set_pte approach.
Zach
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-07-03 1:38 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-29 13:55 [patch 0/5] Various mm improvements Martin Schwidefsky
2007-06-29 13:55 ` Martin Schwidefsky
2007-06-29 13:55 ` [patch 1/5] avoid tlb gather restarts Martin Schwidefsky
2007-06-29 13:55 ` Martin Schwidefsky, Martin Schwidefsky
2007-06-29 18:56 ` Hugh Dickins
2007-06-29 18:56 ` Hugh Dickins
2007-06-29 21:19 ` Martin Schwidefsky
2007-06-29 21:19 ` Martin Schwidefsky
2007-06-30 13:16 ` Hugh Dickins
2007-06-30 13:16 ` Hugh Dickins
2007-06-29 13:55 ` [patch 2/5] remove ptep_establish Martin Schwidefsky
2007-06-29 13:55 ` Martin Schwidefsky, Martin Schwidefsky
2007-06-29 13:55 ` [patch 3/5] remove ptep_test_and_clear_dirty and ptep_clear_flush_dirty Martin Schwidefsky
2007-06-29 13:55 ` Martin Schwidefsky, Martin Schwidefsky
2007-07-03 1:29 ` Zachary Amsden [this message]
2007-07-03 1:29 ` Zachary Amsden
2007-07-03 7:26 ` Martin Schwidefsky
2007-07-03 7:26 ` Martin Schwidefsky
2007-06-29 13:55 ` [patch 4/5] move mm_struct and vm_area_struct Martin Schwidefsky
2007-06-29 13:55 ` Martin Schwidefsky, Martin Schwidefsky
2007-06-29 13:55 ` [patch 5/5] Optimize page_mkclean_one Martin Schwidefsky
2007-06-29 13:55 ` Martin Schwidefsky, Martin Schwidefsky
2007-06-30 14:04 ` Hugh Dickins
2007-06-30 14:04 ` Hugh Dickins
2007-07-01 7:15 ` Martin Schwidefsky
2007-07-01 7:15 ` Martin Schwidefsky
2007-07-01 8:54 ` Hugh Dickins
2007-07-01 8:54 ` Hugh Dickins
2007-07-01 13:27 ` Peter Zijlstra
2007-07-01 13:27 ` Peter Zijlstra
2007-07-02 7:07 ` Martin Schwidefsky
2007-07-02 7:07 ` Martin Schwidefsky
2007-07-01 19:50 ` Martin Schwidefsky
2007-07-01 19:50 ` Martin Schwidefsky
2007-07-01 10:29 ` Miklos Szeredi
2007-07-01 10:29 ` Miklos Szeredi
-- strict thread matches above, loose matches on Subject: below --
2007-07-03 11:18 [patch 0/5] some mm improvements + s390 tlb flush Martin Schwidefsky
2007-07-03 11:18 ` [patch 3/5] remove ptep_test_and_clear_dirty and ptep_clear_flush_dirty Martin Schwidefsky
2007-07-03 11:18 ` Martin Schwidefsky, Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4689A691.9090908@vmware.com \
--to=zach@vmware.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.