All of lore.kernel.org
 help / color / mirror / Atom feed
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Pavel Emelianov <xemul@openvz.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux MM Mailing List <linux-mm@kvack.org>,
	Eric W Biederman <ebiederm@xmission.com>,
	Linux Containers <containers@lists.osdl.org>,
	Paul Menage <menage@google.com>
Subject: Re: [-mm PATCH 6/8] Memory controller add per container LRU and reclaim (v2)
Date: Fri, 06 Jul 2007 00:05:12 -0700	[thread overview]
Message-ID: <468DE9A8.8000107@linux.vnet.ibm.com> (raw)
In-Reply-To: <20070706052212.11677.26502.sendpatchset@balbir-laptop>

Balbir Singh wrote:
> +unsigned long mem_container_isolate_pages(unsigned long nr_to_scan,
> +					struct list_head *dst,
> +					unsigned long *scanned, int order,
> +					int mode, struct zone *z,
> +					struct mem_container *mem_cont,
> +					int active)

[snip]

> +{
> +		/*
> +		 * Check if the meta page went away from under us
> +		 */
> +		if (!list_empty(&mp->list)

There is a small typo here, we need an extra brace at the end
(I should have done a refpatch :( )


-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL

WARNING: multiple messages have this Message-ID (diff)
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Pavel Emelianov <xemul@openvz.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux MM Mailing List <linux-mm@kvack.org>,
	Eric W Biederman <ebiederm@xmission.com>,
	Linux Containers <containers@lists.osdl.org>,
	Paul Menage <menage@google.com>
Subject: Re: [-mm PATCH 6/8] Memory controller add per container LRU and reclaim (v2)
Date: Fri, 06 Jul 2007 00:05:12 -0700	[thread overview]
Message-ID: <468DE9A8.8000107@linux.vnet.ibm.com> (raw)
In-Reply-To: <20070706052212.11677.26502.sendpatchset@balbir-laptop>

Balbir Singh wrote:
> +unsigned long mem_container_isolate_pages(unsigned long nr_to_scan,
> +					struct list_head *dst,
> +					unsigned long *scanned, int order,
> +					int mode, struct zone *z,
> +					struct mem_container *mem_cont,
> +					int active)

[snip]

> +{
> +		/*
> +		 * Check if the meta page went away from under us
> +		 */
> +		if (!list_empty(&mp->list)

There is a small typo here, we need an extra brace at the end
(I should have done a refpatch :( )


-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-07-06  7:07 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-06  5:20 [-mm PATCH 0/8] Memory controller introduction (v2) Balbir Singh
2007-07-06  5:20 ` Balbir Singh
2007-07-06  5:20 ` [-mm PATCH 1/8] Memory controller resource counters (v2) Balbir Singh
2007-07-06  5:20   ` Balbir Singh
2007-07-06 17:24   ` Dave Hansen
2007-07-06 17:24     ` Dave Hansen
2007-07-06 21:03     ` Balbir Singh
2007-07-06 21:03       ` Balbir Singh
2007-07-06 21:10       ` Dave Hansen
2007-07-06 21:10         ` Dave Hansen
2007-07-06 21:24         ` Balbir Singh
2007-07-06 21:24           ` Balbir Singh
2007-07-09  7:16     ` Pavel Emelianov
2007-07-09  7:16       ` Pavel Emelianov
2007-07-09 19:56       ` Dave Hansen
2007-07-09 19:56         ` Dave Hansen
2007-07-06  5:21 ` [-mm PATCH 2/8] Memory controller containers setup (v2) Balbir Singh
2007-07-06  5:21   ` Balbir Singh
2007-07-06 17:30   ` Dave Hansen
2007-07-06 17:30     ` Dave Hansen
2007-07-06 21:07     ` Balbir Singh
2007-07-06 21:07       ` Balbir Singh
2007-07-06  5:21 ` [-mm PATCH 3/8] Memory controller accounting " Balbir Singh
2007-07-06  5:21   ` Balbir Singh
2007-07-06  5:21 ` [-mm PATCH 4/8] Memory controller memory accounting (v2) Balbir Singh
2007-07-06  5:21   ` Balbir Singh
2007-07-10  7:26   ` YAMAMOTO Takashi
2007-07-10  7:26     ` YAMAMOTO Takashi
2007-07-10  8:41     ` Balbir Singh
2007-07-10  8:41       ` Balbir Singh
2007-07-10  8:44       ` YAMAMOTO Takashi
2007-07-10  8:44         ` YAMAMOTO Takashi
2007-07-10 15:42         ` Balbir Singh
2007-07-10 15:42           ` Balbir Singh
2007-07-06  5:21 ` [-mm PATCH 5/8] Memory controller task migration (v2) Balbir Singh
2007-07-06  5:21   ` Balbir Singh
2007-07-06  5:22 ` [-mm PATCH 6/8] Memory controller add per container LRU and reclaim (v2) Balbir Singh
2007-07-06  5:22   ` Balbir Singh
2007-07-06  7:05   ` Balbir Singh [this message]
2007-07-06  7:05     ` Balbir Singh
2007-07-10  8:41   ` YAMAMOTO Takashi
2007-07-10  8:41     ` YAMAMOTO Takashi
2007-07-10 15:38     ` Balbir Singh
2007-07-10 15:38       ` Balbir Singh
2007-07-06  5:22 ` [-mm PATCH 7/8] Memory controller OOM handling (v2) Balbir Singh
2007-07-06  5:22   ` Balbir Singh
2007-07-06  5:22 ` [-mm PATCH 8/8] Add switch to control what type of pages to limit (v2) Balbir Singh
2007-07-06  5:22   ` Balbir Singh
2007-07-06  5:55 ` [-mm PATCH 0/8] Memory controller introduction (v2) Balbir Singh
2007-07-06  7:09   ` Balbir Singh
2007-07-06  7:09     ` Balbir Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=468DE9A8.8000107@linux.vnet.ibm.com \
    --to=balbir@linux.vnet.ibm.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=containers@lists.osdl.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=menage@google.com \
    --cc=svaidy@linux.vnet.ibm.com \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.