syscall macro fails upon compilation

syscall macro fails upon compilation

[Gautam Singaraju]

I have been adding a syscall to the kernel (v 2.6.21); I am able to
compile and boot into the kernel. However, the userspace macro fails
to compile with the following message: "error: expected declaration
specifiers or â...â before âmycallâ". I could not find any solution
using google. I use the _syscall0 macro. Any suggestion would help.
Thanks!
---
Gautam Singaraju

Re: syscall macro fails upon compilation

[H. Peter Anvin]

Gautam Singaraju wrote:
> I use the _syscall0 macro.

Don't.  The _syscall*() macros have been unsupported for ages, and
broken for ever longer.

	-hpa

Re: syscall macro fails upon compilation

[Andi Kleen]

"H. Peter Anvin" <hpa@zytor.com> writes:

> Gautam Singaraju wrote:
> > I use the _syscall0 macro.
> 
> Don't.  The _syscall*() macros have been unsupported for ages,

That's not true. I supported them on x86 before they were removed against
my objections.

> and broken for ever longer.

Well, most syscall() versions get 6 argument calls wrong
(not sure if that is finally fixed). _syscall*() didn't support
-fPIC for larger argument counts (_syscall0-2 never had a problem) 

So all alternatives short of writing your own stub had various
issues. If you needed 6 argument calls _syscall* was typically
the best alternative.

-Andi

Re: syscall macro fails upon compilation

[Gautam Singaraju]

I am surprised that syscalls have been removed. Anyway, I plan to
write a device node with read and write functions just so that I can
call a method from a user space. What are my other choices?
--
Gautam

On 06 Jul 2007 13:53:41 +0200, Andi Kleen <andi@firstfloor.org> wrote:
> "H. Peter Anvin" <hpa@zytor.com> writes:
>
> > Gautam Singaraju wrote:
> > > I use the _syscall0 macro.
> >
> > Don't.  The _syscall*() macros have been unsupported for ages,
>
> That's not true. I supported them on x86 before they were removed against
> my objections.
>
> > and broken for ever longer.
>
> Well, most syscall() versions get 6 argument calls wrong
> (not sure if that is finally fixed). _syscall*() didn't support
> -fPIC for larger argument counts (_syscall0-2 never had a problem)
>
> So all alternatives short of writing your own stub had various
> issues. If you needed 6 argument calls _syscall* was typically
> the best alternative.
>
> -Andi
>


-- 
---
Gautam

Re: syscall macro fails upon compilation

[H. Peter Anvin]

Gautam Singaraju wrote:
> I am surprised that syscalls have been removed. Anyway, I plan to
> write a device node with read and write functions just so that I can
> call a method from a user space. What are my other choices?

man syscall

	-hpa

Re: syscall macro fails upon compilation

[H. Peter Anvin]

Andi Kleen wrote:
> "H. Peter Anvin" <hpa@zytor.com> writes:
> 
>> Gautam Singaraju wrote:
>>> I use the _syscall0 macro.
>> Don't.  The _syscall*() macros have been unsupported for ages,
> 
> That's not true. I supported them on x86 before they were removed against
> my objections.
> 
>> and broken for ever longer.
> 
> Well, most syscall() versions get 6 argument calls wrong
> (not sure if that is finally fixed). _syscall*() didn't support
> -fPIC for larger argument counts (_syscall0-2 never had a problem) 
> 
> So all alternatives short of writing your own stub had various
> issues. If you needed 6 argument calls _syscall* was typically
> the best alternative.
> 

They were *always* broken for 64-bit arguments on 32-bit machines, however.

	-hpa

Re: syscall macro fails upon compilation

[Andi Kleen]

> They were *always* broken for 64-bit arguments on 32-bit machines, however.

Well syscall() doesn't support that at all (unless you split by hand)

-Andi

Re: syscall macro fails upon compilation

[H. Peter Anvin]

Andi Kleen wrote:
>> They were *always* broken for 64-bit arguments on 32-bit machines, however.
> 
> Well syscall() doesn't support that at all (unless you split by hand)
> 

On i386 it just happens to work, because the calling convention is
equivalent.  On some other 32-bit platforms it works that way as well;
on others, it fails.

To do it right you need a proper assembly stub generator.

	-hpa

Re: syscall macro fails upon compilation

[Davide Libenzi]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 444 bytes --]

On Thu, 5 Jul 2007, Gautam Singaraju wrote:

> I have been adding a syscall to the kernel (v 2.6.21); I am able to
> compile and boot into the kernel. However, the userspace macro fails
> to compile with the following message: "error: expected declaration
> specifiers or â...â before âmycallâ". I could not find any solution
> using google. I use the _syscall0 macro. Any suggestion would help.

Try a `man syscall`



- Davide