All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Daniel Drake <dsd@gentoo.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Jan Beulich <jbeulich@novell.com>,
	linux-kernel@vger.kernel.org, zwane@infradead.org,
	Andi Kleen <ak@suse.de>, "Antonino A. Daplas" <adaplas@pol.net>
Subject: Re: [PATCH] retrieve VBE EDID/DDC info independent of used video mode
Date: Sun, 08 Jul 2007 17:48:57 -0700	[thread overview]
Message-ID: <469185F9.4060604@zytor.com> (raw)
In-Reply-To: <4690E65B.5050607@gentoo.org>

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

Daniel Drake wrote:
> 
> 2.6.22-rc6-mm1 has the same problem (it is not fixed there).
> 

I believe this patch should fix it for 2.6.22-rc6-mm1.  I will check
this into the newsetup tree.

	-hpa

[-- Attachment #2: diff --]
[-- Type: text/plain, Size: 892 bytes --]

diff --git a/arch/i386/boot/video-vesa.c b/arch/i386/boot/video-vesa.c
index 3c21bd7..e6aa9eb 100644
--- a/arch/i386/boot/video-vesa.c
+++ b/arch/i386/boot/video-vesa.c
@@ -28,7 +28,7 @@ static void vesa_store_mode_params_graphics(void);
 
 static int vesa_probe(void)
 {
-#ifdef CONFIG_VIDEO_VESA
+#if defined(CONFIG_VIDEO_VESA) || defined(CONFIG_FIRMWARE_EDID)
 	u16 ax;
 	u16 mode;
 	addr_t mode_ptr;
@@ -47,7 +47,8 @@ static int vesa_probe(void)
 	    vginfo.signature != VESA_MAGIC ||
 	    vginfo.version < 0x0102)
 		return 0;	/* Not present */
-
+#endif /* CONFIG_VIDEO_VESA || CONFIG_FIRMWARE_EDID */
+#ifdef CONFIG_VIDEO_VESA
 	set_fs(vginfo.video_mode_ptr.seg);
 	mode_ptr = vginfo.video_mode_ptr.off;
 
@@ -96,7 +97,7 @@ static int vesa_probe(void)
 	return nmodes;
 #else
 	return 0;
-#endif
+#endif /* CONFIG_VIDEO_VESA */
 }
 
 static int vesa_set_mode(struct mode_info *mode)

  parent reply	other threads:[~2007-07-09  0:55 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-19 15:57 [PATCH] retrieve VBE EDID/DDC info independent of used video mode Jan Beulich
2007-06-30 22:25 ` Daniel Drake
2007-06-30 22:42   ` Andrew Morton
2007-07-08 13:27     ` Daniel Drake
2007-07-08 18:14       ` Andrew Morton
2007-07-08 18:33         ` H. Peter Anvin
2007-07-09 22:53           ` Daniel Drake
2007-07-09 22:59             ` H. Peter Anvin
2007-07-10 17:16               ` Daniel Drake
2007-07-10 17:23                 ` H. Peter Anvin
2007-07-10 18:07                   ` Daniel Drake
2007-07-10 18:15                     ` H. Peter Anvin
2007-07-31 23:58                       ` Daniel Drake
2007-08-01  0:21                         ` Zwane Mwaikambo
2007-08-01  1:17                           ` Daniel Drake
2007-08-01  1:53                             ` H. Peter Anvin
2007-08-01  1:54                             ` Antonino A. Daplas
2007-08-01  2:08                               ` Gabriel C
2007-08-02  3:09                               ` Antonino A. Daplas
2007-08-02  3:50                                 ` H. Peter Anvin
2007-08-02 10:16                                   ` Antonino A. Daplas
2007-08-02 13:23                                     ` H. Peter Anvin
2007-08-03  2:33                                     ` Daniel Drake
2007-08-03  3:33                                       ` Antonino A. Daplas
2007-08-01  1:04                         ` Antonino A. Daplas
2007-07-08 19:48         ` Andi Kleen
2007-07-09  1:10         ` Daniel Drake
2007-07-09  0:48       ` H. Peter Anvin [this message]
2007-07-02 20:13   ` Chuck Ebbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=469185F9.4060604@zytor.com \
    --to=hpa@zytor.com \
    --cc=adaplas@pol.net \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=dsd@gentoo.org \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zwane@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.