From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-mm@kvack.org, Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC/PATCH] Use mmu_gather for fork() instead of flush_tlb_mm()
Date: Mon, 09 Jul 2007 20:12:28 +1000 [thread overview]
Message-ID: <46920A0C.3040400@yahoo.com.au> (raw)
In-Reply-To: <1183974458.5961.42.camel@localhost.localdomain>
Benjamin Herrenschmidt wrote:
> On Mon, 2007-07-09 at 19:29 +1000, Nick Piggin wrote:
>
>>They could just #define one to the other though, there are only a
>>small
>>number of them. Is there a downside to not making them distinct? i386
>>for example probably would just keep doing a tlb flush for fork and
>>not
>>want to worry about touching the tlb gather stuff.
>
>
> But the tlb gather stuff just does ... a flush_tlb_mm() on x86 :-)
But it still does the get_cpu of the mmu gather data structure and
has to look in there and touch the cacheline. You're also having to
do more work when unlocking/relocking the ptl etc.
> I really think it's the right API
--
SUSE Labs, Novell Inc.
WARNING: multiple messages have this Message-ID (diff)
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-mm@kvack.org, Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC/PATCH] Use mmu_gather for fork() instead of flush_tlb_mm()
Date: Mon, 09 Jul 2007 20:12:28 +1000 [thread overview]
Message-ID: <46920A0C.3040400@yahoo.com.au> (raw)
In-Reply-To: <1183974458.5961.42.camel@localhost.localdomain>
Benjamin Herrenschmidt wrote:
> On Mon, 2007-07-09 at 19:29 +1000, Nick Piggin wrote:
>
>>They could just #define one to the other though, there are only a
>>small
>>number of them. Is there a downside to not making them distinct? i386
>>for example probably would just keep doing a tlb flush for fork and
>>not
>>want to worry about touching the tlb gather stuff.
>
>
> But the tlb gather stuff just does ... a flush_tlb_mm() on x86 :-)
But it still does the get_cpu of the mmu gather data structure and
has to look in there and touch the cacheline. You're also having to
do more work when unlocking/relocking the ptl etc.
> I really think it's the right API
--
SUSE Labs, Novell Inc.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-07-09 10:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-09 3:47 removing flush_tlb_mm as a generic hook ? Benjamin Herrenschmidt
2007-07-09 3:47 ` Benjamin Herrenschmidt
2007-07-09 6:36 ` Benjamin Herrenschmidt
2007-07-09 6:36 ` Benjamin Herrenschmidt
2007-07-09 6:45 ` [RFC/PATCH] Use mmu_gather for fork() instead of flush_tlb_mm() Benjamin Herrenschmidt
2007-07-09 6:45 ` Benjamin Herrenschmidt
2007-07-09 7:39 ` Nick Piggin
2007-07-09 7:39 ` Nick Piggin
2007-07-09 9:12 ` Benjamin Herrenschmidt
2007-07-09 9:12 ` Benjamin Herrenschmidt
2007-07-09 9:29 ` Nick Piggin
2007-07-09 9:29 ` Nick Piggin
2007-07-09 9:47 ` Benjamin Herrenschmidt
2007-07-09 9:47 ` Benjamin Herrenschmidt
2007-07-09 10:12 ` Nick Piggin [this message]
2007-07-09 10:12 ` Nick Piggin
2007-07-09 10:18 ` Nick Piggin
2007-07-09 10:18 ` Nick Piggin
2007-07-09 12:37 ` Benjamin Herrenschmidt
2007-07-09 12:37 ` Benjamin Herrenschmidt
2007-07-09 12:32 ` Benjamin Herrenschmidt
2007-07-09 12:32 ` Benjamin Herrenschmidt
2007-07-09 6:46 ` [RFC/PATCH] Use mmu_gather for /proc stuff " Benjamin Herrenschmidt
2007-07-09 6:46 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46920A0C.3040400@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.