[Xenomai-core] [PATCH] __deprecated not defined for Linux 2.4

[Xenomai-core] [PATCH] __deprecated not defined for Linux 2.4

[Wolfgang Grandegger]

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

Hello,

the attached patch changes:

   2007-07-09  Wolfgang Grandegger  <wg@domain.hid>

  * include/asm-generic/wrappers.h: add  __deprecated for Linux 2.4.

Wolfgang.



[-- Attachment #2: xenomai__deprecated.patch --]
[-- Type: text/x-patch, Size: 919 bytes --]

Index: include/asm-generic/wrappers.h
===================================================================
--- include/asm-generic/wrappers.h	(revision 2758)
+++ include/asm-generic/wrappers.h	(working copy)
@@ -179,6 +179,8 @@ void show_stack(struct task_struct *task
 
 #define atomic_cmpxchg(v, old, new) ((int)cmpxchg(&((v)->counter), old, new))
 
+#define __deprecated  __attribute__((deprecated))
+
 #else /* LINUX_VERSION_CODE >= KERNEL_VERSION(2,5,0) */
 
 #define compat_module_param_array(name, type, count, perm) \
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 2758)
+++ ChangeLog	(working copy)
@@ -1,3 +1,7 @@
+2007-07-09  Wolfgang Grandegger  <wg@domain.hid>
+
+	* include/asm-generic/wrappers.h: add  __deprecated for Linux 2.4.
+
 2007-07-08  Philippe Gerum  <rpm@xenomai.org>
 
 	* xenomai: Upgrade to autoconf 2.61, automake 1.10, libtool

Re: [Xenomai-core] [PATCH] __deprecated not defined for Linux 2.4

[Philippe Gerum]

On Mon, 2007-07-09 at 16:45 +0200, Wolfgang Grandegger wrote:
> Hello,
> 
> the attached patch changes:
> 
>    2007-07-09  Wolfgang Grandegger  <wg@domain.hid>
> 
>   * include/asm-generic/wrappers.h: add  __deprecated for Linux 2.4.
> 

Merged, thanks.

> Wolfgang.
> 
> 
> _______________________________________________
> Xenomai-core mailing list
> Xenomai-core@domain.hid
> https://mail.gna.org/listinfo/xenomai-core
-- 
Philippe.

Re: [Xenomai-core] [PATCH] __deprecated not defined for Linux 2.4

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]

Philippe Gerum wrote:
> On Mon, 2007-07-09 at 16:45 +0200, Wolfgang Grandegger wrote:
>> Hello,
>>
>> the attached patch changes:
>>
>>    2007-07-09  Wolfgang Grandegger  <wg@domain.hid>
>>
>>   * include/asm-generic/wrappers.h: add  __deprecated for Linux 2.4.
>>
> 
> Merged, thanks.

You are too fast for me - I was still test-building my approach!

Looks rather like I picked the wrong expression for marking
rtdm_task_sleep_until deprecated. I would prefer to go for this variant
and back Wolfgang's patch out again:

--- include/rtdm/rtdm_driver.h  (Revision 2758)
+++ include/rtdm/rtdm_driver.h  (Arbeitskopie)
@@ -1009,7 +1009,7 @@ rtdm_task_sleep_abs(nanosecs_abs_t wakeu
 }

 /* rtdm_task_sleep_abs shall be used instead */
-static inline int __deprecated
+static inline int __deprecated_call__
 rtdm_task_sleep_until(nanosecs_abs_t wakeup_time)
 {
     return __rtdm_task_sleep(wakeup_time, XN_REALTIME);


But note that I'm still test-building...

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]

Re: [Xenomai-core] [PATCH] __deprecated not defined for Linux 2.4

[Philippe Gerum]

On Mon, 2007-07-09 at 16:50 +0200, Jan Kiszka wrote:
> Philippe Gerum wrote:
> > On Mon, 2007-07-09 at 16:45 +0200, Wolfgang Grandegger wrote:
> >> Hello,
> >>
> >> the attached patch changes:
> >>
> >>    2007-07-09  Wolfgang Grandegger  <wg@domain.hid>
> >>
> >>   * include/asm-generic/wrappers.h: add  __deprecated for Linux 2.4.
> >>
> > 
> > Merged, thanks.
> 
> You are too fast for me - I was still test-building my approach!
> 
> Looks rather like I picked the wrong expression for marking
> rtdm_task_sleep_until deprecated. I would prefer to go for this variant
> and back Wolfgang's patch out again:

__deprecated is going to be useful in backporting 2.6 stuff to 2.4. This
is not only a RTDM issue.

> 
> --- include/rtdm/rtdm_driver.h  (Revision 2758)
> +++ include/rtdm/rtdm_driver.h  (Arbeitskopie)
> @@ -1009,7 +1009,7 @@ rtdm_task_sleep_abs(nanosecs_abs_t wakeu
>  }
> 
>  /* rtdm_task_sleep_abs shall be used instead */
> -static inline int __deprecated
> +static inline int __deprecated_call__
>  rtdm_task_sleep_until(nanosecs_abs_t wakeup_time)
>  {
>      return __rtdm_task_sleep(wakeup_time, XN_REALTIME);
> 
> 
> But note that I'm still test-building...
> 
> Jan
> 
-- 
Philippe.

Re: [Xenomai-core] [PATCH] __deprecated not defined for Linux 2.4

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 800 bytes --]

Philippe Gerum wrote:
> On Mon, 2007-07-09 at 16:50 +0200, Jan Kiszka wrote:
>> Philippe Gerum wrote:
>>> On Mon, 2007-07-09 at 16:45 +0200, Wolfgang Grandegger wrote:
>>>> Hello,
>>>>
>>>> the attached patch changes:
>>>>
>>>>    2007-07-09  Wolfgang Grandegger  <wg@domain.hid>
>>>>
>>>>   * include/asm-generic/wrappers.h: add  __deprecated for Linux 2.4.
>>>>
>>> Merged, thanks.
>> You are too fast for me - I was still test-building my approach!
>>
>> Looks rather like I picked the wrong expression for marking
>> rtdm_task_sleep_until deprecated. I would prefer to go for this variant
>> and back Wolfgang's patch out again:
> 
> __deprecated is going to be useful in backporting 2.6 stuff to 2.4. This
> is not only a RTDM issue.

No problem, as you like it.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]

Re: [Xenomai-core] [PATCH] __deprecated not defined for Linux 2.4

[Philippe Gerum]

On Mon, 2007-07-09 at 17:02 +0200, Jan Kiszka wrote:
> Philippe Gerum wrote:
> > On Mon, 2007-07-09 at 16:50 +0200, Jan Kiszka wrote:
> >> Philippe Gerum wrote:
> >>> On Mon, 2007-07-09 at 16:45 +0200, Wolfgang Grandegger wrote:
> >>>> Hello,
> >>>>
> >>>> the attached patch changes:
> >>>>
> >>>>    2007-07-09  Wolfgang Grandegger  <wg@domain.hid>
> >>>>
> >>>>   * include/asm-generic/wrappers.h: add  __deprecated for Linux 2.4.
> >>>>
> >>> Merged, thanks.
> >> You are too fast for me - I was still test-building my approach!
> >>
> >> Looks rather like I picked the wrong expression for marking
> >> rtdm_task_sleep_until deprecated. I would prefer to go for this variant
> >> and back Wolfgang's patch out again:
> > 
> > __deprecated is going to be useful in backporting 2.6 stuff to 2.4. This
> > is not only a RTDM issue.
> 
> No problem, as you like it.

Actually, I don't like wrappers that much, but, well...

-- 
Philippe.

Re: [Xenomai-core] [PATCH] __deprecated not defined for Linux 2.4

[Wolfgang Grandegger]

Jan Kiszka wrote:
> Philippe Gerum wrote:
>> On Mon, 2007-07-09 at 16:45 +0200, Wolfgang Grandegger wrote:
>>> Hello,
>>>
>>> the attached patch changes:
>>>
>>>    2007-07-09  Wolfgang Grandegger  <wg@domain.hid>
>>>
>>>   * include/asm-generic/wrappers.h: add  __deprecated for Linux 2.4.
>>>
>> Merged, thanks.
> 
> You are too fast for me - I was still test-building my approach!

Too fast? My i-Pipe patched Linux 2.4 kernel did simply not built ;-).

> Looks rather like I picked the wrong expression for marking
> rtdm_task_sleep_until deprecated. I would prefer to go for this variant
> and back Wolfgang's patch out again:
> 
> --- include/rtdm/rtdm_driver.h  (Revision 2758)
> +++ include/rtdm/rtdm_driver.h  (Arbeitskopie)
> @@ -1009,7 +1009,7 @@ rtdm_task_sleep_abs(nanosecs_abs_t wakeu
>  }
> 
>  /* rtdm_task_sleep_abs shall be used instead */
> -static inline int __deprecated
> +static inline int __deprecated_call__
>  rtdm_task_sleep_until(nanosecs_abs_t wakeup_time)
>  {
>      return __rtdm_task_sleep(wakeup_time, XN_REALTIME);
> 
> 
> But note that I'm still test-building...

OK, __deprecated_call__ does not make trouble with 2.4.

Wolfgang.

Re: [Xenomai-core] [PATCH] __deprecated not defined for Linux 2.4

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 1118 bytes --]

Wolfgang Grandegger wrote:
> Jan Kiszka wrote:
>> Philippe Gerum wrote:
>>> On Mon, 2007-07-09 at 16:45 +0200, Wolfgang Grandegger wrote:
>>>> Hello,
>>>>
>>>> the attached patch changes:
>>>>
>>>>    2007-07-09  Wolfgang Grandegger  <wg@domain.hid>
>>>>
>>>>   * include/asm-generic/wrappers.h: add  __deprecated for Linux 2.4.
>>>>
>>> Merged, thanks.
>>
>> You are too fast for me - I was still test-building my approach!
> 
> Too fast? My i-Pipe patched Linux 2.4 kernel did simply not built ;-).

Yeah, and my 2.4 kernel was lying around in the corner, slightly dusty,
definitely not touched for several months.

Hell, the amount of regressions one (specifically I) can produce due to
all this config variants is amazing. What would be really nice is a
playground for patches, some build system you could post a patch series
and a set of .configs to and that will then "simply" try to generate
various kernels and the xenomai userland for various archs
automatically, reporting back any errors or warnings. Without going
through SVN with the changes every time. Just a dream.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]

Re: [Xenomai-core] [PATCH] __deprecated not defined for Linux 2.4

[Philippe Gerum]

On Mon, 2007-07-09 at 17:14 +0200, Jan Kiszka wrote:
> Wolfgang Grandegger wrote:
> > Jan Kiszka wrote:
> >> Philippe Gerum wrote:
> >>> On Mon, 2007-07-09 at 16:45 +0200, Wolfgang Grandegger wrote:
> >>>> Hello,
> >>>>
> >>>> the attached patch changes:
> >>>>
> >>>>    2007-07-09  Wolfgang Grandegger  <wg@domain.hid>
> >>>>
> >>>>   * include/asm-generic/wrappers.h: add  __deprecated for Linux 2.4.
> >>>>
> >>> Merged, thanks.
> >>
> >> You are too fast for me - I was still test-building my approach!
> > 
> > Too fast? My i-Pipe patched Linux 2.4 kernel did simply not built ;-).
> 
> Yeah, and my 2.4 kernel was lying around in the corner, slightly dusty,
> definitely not touched for several months.
> 
> Hell, the amount of regressions one (specifically I) can produce due to
> all this config variants is amazing.

We all have a very well defined job in this project, and particularly:
- I do produce the original silly bugs.
- You are in charge of adding regressions to your past fixes of my bugs
- Dmitry is in charge of finding why our common code breaks.
- Wolfgang is in charge of making all the involved fixes compile
properly.
- Gilles is in charge of making the result run on bugous and/or sluggish
hardware.

Ok, all in all, my situation is the best one. Good.

>  What would be really nice is a
> playground for patches, some build system you could post a patch series
> and a set of .configs to and that will then "simply" try to generate
> various kernels and the xenomai userland for various archs
> automatically, reporting back any errors or warnings. Without going
> through SVN with the changes every time. Just a dream.

Niklaus already built most of this infrastructure for us, only the
automated patching part seems to be missing so far: 
http://ngiger.dyndns.org/buildbot/

We would also have to alleviate the burden of his server by providing
some dedicated hardware to do that, though.

> 
> Jan
> 
-- 
Philippe.

Re: [Xenomai-core] [PATCH] __deprecated not defined for Linux 2.4

[Philippe Gerum]

On Mon, 2007-07-09 at 17:32 +0200, Wolfgang Grandegger wrote:
> Philippe Gerum wrote:
> > On Mon, 2007-07-09 at 17:02 +0200, Jan Kiszka wrote:
> >> Philippe Gerum wrote:
> >>> On Mon, 2007-07-09 at 16:50 +0200, Jan Kiszka wrote:
> >>>> Philippe Gerum wrote:
> >>>>> On Mon, 2007-07-09 at 16:45 +0200, Wolfgang Grandegger wrote:
> >>>>>> Hello,
> >>>>>>
> >>>>>> the attached patch changes:
> >>>>>>
> >>>>>>    2007-07-09  Wolfgang Grandegger  <wg@domain.hid>
> >>>>>>
> >>>>>>   * include/asm-generic/wrappers.h: add  __deprecated for Linux 2.4.
> >>>>>>
> >>>>> Merged, thanks.
> >>>> You are too fast for me - I was still test-building my approach!
> >>>>
> >>>> Looks rather like I picked the wrong expression for marking
> >>>> rtdm_task_sleep_until deprecated. I would prefer to go for this variant
> >>>> and back Wolfgang's patch out again:
> >>> __deprecated is going to be useful in backporting 2.6 stuff to 2.4. This
> >>> is not only a RTDM issue.
> >> No problem, as you like it.
> > 
> > Actually, I don't like wrappers that much, but, well...
> 
> I just realized, that __deprecated_call__ is _not_ defined in 2.4 but 
> already in include/nucleus/compiler.h!
> 

Indeed. __deprecated should go there too btw. Will fix.

> Wolfgang.
> 
> 
-- 
Philippe.

Re: [Xenomai-core] [PATCH] __deprecated not defined for Linux 2.4

[Wolfgang Grandegger]

Philippe Gerum wrote:
> On Mon, 2007-07-09 at 17:02 +0200, Jan Kiszka wrote:
>> Philippe Gerum wrote:
>>> On Mon, 2007-07-09 at 16:50 +0200, Jan Kiszka wrote:
>>>> Philippe Gerum wrote:
>>>>> On Mon, 2007-07-09 at 16:45 +0200, Wolfgang Grandegger wrote:
>>>>>> Hello,
>>>>>>
>>>>>> the attached patch changes:
>>>>>>
>>>>>>    2007-07-09  Wolfgang Grandegger  <wg@domain.hid>
>>>>>>
>>>>>>   * include/asm-generic/wrappers.h: add  __deprecated for Linux 2.4.
>>>>>>
>>>>> Merged, thanks.
>>>> You are too fast for me - I was still test-building my approach!
>>>>
>>>> Looks rather like I picked the wrong expression for marking
>>>> rtdm_task_sleep_until deprecated. I would prefer to go for this variant
>>>> and back Wolfgang's patch out again:
>>> __deprecated is going to be useful in backporting 2.6 stuff to 2.4. This
>>> is not only a RTDM issue.
>> No problem, as you like it.
> 
> Actually, I don't like wrappers that much, but, well...

I just realized, that __deprecated_call__ is _not_ defined in 2.4 but 
already in include/nucleus/compiler.h!

Wolfgang.

Re: [Xenomai-core] [PATCH] __deprecated not defined for Linux 2.4

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 2923 bytes --]

Philippe Gerum wrote:
> On Mon, 2007-07-09 at 17:14 +0200, Jan Kiszka wrote:
>> Wolfgang Grandegger wrote:
>>> Jan Kiszka wrote:
>>>> Philippe Gerum wrote:
>>>>> On Mon, 2007-07-09 at 16:45 +0200, Wolfgang Grandegger wrote:
>>>>>> Hello,
>>>>>>
>>>>>> the attached patch changes:
>>>>>>
>>>>>>    2007-07-09  Wolfgang Grandegger  <wg@domain.hid>
>>>>>>
>>>>>>   * include/asm-generic/wrappers.h: add  __deprecated for Linux 2.4.
>>>>>>
>>>>> Merged, thanks.
>>>> You are too fast for me - I was still test-building my approach!
>>> Too fast? My i-Pipe patched Linux 2.4 kernel did simply not built ;-).
>> Yeah, and my 2.4 kernel was lying around in the corner, slightly dusty,
>> definitely not touched for several months.
>>
>> Hell, the amount of regressions one (specifically I) can produce due to
>> all this config variants is amazing.
> 
> We all have a very well defined job in this project, and particularly:
> - I do produce the original silly bugs.
> - You are in charge of adding regressions to your past fixes of my bugs
> - Dmitry is in charge of finding why our common code breaks.
> - Wolfgang is in charge of making all the involved fixes compile
> properly.
> - Gilles is in charge of making the result run on bugous and/or sluggish
> hardware.
> 
> Ok, all in all, my situation is the best one. Good.

Yeah, it's certainly not bad when the boss is happy. :)

> 
>>  What would be really nice is a
>> playground for patches, some build system you could post a patch series
>> and a set of .configs to and that will then "simply" try to generate
>> various kernels and the xenomai userland for various archs
>> automatically, reporting back any errors or warnings. Without going
>> through SVN with the changes every time. Just a dream.
> 
> Niklaus already built most of this infrastructure for us, only the
> automated patching part seems to be missing so far: 
> http://ngiger.dyndns.org/buildbot/

I'm very well aware of his work, but I also know that it was never
intended for broad use due to hardware and bandwidth constraints.
However, his buildbot scripts may indeed provide a helpful foundation.

> We would also have to alleviate the burden of his server by providing
> some dedicated hardware to do that, though.

That together with the required software infrastructure for more
automation are the points. We need some nice parallel box (4-way or
more) with a fast link and someone to look after the software. The
latter work may partly be distributed among the arch maintainers
(toolchain, kernel, .config updates). One could go even further with
such a platform, e.g. qemu targets, but let's concentrate on multi-arch,
multi-kernel build services first.

(My worries are also a bit egoistic: the nice 4-way box I'm using so far
for certain builds and tests will be definitely out of reach for me in
the near future.)

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]