From: Jeff Garzik <jeff@garzik.org>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Fajun Chen <fajunchen@gmail.com>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: Question about PATA Sil680 Bus Reset Code
Date: Mon, 09 Jul 2007 14:46:08 -0400 [thread overview]
Message-ID: <46928270.5030709@garzik.org> (raw)
In-Reply-To: <46928051.5080907@ru.mvista.com>
Sergei Shtylyov wrote:
> The code indeed does seem meaningless. For the libata it could make
> sense to set bit 2 for the hardreset -- but then sil680_error_handler()
> needs to be turn into ata_bmdma_drive_eh(ap, ata_std_prereset,
> ata_std_softreset, sil680_bus_reset, ata_std_postreset)...
Presuming bit 2 == hardreset... correct.
In some datasheets it is not clear whether this means resetting the
silicon's ATA state machine, or truly hard-resetting the port. There is
occasionally a difference. I do not remember if Sil680 is one of those.
Jeff
next prev parent reply other threads:[~2007-07-09 18:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-09 16:46 Question about PATA Sil680 Bus Reset Code Fajun Chen
2007-07-09 16:58 ` Jeff Garzik
2007-07-09 18:37 ` Sergei Shtylyov
2007-07-09 18:46 ` Jeff Garzik [this message]
2007-07-09 18:51 ` Sergei Shtylyov
2007-07-09 22:09 ` Alan Cox
2007-07-10 12:58 ` Sergei Shtylyov
2007-07-10 22:00 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46928270.5030709@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=fajunchen@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.