* [PATCH 2.6] SoftMAC : fix ESSID problem
@ 2007-07-09 22:19 ` Jean Tourrilhes
0 siblings, 0 replies; 7+ messages in thread
From: Jean Tourrilhes @ 2007-07-09 22:19 UTC (permalink / raw)
To: John W. Linville, linux-wireless, netdev
Hi,
Victor Porton reported that the SoftMAC layer had random
problem when setting the ESSID :
http://bugzilla.kernel.org/show_bug.cgi?id=8686
After investigation, it turned out to be worse, the SoftMAC
layer is left in an inconsistent state. The fix is pretty trivial.
John : would you mind pushing that to 2.6.23 ?
Thanks...
Jean
Signed-off-by: Jean Tourrilhes <jt@hpl.hp.com>
-----------------------------------------------------------
--- linux/net/ieee80211/softmac/ieee80211softmac_assoc.j1.c 2007-07-09 13:56:13.000000000 -0700
+++ linux/net/ieee80211/softmac/ieee80211softmac_assoc.c 2007-07-09 13:56:41.000000000 -0700
@@ -271,8 +271,11 @@ ieee80211softmac_assoc_work(struct work_
*/
dprintk(KERN_INFO PFX "Associate: Scanning for networks first.\n");
ieee80211softmac_notify(mac->dev, IEEE80211SOFTMAC_EVENT_SCAN_FINISHED, ieee80211softmac_assoc_notify_scan, NULL);
- if (ieee80211softmac_start_scan(mac))
+ if (ieee80211softmac_start_scan(mac)) {
dprintk(KERN_INFO PFX "Associate: failed to initiate scan. Is device up?\n");
+ mac->associnfo.associating = 0;
+ mac->associnfo.associated = 0;
+ }
goto out;
} else {
mac->associnfo.associating = 0;
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 2.6] SoftMAC : fix ESSID problem
@ 2007-07-09 22:19 ` Jean Tourrilhes
0 siblings, 0 replies; 7+ messages in thread
From: Jean Tourrilhes @ 2007-07-09 22:19 UTC (permalink / raw)
To: John W. Linville, linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA
Hi,
Victor Porton reported that the SoftMAC layer had random
problem when setting the ESSID :
http://bugzilla.kernel.org/show_bug.cgi?id=8686
After investigation, it turned out to be worse, the SoftMAC
layer is left in an inconsistent state. The fix is pretty trivial.
John : would you mind pushing that to 2.6.23 ?
Thanks...
Jean
Signed-off-by: Jean Tourrilhes <jt-sDzT885Ts8HQT0dZR+AlfA@public.gmane.org>
-----------------------------------------------------------
--- linux/net/ieee80211/softmac/ieee80211softmac_assoc.j1.c 2007-07-09 13:56:13.000000000 -0700
+++ linux/net/ieee80211/softmac/ieee80211softmac_assoc.c 2007-07-09 13:56:41.000000000 -0700
@@ -271,8 +271,11 @@ ieee80211softmac_assoc_work(struct work_
*/
dprintk(KERN_INFO PFX "Associate: Scanning for networks first.\n");
ieee80211softmac_notify(mac->dev, IEEE80211SOFTMAC_EVENT_SCAN_FINISHED, ieee80211softmac_assoc_notify_scan, NULL);
- if (ieee80211softmac_start_scan(mac))
+ if (ieee80211softmac_start_scan(mac)) {
dprintk(KERN_INFO PFX "Associate: failed to initiate scan. Is device up?\n");
+ mac->associnfo.associating = 0;
+ mac->associnfo.associated = 0;
+ }
goto out;
} else {
mac->associnfo.associating = 0;
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 2.6] SoftMAC : fix ESSID problem
2007-07-09 22:19 ` Jean Tourrilhes
(?)
@ 2007-07-09 22:46 ` Michael Buesch
2007-07-09 23:40 ` Larry Finger
-1 siblings, 1 reply; 7+ messages in thread
From: Michael Buesch @ 2007-07-09 22:46 UTC (permalink / raw)
To: jt; +Cc: John W. Linville, linux-wireless, netdev
On Tuesday 10 July 2007 00:19:22 Jean Tourrilhes wrote:
> Hi,
>
> Victor Porton reported that the SoftMAC layer had random
> problem when setting the ESSID :
> http://bugzilla.kernel.org/show_bug.cgi?id=8686
> After investigation, it turned out to be worse, the SoftMAC
> layer is left in an inconsistent state. The fix is pretty trivial.
> John : would you mind pushing that to 2.6.23 ?
> Thanks...
>
> Jean
>
> Signed-off-by: Jean Tourrilhes <jt@hpl.hp.com>
>
> -----------------------------------------------------------
>
> --- linux/net/ieee80211/softmac/ieee80211softmac_assoc.j1.c 2007-07-09 13:56:13.000000000 -0700
> +++ linux/net/ieee80211/softmac/ieee80211softmac_assoc.c 2007-07-09 13:56:41.000000000 -0700
> @@ -271,8 +271,11 @@ ieee80211softmac_assoc_work(struct work_
> */
> dprintk(KERN_INFO PFX "Associate: Scanning for networks first.\n");
> ieee80211softmac_notify(mac->dev, IEEE80211SOFTMAC_EVENT_SCAN_FINISHED, ieee80211softmac_assoc_notify_scan, NULL);
> - if (ieee80211softmac_start_scan(mac))
> + if (ieee80211softmac_start_scan(mac)) {
> dprintk(KERN_INFO PFX "Associate: failed to initiate scan. Is device up?\n");
> + mac->associnfo.associating = 0;
> + mac->associnfo.associated = 0;
> + }
> goto out;
> } else {
> mac->associnfo.associating = 0;
>
Acked-by: Michael Buesch <mb@bu3sch.de>
--
Greetings Michael.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 2.6] SoftMAC : fix ESSID problem
@ 2007-07-09 23:40 ` Larry Finger
0 siblings, 0 replies; 7+ messages in thread
From: Larry Finger @ 2007-07-09 23:40 UTC (permalink / raw)
To: Michael Buesch; +Cc: jt, John W. Linville, linux-wireless, netdev
Michael Buesch wrote:
> On Tuesday 10 July 2007 00:19:22 Jean Tourrilhes wrote:
>> Hi,
>>
>> Victor Porton reported that the SoftMAC layer had random
>> problem when setting the ESSID :
>> http://bugzilla.kernel.org/show_bug.cgi?id=8686
>> After investigation, it turned out to be worse, the SoftMAC
>> layer is left in an inconsistent state. The fix is pretty trivial.
>> John : would you mind pushing that to 2.6.23 ?
>> Thanks...
>>
>> Jean
>>
>> Signed-off-by: Jean Tourrilhes <jt@hpl.hp.com>
>>
>> -----------------------------------------------------------
>>
>> --- linux/net/ieee80211/softmac/ieee80211softmac_assoc.j1.c 2007-07-09 13:56:13.000000000 -0700
>> +++ linux/net/ieee80211/softmac/ieee80211softmac_assoc.c 2007-07-09 13:56:41.000000000 -0700
>> @@ -271,8 +271,11 @@ ieee80211softmac_assoc_work(struct work_
>> */
>> dprintk(KERN_INFO PFX "Associate: Scanning for networks first.\n");
>> ieee80211softmac_notify(mac->dev, IEEE80211SOFTMAC_EVENT_SCAN_FINISHED, ieee80211softmac_assoc_notify_scan, NULL);
>> - if (ieee80211softmac_start_scan(mac))
>> + if (ieee80211softmac_start_scan(mac)) {
>> dprintk(KERN_INFO PFX "Associate: failed to initiate scan. Is device up?\n");
>> + mac->associnfo.associating = 0;
>> + mac->associnfo.associated = 0;
>> + }
>> goto out;
>> } else {
>> mac->associnfo.associating = 0;
>>
>
> Acked-by: Michael Buesch <mb@bu3sch.de>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
This patch should also be sent to stable@kernel.org.
Larry
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 2.6] SoftMAC : fix ESSID problem
@ 2007-07-09 23:40 ` Larry Finger
0 siblings, 0 replies; 7+ messages in thread
From: Larry Finger @ 2007-07-09 23:40 UTC (permalink / raw)
To: Michael Buesch
Cc: jt-sDzT885Ts8HQT0dZR+AlfA, John W. Linville,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA
Michael Buesch wrote:
> On Tuesday 10 July 2007 00:19:22 Jean Tourrilhes wrote:
>> Hi,
>>
>> Victor Porton reported that the SoftMAC layer had random
>> problem when setting the ESSID :
>> http://bugzilla.kernel.org/show_bug.cgi?id=8686
>> After investigation, it turned out to be worse, the SoftMAC
>> layer is left in an inconsistent state. The fix is pretty trivial.
>> John : would you mind pushing that to 2.6.23 ?
>> Thanks...
>>
>> Jean
>>
>> Signed-off-by: Jean Tourrilhes <jt-sDzT885Ts8HQT0dZR+AlfA@public.gmane.org>
>>
>> -----------------------------------------------------------
>>
>> --- linux/net/ieee80211/softmac/ieee80211softmac_assoc.j1.c 2007-07-09 13:56:13.000000000 -0700
>> +++ linux/net/ieee80211/softmac/ieee80211softmac_assoc.c 2007-07-09 13:56:41.000000000 -0700
>> @@ -271,8 +271,11 @@ ieee80211softmac_assoc_work(struct work_
>> */
>> dprintk(KERN_INFO PFX "Associate: Scanning for networks first.\n");
>> ieee80211softmac_notify(mac->dev, IEEE80211SOFTMAC_EVENT_SCAN_FINISHED, ieee80211softmac_assoc_notify_scan, NULL);
>> - if (ieee80211softmac_start_scan(mac))
>> + if (ieee80211softmac_start_scan(mac)) {
>> dprintk(KERN_INFO PFX "Associate: failed to initiate scan. Is device up?\n");
>> + mac->associnfo.associating = 0;
>> + mac->associnfo.associated = 0;
>> + }
>> goto out;
>> } else {
>> mac->associnfo.associating = 0;
>>
>
> Acked-by: Michael Buesch <mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
Acked-by: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
This patch should also be sent to stable-DgEjT+Ai2yi4UlQgPVntAg@public.gmane.org
Larry
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 2.6] SoftMAC : fix ESSID problem
@ 2007-07-09 23:44 ` Jean Tourrilhes
0 siblings, 0 replies; 7+ messages in thread
From: Jean Tourrilhes @ 2007-07-09 23:44 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless, netdev
On Mon, Jul 09, 2007 at 06:40:44PM -0500, Larry Finger wrote:
>
> This patch should also be sent to stable@kernel.org.
Please do so if you like it.
> Larry
Jean
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2007-07-09 23:44 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-09 22:19 [PATCH 2.6] SoftMAC : fix ESSID problem Jean Tourrilhes
2007-07-09 22:19 ` Jean Tourrilhes
2007-07-09 22:46 ` Michael Buesch
2007-07-09 23:40 ` Larry Finger
2007-07-09 23:40 ` Larry Finger
2007-07-09 23:44 ` Jean Tourrilhes
2007-07-09 23:44 ` Jean Tourrilhes
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.