From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Vitaly Bordug <vitb@kernel.crashing.org>
Cc: linux-ide@vger.kernel.org, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] [POWERPC] mmio ide support for mpc8349-itx target
Date: Wed, 11 Jul 2007 23:02:27 +0400 [thread overview]
Message-ID: <46952943.2080007@ru.mvista.com> (raw)
In-Reply-To: <20070710145256.6ac64e11@localhost.localdomain>
Hello.
Vitaly Bordug wrote:
>>>+
>>>+#ifdef CONFIG_MPC834x_ITX
>> Erm, isn't this stuff misplaced? Is this really SoC device? I
>>remember seeng this in the arch/ppc/ platform code before (in the
>>internal tree)...
> The point is to declare methods bsp, as mmio access may effectively vary (having bugs or intentionally) from platform to platform. All-in-one driver approach is nice but might be an issue to handle/maintain.
You misunderstood. Why this was placed in fsl_soc.c and not in the proper
platform code (as it was in the internal tree even)?
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Vitaly Bordug <vitb@kernel.crashing.org>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/2] [POWERPC] mmio ide support for mpc8349-itx target
Date: Wed, 11 Jul 2007 23:02:27 +0400 [thread overview]
Message-ID: <46952943.2080007@ru.mvista.com> (raw)
In-Reply-To: <20070710145256.6ac64e11@localhost.localdomain>
Hello.
Vitaly Bordug wrote:
>>>+
>>>+#ifdef CONFIG_MPC834x_ITX
>> Erm, isn't this stuff misplaced? Is this really SoC device? I
>>remember seeng this in the arch/ppc/ platform code before (in the
>>internal tree)...
> The point is to declare methods bsp, as mmio access may effectively vary (having bugs or intentionally) from platform to platform. All-in-one driver approach is nice but might be an issue to handle/maintain.
You misunderstood. Why this was placed in fsl_soc.c and not in the proper
platform code (as it was in the internal tree even)?
MBR, Sergei
next prev parent reply other threads:[~2007-07-11 19:00 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-07 9:48 [PATCH 1/2] [ide] mmio ide support Vitaly Bordug
2007-07-07 9:48 ` Vitaly Bordug
2007-07-07 9:48 ` Vitaly Bordug
2007-07-07 9:49 ` [PATCH 2/2] [POWERPC] mmio ide support for mpc8349-itx target Vitaly Bordug
2007-07-07 9:49 ` Vitaly Bordug
2007-07-07 9:49 ` Vitaly Bordug
2007-07-07 15:07 ` Olof Johansson
2007-07-07 15:07 ` Olof Johansson
2007-07-07 15:12 ` Arnd Bergmann
2007-07-07 15:12 ` Arnd Bergmann
2007-07-07 16:46 ` Sergei Shtylyov
2007-07-07 16:46 ` Sergei Shtylyov
2007-07-08 13:31 ` Segher Boessenkool
2007-07-08 13:31 ` Segher Boessenkool
2007-07-10 10:52 ` Vitaly Bordug
2007-07-10 10:52 ` Vitaly Bordug
2007-07-11 19:02 ` Sergei Shtylyov [this message]
2007-07-11 19:02 ` Sergei Shtylyov
2007-07-07 12:19 ` [PATCH 1/2] [ide] mmio ide support Arnd Bergmann
2007-07-07 12:19 ` Arnd Bergmann
2007-07-07 16:51 ` Sergei Shtylyov
2007-07-07 18:07 ` Arnd Bergmann
2007-07-07 18:07 ` Arnd Bergmann
2007-07-08 13:15 ` Bartlomiej Zolnierkiewicz
2007-07-08 13:15 ` Bartlomiej Zolnierkiewicz
2007-07-10 18:49 ` Linas Vepstas
2007-07-10 18:49 ` Linas Vepstas
2007-07-07 20:02 ` Alan Cox
2007-07-07 20:02 ` Alan Cox
2007-07-08 0:54 ` Benjamin Herrenschmidt
2007-07-08 0:54 ` Benjamin Herrenschmidt
2007-07-07 15:01 ` Olof Johansson
2007-07-07 15:01 ` Olof Johansson
2007-07-10 10:53 ` Vitaly Bordug
2007-07-10 10:53 ` Vitaly Bordug
2007-07-10 10:53 ` Vitaly Bordug
2007-07-07 18:15 ` Sergei Shtylyov
2007-07-07 18:15 ` Sergei Shtylyov
2007-07-07 20:13 ` Alan Cox
2007-07-07 20:13 ` Alan Cox
2007-07-10 11:02 ` Vitaly Bordug
2007-07-10 11:02 ` Vitaly Bordug
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46952943.2080007@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=vitb@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.