From: Henne <henne@nachtwindheim.de>
To: Arjan van de Ven <arjan@infradead.org>
Cc: len.brown@intel.com, linux-acpi@vger.kernel.org,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][BUTTON] remove procfs-interface
Date: Thu, 12 Jul 2007 11:40:54 +0200 [thread overview]
Message-ID: <4695F726.7030203@nachtwindheim.de> (raw)
In-Reply-To: <1184230838.2720.5.camel@laptopd505.fenrus.org>
Arjan van de Ven wrote:
> On Thu, 2007-07-12 at 10:58 +0200, Henne wrote:
>
>> Removes the proc_fs interface from the ACPI button driver.
>> Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
>>
>> ---
>>
>
> you forgot to say why.....
>
>
>
First, because refering to /Documentation/feature-removal-schedule.txt it should be done:
>What: /proc/acpi/button
>When: August 2007
>Why: /proc/acpi/button has been replaced by events to the input layer
> since 2.6.20.
>Who: Len Brown <len.brown@intel.com>
Second, refering to /Documentation/feature-removal-schedule.txt
>What: ACPI procfs interface
>When: July 2007
>Why: After ACPI sysfs conversion, ACPI attributes will be duplicated
> in sysfs and the ACPI procfs interface should be removed.
>Who: Zhang Rui <rui.zhang@intel.com>
The button driver uses acpi_root_dir which won't be available if acpi is removed this month.
That would lead to errors, I think.
WARNING: multiple messages have this Message-ID (diff)
From: Henne <henne@nachtwindheim.de>
To: Arjan van de Ven <arjan@infradead.org>
Cc: len.brown@intel.com, linux-acpi@vger.kernel.org,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][ACPI][BUTTON] remove procfs-interface
Date: Thu, 12 Jul 2007 11:40:54 +0200 [thread overview]
Message-ID: <4695F726.7030203@nachtwindheim.de> (raw)
In-Reply-To: <1184230838.2720.5.camel@laptopd505.fenrus.org>
Arjan van de Ven wrote:
> On Thu, 2007-07-12 at 10:58 +0200, Henne wrote:
>
>> Removes the proc_fs interface from the ACPI button driver.
>> Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
>>
>> ---
>>
>
> you forgot to say why.....
>
>
>
First, because refering to /Documentation/feature-removal-schedule.txt it should be done:
>What: /proc/acpi/button
>When: August 2007
>Why: /proc/acpi/button has been replaced by events to the input layer
> since 2.6.20.
>Who: Len Brown <len.brown@intel.com>
Second, refering to /Documentation/feature-removal-schedule.txt
>What: ACPI procfs interface
>When: July 2007
>Why: After ACPI sysfs conversion, ACPI attributes will be duplicated
> in sysfs and the ACPI procfs interface should be removed.
>Who: Zhang Rui <rui.zhang@intel.com>
The button driver uses acpi_root_dir which won't be available if acpi is removed this month.
That would lead to errors, I think.
next prev parent reply other threads:[~2007-07-12 9:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-12 8:58 [PATCH][ACPI][BUTTON] remove procfs-interface Henne
2007-07-12 9:00 ` [PATCH][BUTTON] " Arjan van de Ven
2007-07-12 9:00 ` [PATCH][ACPI][BUTTON] " Arjan van de Ven
2007-07-12 9:40 ` Henne [this message]
2007-07-12 9:40 ` Henne
2007-07-12 9:46 ` [PATCH][BUTTON] " Zhang, Rui
2007-07-12 9:46 ` [PATCH][ACPI][BUTTON] " Zhang, Rui
2007-07-12 10:26 ` [PATCH][BUTTON] " Richard Hughes
2007-07-12 10:26 ` [PATCH][ACPI][BUTTON] " Richard Hughes
2007-07-12 14:38 ` [PATCH][BUTTON] " Brown, Len
2007-07-12 14:38 ` [PATCH][ACPI][BUTTON] " Brown, Len
2007-07-12 19:07 ` [PATCH][BUTTON] " Satyam Sharma
2007-07-12 19:07 ` [PATCH][ACPI][BUTTON] " Satyam Sharma
2007-07-13 7:23 ` [PATCH][BUTTON] " Zhang Rui
2007-07-13 7:23 ` [PATCH][ACPI][BUTTON] " Zhang Rui
2007-07-16 7:35 ` [PATCH][BUTTON] " Stefan Seyfried
2007-07-16 7:47 ` Satyam Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4695F726.7030203@nachtwindheim.de \
--to=henne@nachtwindheim.de \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.