From: "H. Peter Anvin" <hpa@zytor.com>
To: Gabriel C <nix.or.die@googlemail.com>
Cc: linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
trivial@kernel.org
Subject: Re: [PATCH] broken lilo check on make install
Date: Fri, 13 Jul 2007 15:29:17 -0700 [thread overview]
Message-ID: <4697FCBD.7050003@zytor.com> (raw)
In-Reply-To: <46969586.5050507@googlemail.com>
Gabriel C wrote:
>
> I don't use and don't have lilo installed on this system. The attached
> patch fixes the problem for me.
>
You also don't have a /sbin/installkernel, which is arguably a bug too.
However, the patch mostly makes sense, although I would suggest putting
a "sync" in the else clause.
With that caveat, Acked-by: H. Peter Anvin <hpa@zytor.com>
> Signed-off-by: Gabriel Craciunescu <nix.or.die@googlemail.com>
>
>
> diff --git a/arch/i386/boot/install.sh b/arch/i386/boot/install.sh
> index 5e44c73..7099fd6 100644
> --- a/arch/i386/boot/install.sh
> +++ b/arch/i386/boot/install.sh
> @@ -51,4 +51,10 @@ fi
> cat $2 > $4/vmlinuz
> cp $3 $4/System.map
>
> -if [ -x /sbin/lilo ]; then /sbin/lilo; else /etc/lilo/install; fi
> +if [ -x /sbin/lilo ]; then
> + /sbin/lilo
> +elif [ -x /etc/lilo/install ]; then
> + /etc/lilo/install
> +else
> + echo "Cannot find LILO."
> +fi
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2007-07-13 22:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-12 20:56 [PATCH] broken lilo check on make install Gabriel C
2007-07-13 22:29 ` H. Peter Anvin [this message]
2007-07-14 9:59 ` Gabriel C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4697FCBD.7050003@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nix.or.die@googlemail.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.