From: Gabriel C <nix.or.die@googlemail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
trivial@kernel.org
Subject: Re: [PATCH] broken lilo check on make install
Date: Sat, 14 Jul 2007 11:59:44 +0200 [thread overview]
Message-ID: <46989E90.2020906@googlemail.com> (raw)
In-Reply-To: <4697FCBD.7050003@zytor.com>
H. Peter Anvin wrote:
> Gabriel C wrote:
>
>> I don't use and don't have lilo installed on this system. The attached
>> patch fixes the problem for me.
>>
>>
>
> You also don't have a /sbin/installkernel, which is arguably a bug too.
> However, the patch mostly makes sense, although I would suggest putting
> a "sync" in the else clause.
>
Ok , I've changed the patch to use sync.
> With that caveat, Acked-by: H. Peter Anvin <hpa@zytor.com>
>
>
Signed-off-by: Gabriel Craciunescu <nix.or.die@googlemail.com>
arch/i386/boot/install.sh | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/arch/i386/boot/install.sh b/arch/i386/boot/install.sh
index 5e44c73..cb55f67 100644
--- a/arch/i386/boot/install.sh
+++ b/arch/i386/boot/install.sh
@@ -51,4 +51,11 @@ fi
cat $2 > $4/vmlinuz
cp $3 $4/System.map
-if [ -x /sbin/lilo ]; then /sbin/lilo; else /etc/lilo/install; fi
+if [ -x /sbin/lilo ]; then
+ /sbin/lilo
+elif [ -x /etc/lilo/install ]; then
+ /etc/lilo/install
+else
+ sync
+ echo "Cannot find LILO."
+fi
prev parent reply other threads:[~2007-07-14 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-12 20:56 [PATCH] broken lilo check on make install Gabriel C
2007-07-13 22:29 ` H. Peter Anvin
2007-07-14 9:59 ` Gabriel C [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46989E90.2020906@googlemail.com \
--to=nix.or.die@googlemail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.